Page MenuHomeGitPull.it
Differential D90

Add info button in the drawer menu
ClosedPublic
Actions

Authored by fabio.mazza on Jun 12 2022, 22:59.
Tags
Referenced Files
F2106477: D90.diff
Thu, Apr 25, 05:50
Unknown Object (File)
Mon, Apr 22, 04:09
Unknown Object (File)
Fri, Apr 19, 13:44
Unknown Object (File)
Thu, Apr 18, 13:17
Unknown Object (File)
Thu, Apr 18, 13:16
Unknown Object (File)
Thu, Apr 18, 13:16
Unknown Object (File)
Sun, Apr 14, 15:13
Unknown Object (File)
Fri, Apr 12, 04:09
View All Files
Subscribers
valerio.bozzolan
Libre BusTO

Details

Reviewers
valerio.bozzolan
Commits
R4:52bcb21141f4: Add info button in the drawer menu
Test Plan

Check it works

Diff Detail

Repository
R4 Libre BusTO
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Jun 12 2022, 22:59
Restricted Application added a project: Libre BusTO . · View Herald TranscriptJun 12 2022, 22:59
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.Jun 12 2022, 23:02

Be bop be bop. I'm a bot. Builded:

→ D90-libre-busto-unsigned.apk

Harbormaster completed remote builds in B333: Diff 307.Jun 12 2022, 23:02
fabio.mazza requested review of this revision.Jun 12 2022, 23:02
valerio.bozzolan accepted this revision.Jun 13 2022, 08:41

sgtm

Nice

Now from the hamburger menu we can:

  • drop the "More information" menu entry
  • move "Contribute" as a button in the bottom of the info page
  • move "Source code" as a button in the bottom of the info page
  • move "License" as a button in the bottom of the info page
  • drop the "Experiments" menu
This revision is now accepted and ready to land.Jun 13 2022, 08:41
Closed by commit R4:52bcb21141f4: Add info button in the drawer menu. · Explain WhyJun 13 2022, 08:42
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: R4:52bcb21141f4: Add info button in the drawer menu.
valerio.bozzolan mentioned this in T1095: Move stuff in the sidebar (drawer menu).Jun 14 2022, 11:32

Revision Contents
Changeset List

PathSize
res/
drawable/
5 lines
5 lines
menu/
5 lines
src/
it/
reyboz/
bustorino/
4 lines

Diff 308

View Options

res/drawable/ic_baseline_info_24.xml

Loading...
View Options

res/drawable/ic_outline_info_24.xml

Loading...
View Options

res/menu/drawer_main.xml

Loading...
View Options

src/it/reyboz/bustorino/ActivityPrincipal.java

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register