diff --git "a/class-wb\\Snak.php" "b/class-wb\\Snak.php" index 14ad67f..186fca1 100644 --- "a/class-wb\\Snak.php" +++ "b/class-wb\\Snak.php" @@ -1,110 +1,115 @@ . # Wikibase namespace wb; /** * A generic Snak is a combination of a property and a datatype + datavalue. * * A Snak is part of a Claim or a Reference. It's based on a DataValue. */ class Snak { //var $hash; var $snaktype; var $property; var $datatype; var $datavalue; /** * @param $snaktype string * @param $property string * @param $datatype string * @param $datavalue mixed */ - public function __construct( $snaktype, $property, $datatype, $datavalue ) { + public function __construct( $snaktype, $property, $datatype, $datavalue = null ) { $this->setSnakType( $snaktype ) ->setProperty( $property ) - ->setDataType( $datatype ) - ->setDataValue( $datavalue ); + ->setDataType( $datatype ); + + if( null !== $datavalue ) { + $this->setDataValue( $datavalue ); + } } public function getProperty() { return $this->property; } public function getSnakType() { return $this->snaktype; } public function getDataType() { return $this->datatype; } public function getDataValue() { return $this->datavalue; } public function setSnakType( $snaktype ) { $this->snaktype = $snaktype; return $this; } public function setProperty( $property ) { $this->property = $property; return $this; } public function setDataType( $datatype ) { $this->datatype = $datatype; return $this; } public function setDataValue( DataValue $datavalue ) { $this->datavalue = $datavalue; return $this; } public function hasHash() { return isset( $this->hash ); } public function getHash() { return $this->hash; } public function setHash( $hash ) { $this->hash = $hash; } public static function createFromData( $data ) { - if( ! isset( $data['snaktype'], $data['property'], $data['datatype'], $data['datavalue'] ) ) { + if( ! isset( $data['snaktype'], $data['property'], $data['datatype'] ) ) { throw new WrongDataException( __CLASS__ ); } $snak = new self( $data['snaktype'], $data['property'], - $data['datatype'], - DataValue::createFromData( $data['datavalue'] ) + $data['datatype'] ); + if( isset( $data['datavalue'] ) ) { + $snak->setDataValue( DataValue::createFromData( $data['datavalue'] ) ); + } if( isset( $data['hash'] ) ) { $snak->setHash( $data['hash'] ); } return $snak; } }