diff --git "a/include/class-mw\\API\\Exception.php" "b/include/class-mw\\API\\Exception.php" index 4a695f6..3411da9 100644 --- "a/include/class-mw\\API\\Exception.php" +++ "b/include/class-mw\\API\\Exception.php" @@ -1,102 +1,104 @@ . # MediaWiki API namespace mw\API; /** * Generic API exception class */ class Exception extends \Exception { /** * API error object * * @var object */ private $apiError; /** * Constructor * * @param $api_error object The complete error * @param $code int * @param $previous object */ public function __construct( $api_error, $code = 0, Exception $previous = null ) { $this->apiError = $api_error; parent::__construct( sprintf( "API error code: '%s' info: '%s'", $this->getApiErrorCode(), $this->getApiErrorInfo() ), $code, $previous ); } /** * Create a specific exception from a generic API error * * @param $api_error object The complete error * @return self */ public static function createFromApiError( $api_error ) { $known_exceptions = [ BadTokenException ::class, MaxLagException ::class, ArticleExistsException::class, MissingTitleException ::class, ProtectedPageException::class, ]; + $exception = new self( $api_error ); $code = $exception->getApiErrorCode(); - foreach( $known_exceptions as $exception ) { - if( $exception::API_ERROR_CODE === $code ) { - return new $exception( $api_error ); + foreach( $known_exceptions as $known_exception_name ) { + if( $known_exception_name::API_ERROR_CODE === $code ) { + $exception = new $known_exception_name( $api_error ); + break; } } - return new self( $api_error ); + return $exception; } /** * Get the complete error object * * @return object */ public function getApiError() { return $this->apiError; } /** * Get the API error code * * @return string */ public function getApiErrorCode() { return $this->getApiError()->code; } /** * Get the API error info * * @return string */ public function getApiErrorInfo() { return $this->getApiError()->info; } }