Page MenuHomeGitPull.it

Add wbremoveclaims functionality
Needs RevisionPublic

Authored by lucamauri on Jan 6 2024, 12:27.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 21, 14:23
Unknown Object (File)
Sat, Jul 20, 17:36
Unknown Object (File)
Mon, Jul 15, 03:36
Unknown Object (File)
Mon, Jul 15, 03:32
Unknown Object (File)
Mon, Jul 15, 02:06
Unknown Object (File)
Fri, Jul 12, 16:13
Unknown Object (File)
Fri, Jul 12, 14:47
Unknown Object (File)
Fri, Jul 12, 14:47
Subscribers
None

Details

Reviewers
valerio.bozzolan
Summary
Test Plan

We test in production. asd

Diff Detail

Repository
R21 boz-mw: MediaWiki API client
Branch
lucamauri/lucamauri-RemoveClaim
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 496
Build 722: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.

Thanks Luca asd

In general I like the StaticWikibaseSite.removeClaims(). Are you OK with the additional "s"?

But I'm unsure about the shortcut from the DataModel object. Since, it's not using any information related to that data, but just the website. I think it's not enough.

What do you think about?

include/mw/StaticWikibaseSite.php
99
include/wb/DataModel.php
542

Maybe better to be consistent with the API name

551

This default is probably not working since it defaults to Q-something and not to the Claim ID.

554–557

This is probably the first time I see a similar default. Maybe better to omit.

559
valerio.bozzolan retitled this revision from Add wbremoveclaims functionality Import from: https://github.com/valerio-bozzolan/boz-mw/pull/14 to Add wbremoveclaims functionality.
valerio.bozzolan edited the summary of this revision. (Show Details)
This revision now requires changes to proceed.Jan 7 2024, 10:59