Page Menu
Home
GitPull.it
Search
Configure Global Search
Log In
Files
F11869441
D65.1774961083.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D65.1774961083.diff
View Options
diff --git a/src/it/reyboz/bustorino/ActivityPrincipal.java b/src/it/reyboz/bustorino/ActivityPrincipal.java
--- a/src/it/reyboz/bustorino/ActivityPrincipal.java
+++ b/src/it/reyboz/bustorino/ActivityPrincipal.java
@@ -1,6 +1,7 @@
package it.reyboz.bustorino;
import android.Manifest;
+import android.content.Context;
import android.content.Intent;
import android.content.SharedPreferences;
import android.content.pm.PackageManager;
@@ -74,7 +75,7 @@
getSupportActionBar().setDisplayHomeAsUpEnabled(true);
else Log.w(DEBUG_TAG, "NO ACTION BAR");
- mToolbar.setOnMenuItemClickListener(new ToolbarItemClickListener());
+ mToolbar.setOnMenuItemClickListener(new ToolbarItemClickListener(this));
mDrawer = findViewById(R.id.drawer_layout);
@@ -192,6 +193,7 @@
for (WorkInfo workInfo : workInfoList) {
if (workInfo.getState() == WorkInfo.State.RUNNING) {
showProgress = true;
+ break;
}
}
@@ -537,6 +539,11 @@
}
class ToolbarItemClickListener implements Toolbar.OnMenuItemClickListener{
+ private final Context activityContext;
+
+ public ToolbarItemClickListener(Context activityContext) {
+ this.activityContext = activityContext;
+ }
@Override
public boolean onMenuItemClick(MenuItem item) {
@@ -545,13 +552,13 @@
startActivity(new Intent(ActivityPrincipal.this, ActivityAbout.class));
return true;
case R.id.action_hack:
- openIceweasel(getString(R.string.hack_url), getApplicationContext());
+ openIceweasel(getString(R.string.hack_url), activityContext);
return true;
case R.id.action_source:
- openIceweasel("https://gitpull.it/source/libre-busto/", getApplicationContext());
+ openIceweasel("https://gitpull.it/source/libre-busto/", activityContext);
return true;
case R.id.action_licence:
- openIceweasel("https://www.gnu.org/licenses/gpl-3.0.html", getApplicationContext());
+ openIceweasel("https://www.gnu.org/licenses/gpl-3.0.html", activityContext);
return true;
default:
}
diff --git a/src/it/reyboz/bustorino/backend/utils.java b/src/it/reyboz/bustorino/backend/utils.java
--- a/src/it/reyboz/bustorino/backend/utils.java
+++ b/src/it/reyboz/bustorino/backend/utils.java
@@ -121,7 +121,10 @@
*/
public static void openIceweasel(String url, Context context) {
Intent browserIntent1 = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
- context.startActivity(browserIntent1);
+ if (browserIntent1.resolveActivity(context.getPackageManager()) != null) {
+ //check we have an activity ready to receive intents (otherwise, there will be a crash)
+ context.startActivity(browserIntent1);
+ }
}
/**
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Mar 31, 14:44 (19 h, 58 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1790351
Default Alt Text
D65.1774961083.diff (3 KB)
Attached To
Mode
D65: Do not use application context to avoid bug
Attached
Detach File
Event Timeline
Log In to Comment