Page MenuHomeGitPull.it
Differential D125

Update DataValueQuantity to work without a unit (for non-Wikidata Wikibases)
Needs ReviewPublic
Actions

Authored by lucamauri on Jul 3 2023, 10:51.

Details

Reviewers
valerio.bozzolan
Summary

Update SnakQuantity.php

Update StatementQuantity.php

Diff Detail

Repository
R21 boz-mw: MediaWiki API client
Branch
github-pr-lucamauri-lucamauri-UnitlessQuantity (branched from lucamauri-UnitlessQuantity)
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 434
Build 620: arc lint + arc unit

Event Timeline

valerio.bozzolan requested review of this revision.Jul 3 2023, 10:51
valerio.bozzolan created this revision.
Harbormaster completed remote builds in B433: Diff 401.Jul 3 2023, 10:52
valerio.bozzolan foisted this revision upon lucamauri.Jul 3 2023, 10:52
valerio.bozzolan added a reviewer: valerio.bozzolan.
valerio.bozzolan updated this revision to Diff 402.Jul 3 2023, 10:59

try to fix a substr() without a limit

Harbormaster completed remote builds in B434: Diff 402.Jul 3 2023, 11:00
valerio.bozzolan added a comment.Jul 3 2023, 11:04

Hi @lucamauri thanks again

  1. can you confirm that the comment inside DataValueQuantity still makes sense to you?
  1. can you also double-check this change? https://gitpull.it/D125?vs=401&id=402
  1. in particular, can you confirm that you like this change in order to obtain just the "Q" (one-length)?
-substr($wikidata_unit_id, 0)
+substr($wikidata_unit_id, 0, 1)

If yes, this is ready to land

valerio.bozzolan retitled this revision from Update DataValueQuantity.php to Update DataValueQuantity to work without a unit (for non-Wikidata Wikibases).Jul 3 2023, 11:06
valerio.bozzolan added a comment.Jul 3 2023, 11:11

Just a thing: it seems not possible, right now, to specify a custom unit URL like http://www.example.org/K123. Is that important to you now?

valerio.bozzolan added a task: T1215: Go to line info from the arrivals.Nov 17 2023, 16:41
valerio.bozzolan removed a task: T1215: Go to line info from the arrivals.

Revision Contents
Changeset List

PathSize
include/
wb/
17 lines
10 lines
5 lines

Diff 402

View Options

include/wb/DataValueQuantity.php

Loading...
View Options

include/wb/SnakQuantity.php

Loading...
View Options

include/wb/StatementQuantity.php

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register