Page MenuHomeGitPull.it

Update DataValueQuantity to work without a unit (for non-Wikidata Wikibases)
Needs ReviewPublic

Authored by lucamauri on Jul 3 2023, 10:51.

Details

Reviewers
valerio.bozzolan
Summary

Update SnakQuantity.php

Update StatementQuantity.php

Diff Detail

Repository
R21 boz-mw: MediaWiki API client
Branch
github-pr-lucamauri-lucamauri-UnitlessQuantity (branched from lucamauri-UnitlessQuantity)
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 434
Build 620: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.

try to fix a substr() without a limit

Hi @lucamauri thanks again

  1. can you confirm that the comment inside DataValueQuantity still makes sense to you?
  1. can you also double-check this change? https://gitpull.it/D125?vs=401&id=402
  1. in particular, can you confirm that you like this change in order to obtain just the "Q" (one-length)?
-substr($wikidata_unit_id, 0)
+substr($wikidata_unit_id, 0, 1)

If yes, this is ready to land

valerio.bozzolan retitled this revision from Update DataValueQuantity.php to Update DataValueQuantity to work without a unit (for non-Wikidata Wikibases).Jul 3 2023, 11:06

Just a thing: it seems not possible, right now, to specify a custom unit URL like http://www.example.org/K123. Is that important to you now?