Page MenuHomeGitPull.it
Differential D128

Fix bugs, use new viewmodel to load stops
ClosedPublic
Actions

Authored by fabio.mazza on Aug 26 2023, 19:45.

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
T1185: Fix crash caused by null pointer in ActivityPrincipal.java:618 on version 1.19.1-gitdev
Commits
R4:869510b7f7e1: Fix bugs, use new viewmodel to load stops
Summary

Fix T1185

Update the NearbyStopsFragment type, cleanup MQTT on disconnect.

Rename .java to .kt

Create ViewModel to load stops that are in the map bounding box.

Test Plan

Do stuff.

Diff Detail

Repository
R4 Libre BusTO
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Aug 26 2023, 19:45
Restricted Application added a project: Libre BusTO . · View Herald TranscriptAug 26 2023, 19:45
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.Aug 26 2023, 19:47

Be bop be bop. I'm a bot. Builded successfully ✨

D128-libre-busto.apk

sha256 8adc929b151ec20e83b8f4fd6d5263ef9d889a3ae19636f3ceceff112f2d868d  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk
Harbormaster completed remote builds in B438: Diff 406.Aug 26 2023, 19:47
fabio.mazza requested review of this revision.Aug 26 2023, 19:47
fabio.mazza updated this revision to Diff 407.Aug 26 2023, 19:50
  • Move readyGUIFor in OnResume
gitpull.android.builder added a comment.Aug 26 2023, 19:53

Be bop be bop. I'm a bot. Builded successfully ✨

D128-libre-busto.apk

sha256 6e5bf1eb76beae858b950150e36e8ce14449875fdfbefddd7cc744482547ceff  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk
Harbormaster completed remote builds in B439: Diff 407.Aug 26 2023, 19:53
valerio.bozzolan edited the summary of this revision. (Show Details)Aug 26 2023, 20:42
valerio.bozzolan edited the test plan for this revision. (Show Details)
valerio.bozzolan removed a subscriber: Libre BusTO .
valerio.bozzolan accepted this revision.Aug 26 2023, 23:54

Tested :) Yeah let's be ready for GUI

sgtm

This revision is now accepted and ready to land.Aug 26 2023, 23:54
Closed by commit R4:869510b7f7e1: Fix bugs, use new viewmodel to load stops. · Explain WhyAug 27 2023, 12:55
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:869510b7f7e1: Fix bugs, use new viewmodel to load stops.

Revision Contents
Changeset List

Diff 408

View Options

app/src/main/java/it/reyboz/bustorino/backend/mato/MQTTMatoClient.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/FragmentHelper.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/GTFSPositionsViewModel.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesFragment.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesGridShowingFragment.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesViewModel.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/MapFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/StopListFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/GTFSPositionsViewModel.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/LinesViewModel.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/MQTTPositionsViewModel.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/StopsMapViewModel.kt

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register