Page MenuHomeGitPull.it
Differential D147

Ask for permissions on first run, show longest patterns first
ClosedPublic
Actions

Authored by fabio.mazza on Jan 21 2024, 17:33.
Tags
Referenced Files
Unknown Object (File)
Wed, Apr 24, 05:17
Unknown Object (File)
Wed, Apr 24, 04:54
Unknown Object (File)
Mon, Apr 22, 03:51
Unknown Object (File)
Sat, Apr 20, 19:47
Unknown Object (File)
Fri, Apr 19, 05:37
Unknown Object (File)
Thu, Apr 18, 20:11
Unknown Object (File)
Thu, Apr 18, 12:50
Unknown Object (File)
Thu, Apr 18, 12:49
View All 44 Files
Subscribers
valerio.bozzolan
Libre BusTO

Details

Reviewers
valerio.bozzolan
Commits
R4:2366986b5cef: Ask for permissions on first run, show longest patterns first
Summary
  • Show patterns with more stops first in LinesDetailFragment
  • Set compatibility of Java
  • Manage permissions on first run, ask for notification
Test Plan
  • use old phone with Android <= 12: no nuclear implosions (notifications work)
  • use new phone with Android > 12 and completely ignore the "Give permissions": no nuclear implosions (notifications do not work)
  • use new phone with Android > 12 and manually run the Introduction (from menu) and give that permission: no nuclear implosions (notifications work)

Diff Detail

Repository
R4 Libre BusTO
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Jan 21 2024, 17:33
Restricted Application added a project: Libre BusTO . · View Herald TranscriptJan 21 2024, 17:33
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.Jan 21 2024, 17:36

Be bop be bop. I'm a bot. Builded successfully ✨

D147-libre-busto.apk

sha256 487761a3bc21cfa42ccb3b183b230f2448168ea37e85f2fe9ea24d0d4520bcec
Harbormaster completed remote builds in B497: Diff 465.Jan 21 2024, 17:36
fabio.mazza requested review of this revision.Jan 21 2024, 17:36
valerio.bozzolan accepted this revision.Jan 21 2024, 17:58
valerio.bozzolan edited the test plan for this revision. (Show Details)

I followed the test plan, no nuclear implosions, thanks big Fabione asd

sgtm

This revision is now accepted and ready to land.Jan 21 2024, 17:58
Closed by commit R4:2366986b5cef: Ask for permissions on first run, show longest patterns first. · Explain WhyJan 21 2024, 18:01
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:2366986b5cef: Ask for permissions on first run, show longest patterns first.

Revision Contents
Changeset List

PathSize
app/
7 lines
src/
main/
java/
it/
reyboz/
bustorino/
10 lines
1 line
fragments/
99 lines
9 lines
9 lines
11 lines
util/
25 lines
15 lines
res/
drawable/
5 lines
layout/
16 lines
values-it/
18 lines
values/
11 lines

Diff 466

View Options

app/build.gradle

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/ActivityIntro.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/IntroFragment.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/MapFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/util/Permissions.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/util/ViewUtils.kt

Loading...
View Options

app/src/main/res/drawable/megaphone.xml

Loading...
View Options

app/src/main/res/layout/fragment_intro.xml

Loading...
View Options

app/src/main/res/values-it/strings.xml

Loading...
View Options

app/src/main/res/values/strings.xml

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register