Differential D187

Show arrivals fragment when loading the arrival times
ClosedPublic
Actions

Authored by fabio.mazza on May 5 2025, 16:48.

Details

Reviewers

valerio.bozzolan

Commits

R4:5370279037e0: Show arrivals fragment when loading the arrival times

Summary

Avoid confusing the user!!

Implement Parcelable everywhere

Get the arrivals inside the view model

Show proper messages

Make loading bar larger

Diff Detail

Repository

R4 Libre BusTO

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fabio.mazza created this revision.May 5 2025, 16:48

Restricted Application added a project: Libre BusTO . · View Herald TranscriptMay 5 2025, 16:48

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript

Be bop be bop. I'm a bot. Builded successfully ✨

D187-libre-busto.apk

sha256 b00355d7c6a6aa70937d82158e5f0a9efec588134917e8c7e571469ec2cd03a8

Harbormaster completed remote builds in B679: Diff 568.May 5 2025, 16:52

fabio.mazza requested review of this revision.May 5 2025, 16:52

Works on my phone asd, lines, map, search by number, add to favorites, pull to refresh, settings, undo keys

sgtm

This revision is now accepted and ready to land.May 6 2025, 22:39

Closed by commit R4:5370279037e0: Show arrivals fragment when loading the arrival times. · Explain WhyMay 7 2025, 11:32

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:5370279037e0: Show arrivals fragment when loading the arrival times.

Revision Contents
Changeset List

Path

Size

app/

src/

main/

java/

it/

reyboz/

bustorino/

backend/

60 lines

49 lines

115 lines

71 lines

data/

FavoritesLiveData.java

5 lines

NextGenDB.java

85 lines

OldDataRepository.kt

4 lines

UserDB.java

7 lines

fragments/

ArrivalsFragment.java

ArrivalsFragment.kt

796 lines

MainScreenFragment.java

23 lines

ResultBaseFragment.java

2 lines

ScreenBaseFragment.java

5 lines

viewmodels/

ArrivalsViewModel.kt

184 lines

res/

layout/

fragment_arrivals.xml

23 lines

fragment_main_screen.xml

10 lines

values-it/

strings.xml

2 lines

values/

strings.xml

3 lines

Diff 577

View Options

app/src/main/java/it/reyboz/bustorino/backend/Palina.java

View Options

app/src/main/java/it/reyboz/bustorino/backend/Passaggio.java

View Options

app/src/main/java/it/reyboz/bustorino/backend/Route.java

View Options

app/src/main/java/it/reyboz/bustorino/backend/Stop.java

View Options

app/src/main/java/it/reyboz/bustorino/data/FavoritesLiveData.java

View Options

app/src/main/java/it/reyboz/bustorino/data/NextGenDB.java

View Options

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.kt

View Options

app/src/main/java/it/reyboz/bustorino/data/UserDB.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ResultBaseFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

View Options

app/src/main/res/layout/fragment_arrivals.xml

View Options

app/src/main/res/layout/fragment_main_screen.xml

View Options

app/src/main/res/values-it/strings.xml

View Options

app/src/main/res/values/strings.xml

Show arrivals fragment when loading the arrival timesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 577

app/src/main/java/it/reyboz/bustorino/backend/Palina.java

app/src/main/java/it/reyboz/bustorino/backend/Passaggio.java

app/src/main/java/it/reyboz/bustorino/backend/Route.java

app/src/main/java/it/reyboz/bustorino/backend/Stop.java

app/src/main/java/it/reyboz/bustorino/data/FavoritesLiveData.java

app/src/main/java/it/reyboz/bustorino/data/NextGenDB.java

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.kt

app/src/main/java/it/reyboz/bustorino/data/UserDB.java

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/ResultBaseFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

app/src/main/res/layout/fragment_arrivals.xml

app/src/main/res/layout/fragment_main_screen.xml

app/src/main/res/values-it/strings.xml

app/src/main/res/values/strings.xml

Show arrivals fragment when loading the arrival times
ClosedPublic
Actions

Revision Contents
Changeset List