Page MenuHomeGitPull.it

Improve 'add to favorites' method and layout
ClosedPublic

Authored by andrea.ugo on Mar 24 2020, 13:22.

Details

Summary

Inserted 'messageTextView' and 'addToFavorites' star button in a CardView (in fragment_list_view.xml). Changed the italian and english 'howDoesItWork' hint. Setted clickable messageTextView and addToFavorites star button.

Diff Detail

Repository
R4 Libre BusTO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

andrea.ugo created this revision.Mar 24 2020, 13:22
Restricted Application added a project: Libre BusTO . · View Herald TranscriptMar 24 2020, 13:22
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Be bop be bop. I'm a bot. Builded:

D19-libre-busto-unsigned.apk

Harbormaster completed remote builds in B54: Diff 75.Mar 24 2020, 13:23
andrea.ugo requested review of this revision.Mar 24 2020, 13:23

Be bop be bop. I'm a bot. Builded:

D19-libre-busto-unsigned.apk

Restricted Application added 1 blocking reviewer(s): valerio.bozzolan. · View Herald TranscriptMar 29 2020, 15:10

Be bop be bop. I'm a bot. Builded:

D19-libre-busto-unsigned.apk

Be bop be bop. I'm a bot. Builded:

D19-libre-busto-unsigned.apk

Be bop be bop. I'm a bot. Builded:

D19-libre-busto-unsigned.apk

Be bop be bop. I'm a bot. Builded:

D19-libre-busto-unsigned.apk

Amazing! Now it's very intuitive!

Just two more ideas:

  • what about adding a tooltip to the star icon? Something as "Add to Favorites" (I think it's not needed to toggle the phrase, it's just an hint for what it does)
  • then, what about removing the first hint phrase "tap the bus stop name... " etc.? It's so intuitive that this phrase is completely unuseful now, I think

Share with me your thoughts!

andrea.ugo updated this revision to Diff 76.Mar 31 2020, 17:11
This comment was removed by andrea.ugo.

Be bop be bop. I'm a bot. Builded:

D19-libre-busto-unsigned.apk

Harbormaster completed remote builds in B55: Diff 76.Mar 31 2020, 17:12
andrea.ugo updated this revision to Diff 77.Mar 31 2020, 17:18

Adjust the graphic aspect of the add to favorites

Be bop be bop. I'm a bot. Builded:

D19-libre-busto-unsigned.apk

Harbormaster completed remote builds in B56: Diff 77.Mar 31 2020, 17:19
valerio.bozzolan accepted this revision.Mar 31 2020, 18:08

It seems good to me.

This revision is now accepted and ready to land.Mar 31 2020, 18:08
This revision was automatically updated to reflect the committed changes.