Page MenuHomeGitPull.it

Improve 'add to favorites' method and layout
ClosedPublic

Authored by andrea.ugo on Mar 24 2020, 13:22.
Referenced Files
F1670536: D19.diff
Thu, Dec 8, 01:45
Unknown Object (File)
Tue, Dec 6, 06:23
F14125: busto_favorites.jpg
Mar 29 2020, 15:54
Subscribers
None

Details

Summary

Inserted 'messageTextView' and 'addToFavorites' star button in a CardView (in fragment_list_view.xml). Changed the italian and english 'howDoesItWork' hint. Setted clickable messageTextView and addToFavorites star button.

Diff Detail

Repository
R4 Libre BusTO
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added 1 blocking reviewer(s): valerio.bozzolan. · View Herald TranscriptMar 29 2020, 15:10

Amazing! Now it's very intuitive!

busto_favorites.jpg (1×640 px, 87 KB)

Just two more ideas:

  • what about adding a tooltip to the star icon? Something as "Add to Favorites" (I think it's not needed to toggle the phrase, it's just an hint for what it does)
  • then, what about removing the first hint phrase "tap the bus stop name... " etc.? It's so intuitive that this phrase is completely unuseful now, I think

Share with me your thoughts!

This comment was removed by andrea.ugo.

Adjust the graphic aspect of the add to favorites

This revision is now accepted and ready to land.Mar 31 2020, 18:08