Differential D19

Improve 'add to favorites' method and layout
ClosedPublic
Actions

Authored by andrea.ugo on Mar 24 2020, 13:22.

Details

Reviewers

valerio.bozzolan

Group Reviewers

Libre BusTO

Maniphest Tasks

T259: Update the startup tip

Commits

R4:130b1cd49ed7: Improve 'add to favorites' method and layout

Summary

Inserted 'messageTextView' and 'addToFavorites' star button in a CardView (in fragment_list_view.xml). Changed the italian and english 'howDoesItWork' hint. Setted clickable messageTextView and addToFavorites star button.

Diff Detail

Repository

R4 Libre BusTO

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 55
Build 77: BusTO Build Plan
Build 76: arc lint + arc unit

Event Timeline

andrea.ugo created this revision.Mar 24 2020, 13:22

Restricted Application added a project: Libre BusTO . · View Herald TranscriptMar 24 2020, 13:22

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Be bop be bop. I'm a bot. Builded:

→ D19-libre-busto-unsigned.apk

Harbormaster completed remote builds in B54: Diff 75.Mar 24 2020, 13:23

andrea.ugo requested review of this revision.Mar 24 2020, 13:23

andrea.ugo added a task: T259: Update the startup tip.Mar 24 2020, 13:25

valerio.bozzolan mentioned this in P5 Libre BusTO crash after D19.Mar 26 2020, 08:13

Be bop be bop. I'm a bot. Builded:

→ D19-libre-busto-unsigned.apk

Restricted Application added 1 blocking reviewer(s): valerio.bozzolan. · View Herald TranscriptMar 29 2020, 15:10

Be bop be bop. I'm a bot. Builded:

→ D19-libre-busto-unsigned.apk

Be bop be bop. I'm a bot. Builded:

→ D19-libre-busto-unsigned.apk

Be bop be bop. I'm a bot. Builded:

→ D19-libre-busto-unsigned.apk

Be bop be bop. I'm a bot. Builded:

→ D19-libre-busto-unsigned.apk

valerio.bozzolan mentioned this in T259: Update the startup tip.Mar 29 2020, 15:39

Amazing! Now it's very intuitive!

Just two more ideas:

what about adding a tooltip to the star icon? Something as "Add to Favorites" (I think it's not needed to toggle the phrase, it's just an hint for what it does)
then, what about removing the first hint phrase "tap the bus stop name... " etc.? It's so intuitive that this phrase is completely unuseful now, I think

Share with me your thoughts!

andrea.ugo updated this revision to Diff 76.Mar 31 2020, 17:11

This comment was removed by andrea.ugo.

Be bop be bop. I'm a bot. Builded:

→ D19-libre-busto-unsigned.apk

Harbormaster completed remote builds in B55: Diff 76.Mar 31 2020, 17:12

Adjust the graphic aspect of the add to favorites

Be bop be bop. I'm a bot. Builded:

→ D19-libre-busto-unsigned.apk

Harbormaster completed remote builds in B56: Diff 77.Mar 31 2020, 17:19

It seems good to me.

This revision is now accepted and ready to land.Mar 31 2020, 18:08