Cleanup ArrivalsFragment, make mListAdapter nullable
ClosedPublic
Actions

Authored by fabio.mazza on May 26 2025, 17:06.

Details

Reviewers

Maniphest Tasks

T1323: Fix Animator crash caused by NullPointerException from LinesDetailFragment.kt:1302 on version 2.4.1
T1312: Fix crash caused by lateinit property not initialized on version 2.4.0

Commits

R4:af4765784287: Cleanup ArrivalsFragment, make mListAdapter nullable

Summary

Fixes T1312

Also fixes T1323

Test Plan

Unclear test plan, but:

open the arrivals, put the app in background, reopen the app, still works
go in the favorites, open arrivals, still works
open the map, tap a stop, click on arrivals, it still works

Diff Detail

Repository

R4 Libre BusTO

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fabio.mazza created this revision.May 26 2025, 17:06

Restricted Application added a project: Libre BusTO . · View Herald TranscriptMay 26 2025, 17:06

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript

Be bop be bop. I'm a bot. Builded successfully ✨

D196-x86_64-signed.apk

sha256 9e457e390d09948229618451018453d0084dfdded5fdcafcd1d27cb6a1218199

Harbormaster completed remote builds in B714: Diff 600.May 26 2025, 17:10

fabio.mazza requested review of this revision.May 26 2025, 17:10

fabio.mazza edited the summary of this revision. (Show Details)May 26 2025, 17:17

fabio.mazza added a task: T1312: Fix crash caused by lateinit property not initialized on version 2.4.0.

Tried to add a test plan and followed it, still works on my machine loool

This revision is now accepted and ready to land.May 26 2025, 18:27

Fix animating position when bus is removed

This revision now requires review to proceed.Jul 15 2025, 17:51

Be bop be bop. I'm a bot. Builded successfully ✨

D196-x86_64-signed.apk

sha256 ff17506df7902576977d07a4f0b6508dc4e0301001befae44b8168513220815a

Harbormaster completed remote builds in B715: Diff 601.Jul 15 2025, 17:55

fabio.mazza edited the summary of this revision. (Show Details)Jul 15 2025, 18:02

fabio.mazza added a task: T1323: Fix Animator crash caused by NullPointerException from LinesDetailFragment.kt:1302 on version 2.4.1.

Also close the window when a bus is removed

Harbormaster completed remote builds in B716: Diff 602.Jul 15 2025, 18:53

Your test plan seems good lol

sgtm

This revision is now accepted and ready to land.Jul 15 2025, 19:21

Closed by commit R4:af4765784287: Cleanup ArrivalsFragment, make mListAdapter nullable. · Explain WhyJul 15 2025, 20:52

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:af4765784287: Cleanup ArrivalsFragment, make mListAdapter nullable.

Revision Contents
Changeset List

Path

Size

app/

src/

main/

java/

it/

reyboz/

bustorino/

ActivitySettings.java

2 lines

fragments/

ArrivalsFragment.kt

98 lines

LinesDetailFragment.kt

30 lines

Diff 603

View Options

app/src/main/java/it/reyboz/bustorino/ActivitySettings.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

Cleanup ArrivalsFragment, make mListAdapter nullableClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 603

app/src/main/java/it/reyboz/bustorino/ActivitySettings.java

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

Cleanup ArrivalsFragment, make mListAdapter nullable
ClosedPublic
Actions

Revision Contents
Changeset List