Differential D210

Fix bugs in the map
ClosedPublic
Actions

Authored by fabio.mazza on Nov 23 2025, 12:01.

Details

Reviewers

valerio.bozzolan

Maniphest Tasks

T1371: Fix crash caused by lateinit property mapView has not been initialized on version 2.4.5

Commits

R4:683040888978: Fix bugs in the map

Summary

Fix concurrent modification exception when cleaning old bus positions
Call map.onDestroy before it is actually destroyed (fix T1371)

Test Plan

Unknown.

Open map. See MQTT realtime positions.

App in background. Open 5 big different apps (e.g. Mindustry). Open app again. Still works.

Diff Detail

Repository

R4 Libre BusTO

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Nov 23 2025, 12:01

Restricted Application added a project: Libre BusTO . · View Herald TranscriptNov 23 2025, 12:01

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript

Harbormaster completed remote builds in B774: Diff 645.Nov 23 2025, 12:04

fabio.mazza requested review of this revision.Nov 23 2025, 12:04

valerio.bozzolan accepted this revision.Nov 23 2025, 13:44

This revision is now accepted and ready to land.Nov 23 2025, 13:44

valerio.bozzolan edited the test plan for this revision. (Show Details)Nov 23 2025, 13:45

Move some methods in GeneralMapLibreFragment, call mapLibre onDestroy before

This revision now requires review to proceed.Nov 23 2025, 18:32

fabio.mazza retitled this revision from Fix concurrentModificationException to Fix bugs in the map.Nov 23 2025, 18:34

fabio.mazza edited the summary of this revision. (Show Details)

fabio.mazza added a task: T1371: Fix crash caused by lateinit property mapView has not been initialized on version 2.4.5.

Harbormaster completed remote builds in B775: Diff 646.Nov 23 2025, 18:35

valerio.bozzolan accepted this revision.Nov 23 2025, 20:12

This revision is now accepted and ready to land.Nov 23 2025, 20:12

valerio.bozzolan edited the test plan for this revision. (Show Details)Nov 23 2025, 20:12

Closed by commit R4:683040888978: Fix bugs in the map. · Explain WhyNov 23 2025, 22:58

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:683040888978: Fix bugs in the map.

Revision Contents
Changeset List

Path

Size

app/

src/

main/

java/

it/

reyboz/

bustorino/

backend/

mato/

MQTTMatoClient.kt

13 lines

fragments/

GeneralMapLibreFragment.kt

14 lines

LinesDetailFragment.kt

11 lines

MapLibreFragment.kt

12 lines

Diff 647

View Options

app/src/main/java/it/reyboz/bustorino/backend/mato/MQTTMatoClient.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

Fix bugs in the mapClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 647

app/src/main/java/it/reyboz/bustorino/backend/mato/MQTTMatoClient.kt

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

Fix bugs in the map
ClosedPublic
Actions

Revision Contents
Changeset List