Paths

Table of Contentst

Rewrite GTT arrivals parser to use Volley
ClosedPublic
Actions

Authored by fabio.mazza on Mon, Apr 27, 13:56.

Project Tags

Referenced Files

	F13282441: D232.1777664991.diff
	Thu, Apr 30, 21:49

	F13282107: D232.1777646197.diff
	Thu, Apr 30, 16:36

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

Libre BusTO hackers

Maniphest Tasks

T1426: Rewrite download of GTT endpoint arrival times using Volley

Commits

R4:29fa39912fc1: Rewrite GTT arrivals parser to use Volley

Summary

Fix T1426

Test Plan

Check that the arrivals time work with GTT.

Diff Detail

Repository

R4 Libre BusTO

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Mon, Apr 27, 13:56

Restricted Application added a project: Libre BusTO. · View Herald TranscriptMon, Apr 27, 13:56

Restricted Application added a reviewer: Libre BusTO hackers. · View Herald Transcript

Restricted Application added a subscriber: valerio.bozzolan. · View Herald Transcript

Harbormaster completed remote builds in B841: Diff 711.Mon, Apr 27, 14:00

fabio.mazza requested review of this revision.Mon, Apr 27, 14:00

Harbormaster failed remote builds in B841: Diff 711!Tue, Apr 28, 11:11

gitpull.android.builder added a comment.Tue, Apr 28, 11:23

This comment was removed by valerio.bozzolan.

Harbormaster completed remote builds in B841: Diff 711.Tue, Apr 28, 11:23

gitpull.android.builder added a comment.Tue, Apr 28, 11:56

This comment was removed by valerio.bozzolan.

gitpull.android.builder added a comment.Tue, Apr 28, 12:12

This comment was removed by valerio.bozzolan.

I'm trying to share a logcat, since I'm crashing

Harbormaster failed remote builds in B841: Diff 711!Tue, Apr 28, 12:42

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D232-arm64-v8a-signed.apk
sha256 for arm64-v8a: 4f62c9744e4021c939d0e5a70eb8051ac766d6503beb5a10eac51aebbae8e7ea

APK for armeabi-v7a: D232-armeabi-v7a-signed.apk
sha256 for armeabi-v7a: 0130f968211a374a805c81e8c1183a25efb4753b534b016f466ad38c4cf98646

APK for universal: D232-universal-signed.apk
sha256 for universal: 21a39f0c524ddf2128ba6f54e91cea94bc3cb40731c2b918b35ba355e55a1aef

APK for x86: D232-x86-signed.apk
sha256 for x86: c77e55bb5bfa58d2e00c2c7a8087f8e1f868efaf6fc20ced2cf9f5b9c1006694

APK for x86_64: D232-x86_64-signed.apk
sha256 for x86_64: 442184ba4fcf171c8109edc7285bc86cf72b96c06f1cde6538491cfbc3adc8c3

Harbormaster completed remote builds in B841: Diff 711.Tue, Apr 28, 12:49

IT WORKS IN THIS EXACT MOMENT lol

This revision is now accepted and ready to land.Tue, Apr 28, 13:46

fabio.mazza edited the summary of this revision. (Show Details)Thu, Apr 30, 10:52

fabio.mazza added a task: T1426: Rewrite download of GTT endpoint arrival times using Volley.

Closed by commit R4:29fa39912fc1: Rewrite GTT arrivals parser to use Volley. · Explain WhyThu, Apr 30, 11:15

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:29fa39912fc1: Rewrite GTT arrivals parser to use Volley.

Revision Contents
Changeset List

Path

Size

app/

src/

main/

java/

it/

reyboz/

bustorino/

backend/

ArrivalsFetcherContext.java

lines

GTTJSONFetcher.java

lines

VolleyFetcherError.kt

lines

VolleyFetcherErrorResponder.kt

lines

mato/

MatoAPIFetcher.kt

lines

middleware/

AsyncArrivalsSearcher.java

lines

viewmodels/

ArrivalsViewModel.kt

lines

Diff 723

View Options

app/src/main/java/it/reyboz/bustorino/backend/ArrivalsFetcherContext.java

View Options

app/src/main/java/it/reyboz/bustorino/backend/GTTJSONFetcher.java

View Options

app/src/main/java/it/reyboz/bustorino/backend/VolleyFetcherError.kt

View Options

app/src/main/java/it/reyboz/bustorino/backend/VolleyFetcherErrorResponder.kt

View Options

app/src/main/java/it/reyboz/bustorino/backend/mato/MatoAPIFetcher.kt

View Options

app/src/main/java/it/reyboz/bustorino/middleware/AsyncArrivalsSearcher.java

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

Rewrite GTT arrivals parser to use VolleyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 723

app/src/main/java/it/reyboz/bustorino/backend/ArrivalsFetcherContext.java

app/src/main/java/it/reyboz/bustorino/backend/GTTJSONFetcher.java

app/src/main/java/it/reyboz/bustorino/backend/VolleyFetcherError.kt

app/src/main/java/it/reyboz/bustorino/backend/VolleyFetcherErrorResponder.kt

app/src/main/java/it/reyboz/bustorino/backend/mato/MatoAPIFetcher.kt

app/src/main/java/it/reyboz/bustorino/middleware/AsyncArrivalsSearcher.java

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

Rewrite GTT arrivals parser to use Volley
ClosedPublic
Actions

Revision Contents
Changeset List