Paths

Table of Contentst

Differential D235

Fix crash where DB becomes blocked, add test for Palina Parcelable
Needs ReviewPublic
Actions

Authored by fabio.mazza on Tue, May 5, 13:45.

Project Tags

Referenced Files

None

Subscribers

valerio.bozzolan

Details

Reviewers

None

Group Reviewers

Libre BusTO hackers

Summary

Review code for Databases, using the same Singleton pattern and never closing them manually. This fixes a crash due to database lockup.

Refactor NearbyStopsFragment to use ViewModel, fixing case with database update running

Show correct message in Nearby if there is not a position found yet switching to Arrivals

Add test for Parcelable implementation of Palina

Test Plan

On previous version, try deleting all application data and then reopening it. This should trigger the DB lockup.

Check that in this diff the problem is gone.

Diff Detail

Repository

R4 Libre BusTO

Branch

arcpatch-D235

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 857
Build 1246: BusTO Build Plan
Build 1245: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Tue, May 5, 13:45

Restricted Application added a project: Libre BusTO. · View Herald TranscriptTue, May 5, 13:45

Restricted Application added a reviewer: Libre BusTO hackers. · View Herald Transcript

Restricted Application added a subscriber: valerio.bozzolan. · View Herald Transcript

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D235-arm64-v8a-signed.apk
sha256: 9142abdc0a7a344f0b2ee047545faf4574641e3828395f01974bc15dec7271b6

APK for armeabi-v7a: D235-armeabi-v7a-signed.apk
sha256: 52b05e36653121fe84fcc2e251748593e512468793d497481a149f05842b5b29

APK for universal: D235-universal-signed.apk
sha256: 28f7b8231e0d9072f1f9eca284e6a33dd8e640cf5c2921cb497c6cf70215c3fe

APK for x86: D235-x86-signed.apk
sha256: fdca5d128ba580aa41ce998ecdb918f186655f1538e9d991637c542657003d3b

APK for x86_64: D235-x86_64-signed.apk
sha256: bab5a5dc1ba495b6289bea123f79760b15213c07c66b887ff587901720a5dc78

Harbormaster completed remote builds in B856: Diff 727.Tue, May 5, 13:50

fabio.mazza requested review of this revision.Tue, May 5, 13:50

Remove most database.close() instances, make UserDB also a Singleton
Fix double check
Refactor NearbyStopsFragment to use ViewModel, fixing no update problem
Show correct message if there is not a position found yet

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D235-arm64-v8a-signed.apk
sha256: 5bc88b2474f84673386dba3b0d2312609c0252bda8e12812e0d1e03ddfd2d302

APK for armeabi-v7a: D235-armeabi-v7a-signed.apk
sha256: 148f9eeb4f59abdad7cd8b998ff46946afad1a392ceb25f8beadfc7b6e337fd9

APK for universal: D235-universal-signed.apk
sha256: de6287d6b565a3d8aefe085a053eda7b3a765dbffbefd149681c4daf2038b3ec

APK for x86: D235-x86-signed.apk
sha256: 7e84b0fcf93c7719bcc0672d4fdaf81244c483daf18d7a69412c2150dadc516e

APK for x86_64: D235-x86_64-signed.apk
sha256: 2b313a3c1b1d1bae7de60de2f0283bb76687cb9f5ec1adbadf50e22e37fa5de9

Harbormaster completed remote builds in B857: Diff 728.Tue, May 5, 16:44

fabio.mazza retitled this revision from Avoid crash when DB is busy, add test for Palina Parcelable to Fix crash where DB becomes blocked, add test for Palina Parcelable.Tue, May 5, 16:46

fabio.mazza edited the summary of this revision. (Show Details)

fabio.mazza edited the test plan for this revision. (Show Details)

Revision Contents
Changeset List

Path

Size

app/

src/

androidTest/

java/

it/

reyboz/

bustorino/

data/

gtfs/

ParcelableTest.java

lines

main/

java/

it/

reyboz/

bustorino/

ActivityPrincipal.java

lines

backend/

Palina.java

lines

data/

AppDataProvider.java

lines

DBUpdateCheckWorker.kt

lines

lines

lines

lines

lines

fragments/

BackupImportFragment.kt

lines

FragmentHelper.java

lines

NearbyStopsFragment.java

lines

ResultListFragment.java

lines

middleware/

AsyncArrivalsSearcher.java

lines

AsyncStopFavoriteAction.java

lines

viewmodels/

NearbyStopsViewModel.kt

lines

Diff 728

View Options

app/src/androidTest/java/it/reyboz/bustorino/data/gtfs/ParcelableTest.java

View Options

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

View Options

app/src/main/java/it/reyboz/bustorino/backend/Palina.java

View Options

app/src/main/java/it/reyboz/bustorino/data/AppDataProvider.java

View Options

app/src/main/java/it/reyboz/bustorino/data/DBUpdateCheckWorker.kt

View Options

app/src/main/java/it/reyboz/bustorino/data/DatabaseUpdate.java

View Options

app/src/main/java/it/reyboz/bustorino/data/NextGenDB.java

View Options

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.kt

View Options

app/src/main/java/it/reyboz/bustorino/data/UserDB.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/BackupImportFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/FragmentHelper.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ResultListFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/middleware/AsyncArrivalsSearcher.java

View Options

app/src/main/java/it/reyboz/bustorino/middleware/AsyncStopFavoriteAction.java

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/NearbyStopsViewModel.kt

Fix crash where DB becomes blocked, add test for Palina ParcelableNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 728

app/src/androidTest/java/it/reyboz/bustorino/data/gtfs/ParcelableTest.java

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

app/src/main/java/it/reyboz/bustorino/backend/Palina.java

app/src/main/java/it/reyboz/bustorino/data/AppDataProvider.java

app/src/main/java/it/reyboz/bustorino/data/DBUpdateCheckWorker.kt

app/src/main/java/it/reyboz/bustorino/data/DatabaseUpdate.java

app/src/main/java/it/reyboz/bustorino/data/NextGenDB.java

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.kt

app/src/main/java/it/reyboz/bustorino/data/UserDB.java

app/src/main/java/it/reyboz/bustorino/fragments/BackupImportFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/FragmentHelper.java

app/src/main/java/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/ResultListFragment.java

app/src/main/java/it/reyboz/bustorino/middleware/AsyncArrivalsSearcher.java

app/src/main/java/it/reyboz/bustorino/middleware/AsyncStopFavoriteAction.java

app/src/main/java/it/reyboz/bustorino/viewmodels/NearbyStopsViewModel.kt

Fix crash where DB becomes blocked, add test for Palina Parcelable
Needs ReviewPublic
Actions

Revision Contents
Changeset List