Paths

Table of Contentst

Use new location engine on Nearby, consider case when GPS is disabled on device
ClosedPublic
Actions

Authored by fabio.mazza on Mon, May 11, 22:04.

Project Tags

Referenced Files

	F13306381: D238.1778747824.diff
	Wed, May 13, 10:37

	F13306176: D238.1778741519.diff
	Wed, May 13, 08:51

	F13305389: D238.1778725333.diff
	Wed, May 13, 04:22

	F13305028: D238.1778710522.diff
	Wed, May 13, 00:15

	F13304374: D238.1778682751.diff
	Tue, May 12, 16:32

	F13304292: D238.1778679528.diff
	Tue, May 12, 15:38

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

Libre BusTO hackers

Maniphest Tasks

T1435: [Bug] Opening the map before enabling GPS on device doesn't show position afterwards

Commits

R4:35366a951e01: Use new location engine on Nearby, consider case when GPS is disabled on device

Summary

Fix T1435

Disable Map Location if the GPS is disabled

Fix stupid icon bug

Diff Detail

Repository

R4 Libre BusTO

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Mon, May 11, 22:04

Restricted Application added a project: Libre BusTO. · View Herald TranscriptMon, May 11, 22:04

Restricted Application added a reviewer: Libre BusTO hackers. · View Herald Transcript

Restricted Application added a subscriber: valerio.bozzolan. · View Herald Transcript

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D238-arm64-v8a-signed.apk
sha256: 316fa83622d6afb4ff2722bfb454f59106c910c5e68766c9a7b9c77deff9c96d

APK for armeabi-v7a: D238-armeabi-v7a-signed.apk
sha256: 051a78168aee120a6165c5f93b555f2811900b23295d020a1ba40ebb80eab184

APK for universal: D238-universal-signed.apk
sha256: 862677d1c80a2ac432fb94fddbc22c55e12f89b6df371e91cf592e1158417195

APK for x86: D238-x86-signed.apk
sha256: 8db4f8e085a818352fd866a44782b32b92f006b760572ea7ea9611c02105cb06

APK for x86_64: D238-x86_64-signed.apk
sha256: 62f9643871176461e63c9a4577cdaa1441f01b18551ce531eb096665cfbfbcb2

Harbormaster completed remote builds in B872: Diff 743.Mon, May 11, 22:09

fabio.mazza requested review of this revision.Mon, May 11, 22:09

I was still able to crash the app by tapping "undo" multiple times but I do not care lol

This revision is now accepted and ready to land.Mon, May 11, 23:09

fabio.mazza edited the summary of this revision. (Show Details)Tue, May 12, 11:34

fabio.mazza added a task: T1435: [Bug] Opening the map before enabling GPS on device doesn't show position afterwards.

Closed by commit R4:35366a951e01: Use new location engine on Nearby, consider case when GPS is disabled on device. · Explain WhyTue, May 12, 11:35

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:35366a951e01: Use new location engine on Nearby, consider case when GPS is disabled on device.

Revision Contents
Changeset List

Path

Size

app/

src/

main/

java/

it/

reyboz/

bustorino/

fragments/

GeneralMapLibreFragment.kt

lines

LinesDetailFragment.kt

lines

MainScreenFragment.java

lines

MapLibreFragment.kt

lines

NearbyStopsFragment.java

lines

ScreenBaseFragment.java

lines

map/

MapLibreLocationEngine.kt

lines

middleware/

FusedNativeLocationProvider.kt

lines

viewmodels/

MapStateViewModel.kt

lines

res/

layout/

fragment_nearby_stops.xml

lines

values-fr/

strings.xml

lines

values-it/

strings.xml

lines

values-nl/

strings.xml

lines

values/

strings.xml

lines

Diff 744

View Options

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/map/MapLibreLocationEngine.kt

View Options

app/src/main/java/it/reyboz/bustorino/middleware/FusedNativeLocationProvider.kt

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/MapStateViewModel.kt

View Options

app/src/main/res/layout/fragment_nearby_stops.xml

View Options

app/src/main/res/values-fr/strings.xml

View Options

app/src/main/res/values-it/strings.xml

View Options

app/src/main/res/values-nl/strings.xml

View Options

app/src/main/res/values/strings.xml

Use new location engine on Nearby, consider case when GPS is disabled on deviceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 744

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

app/src/main/java/it/reyboz/bustorino/map/MapLibreLocationEngine.kt

app/src/main/java/it/reyboz/bustorino/middleware/FusedNativeLocationProvider.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/MapStateViewModel.kt

app/src/main/res/layout/fragment_nearby_stops.xml

app/src/main/res/values-fr/strings.xml

app/src/main/res/values-it/strings.xml

app/src/main/res/values-nl/strings.xml

app/src/main/res/values/strings.xml

Use new location engine on Nearby, consider case when GPS is disabled on device
ClosedPublic
Actions

Revision Contents
Changeset List