Paths

Table of Contentst

Restyle backup fragment, last fixes
ClosedPublic
Actions

Authored by fabio.mazza on Sat, May 16, 13:31.

Project Tags

Referenced Files

	F13340189: D241.1779316809.diff
	Wed, May 20, 00:40

	F13339556: D241.1779307100.diff
	Tue, May 19, 21:58

	F13338395: D241.1779295791.diff
	Tue, May 19, 18:49

	F13338199: D241.1779293777.diff
	Tue, May 19, 18:16

	F13337172: D241.1779284003.diff
	Tue, May 19, 15:33

	F13335652: D241.1779267422.diff
	Tue, May 19, 10:57

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

Libre BusTO hackers

Commits

R4:31e9e29cc1a0: Restyle backup fragment, last fixes

Summary

Disable location request when user disables it, avoid large number of queries to the DB

Do not recreate map fragment if there is one in the stack. Check before reshowing a fragment if it is already open

Fix crash when removing a stop from favorites

Diff Detail

Repository

R4 Libre BusTO

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Sat, May 16, 13:31

Restricted Application added a project: Libre BusTO. · View Herald TranscriptSat, May 16, 13:31

Restricted Application added a reviewer: Libre BusTO hackers. · View Herald Transcript

Restricted Application added a subscriber: valerio.bozzolan. · View Herald Transcript

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D241-arm64-v8a-signed.apk
sha256: 665a6ee896a27859f348b3022da2eae8b1cae56fb76f1083e2cc20e00852eb9e

APK for armeabi-v7a: D241-armeabi-v7a-signed.apk
sha256: 3b473028e0f4b0d5c9b2a25da8b9362d62341eac45bc16f83e2c09064eac50e3

APK for universal: D241-universal-signed.apk
sha256: 037388231894e0b69786229f199c0ed6aa951b6564b7e472d33de1ec3464a0e4

APK for x86: D241-x86-signed.apk
sha256: 79dfd75d9e282c058a767acf8de9dea3bc45c46f5bc39acb7fbcb12e3576f14a

APK for x86_64: D241-x86_64-signed.apk
sha256: 7667c9de9e080b15d541b1b15dfc290bc77c6cfd0889b1524726e4e97a8b29ce

Harbormaster completed remote builds in B889: Diff 756.Sat, May 16, 13:36

fabio.mazza requested review of this revision.Sat, May 16, 13:36

Fix crash when removing a stop from favorites

fabio.mazza edited the summary of this revision. (Show Details)Sat, May 16, 14:47

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D241-arm64-v8a-signed.apk
sha256: c91edb35a0fdccc9b859a04c8a44bc8c879360ddf2ca303e692620c18672d316

APK for armeabi-v7a: D241-armeabi-v7a-signed.apk
sha256: 037283ef66ffcc86aa3d834128605c70069b0aef4b9aa47af9b0a2202e9db68f

APK for universal: D241-universal-signed.apk
sha256: c25b29041f40d63794fc4b8f524d95ac7d5c6d0cd752c15907bae0bcb70db947

APK for x86: D241-x86-signed.apk
sha256: e7d02ffb397231c067fb851c2473b5cb8d978abf98e831e51f31f031d901b4f4

APK for x86_64: D241-x86_64-signed.apk
sha256: b8cd87b39643169eed5530a0f6aa222c0e6833d56586318bc6de5d9acbf2bcec

Harbormaster completed remote builds in B891: Diff 757.Sat, May 16, 14:51

Restyle backup fragment

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D241-arm64-v8a-signed.apk
sha256: d58996363dc79162ebbd05ae59d63573414067a71da8029b264a7f9623cd1753

APK for armeabi-v7a: D241-armeabi-v7a-signed.apk
sha256: 3013d713a4563432e58d2aaf059c9a93399f4a53ddb1c809323ced6ab47ad793

APK for universal: D241-universal-signed.apk
sha256: f3a2743e7d1df520d504f3e645c903868c0121d6cb033b420ee76bd2d0ece05e

APK for x86: D241-x86-signed.apk
sha256: d28b8e7457c77da93777f47890b34852af3e06728bf8ceb211046fc585e1c619

APK for x86_64: D241-x86_64-signed.apk
sha256: 0ea3d1d0a5f52ef1d4af9d4d7d5b393182f0c0ec4b74e9284e9ce37f6b4b150d

Harbormaster completed remote builds in B892: Diff 758.Sat, May 16, 15:42

fabio.mazza retitled this revision from Last fixes to Restyle backup fragment, last fixes.Sat, May 16, 15:52

Tested:

arrivals 1254
arrivals 40
search by name
map
lines
favorites
undo in map
background, type here, restore app

sgtm

This revision is now accepted and ready to land.Sat, May 16, 18:54

Closed by commit R4:31e9e29cc1a0: Restyle backup fragment, last fixes. · Explain WhySat, May 16, 19:57

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:31e9e29cc1a0: Restyle backup fragment, last fixes.

Revision Contents
Changeset List

Path

Size

app/

src/

main/

AndroidManifest.xml

lines

java/

it/

reyboz/

bustorino/

ActivityPrincipal.java

lines

backend/

utils.java

lines

fragments/

BackupImportFragment.kt

lines

GeneralMapLibreFragment.kt

lines

MapLibreFragment.kt

lines

map/

MapLibreLocationEngine.kt

lines

viewmodels/

ArrivalsViewModel.kt

lines

FavoritesViewModel.kt

lines

StopsMapViewModel.kt

lines

res/

layout/

fragment_backup.xml

lines

fragment_test_saving.xml

values-fr/

strings.xml

line

values-it/

strings.xml

lines

values-nl/

strings.xml

line

values/

strings.xml

lines

styles.xml

lines

theme.xml

lines

xml/

preferences.xml

lines

Diff 759

View Options

app/src/main/AndroidManifest.xml

View Options

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

View Options

app/src/main/java/it/reyboz/bustorino/backend/utils.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/BackupImportFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/map/MapLibreLocationEngine.kt

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/FavoritesViewModel.kt

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/StopsMapViewModel.kt

View Options

app/src/main/res/layout/fragment_backup.xml

View Options

app/src/main/res/layout/fragment_test_saving.xml

View Options

app/src/main/res/values-fr/strings.xml

View Options

app/src/main/res/values-it/strings.xml

View Options

app/src/main/res/values-nl/strings.xml

View Options

app/src/main/res/values/strings.xml

View Options

app/src/main/res/values/styles.xml

View Options

app/src/main/res/values/theme.xml

View Options

app/src/main/res/xml/preferences.xml

Restyle backup fragment, last fixesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 759

app/src/main/AndroidManifest.xml

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

app/src/main/java/it/reyboz/bustorino/backend/utils.java

app/src/main/java/it/reyboz/bustorino/fragments/BackupImportFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/map/MapLibreLocationEngine.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/FavoritesViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/StopsMapViewModel.kt

app/src/main/res/layout/fragment_backup.xml

app/src/main/res/layout/fragment_test_saving.xml

app/src/main/res/values-fr/strings.xml

app/src/main/res/values-it/strings.xml

app/src/main/res/values-nl/strings.xml

app/src/main/res/values/strings.xml

app/src/main/res/values/styles.xml

app/src/main/res/values/theme.xml

app/src/main/res/xml/preferences.xml

Restyle backup fragment, last fixes
ClosedPublic
Actions

Revision Contents
Changeset List