Paths

Table of Contentst

Fix bugs, improve map
Needs ReviewPublic
Actions

Authored by fabio.mazza on Mon, May 25, 13:09.

Project Tags

Referenced Files

	F13371167: D248.1779814325.diff
	Mon, May 25, 18:52

	F13371131: D248.1779813707.diff
	Mon, May 25, 18:41

	F13370938: D248.1779810613.diff
	Mon, May 25, 17:50

	F13370363: D248.1779803461.diff
	Mon, May 25, 15:51

	F13370178: D248.1779801333.diff
	Mon, May 25, 15:15

	F13370144: D248.1779800608.diff
	Mon, May 25, 15:03

	F13370142: D248.1779800604.diff
	Mon, May 25, 15:03

	F13370140: D248.1779800593.diff
	Mon, May 25, 15:03

View All 10 Files

Subscribers

valerio.bozzolan

Details

Reviewers

None

Group Reviewers

Libre BusTO hackers

Maniphest Tasks

T1443: Fix crash caused by Lateinit property not initialized on version 2.6.0

Summary

Lower batch size of trips to download
Add Iveco name
Filter better the trips, do not ask for null ones
Do not zoom on position if the bottom sheet is open

Fix T1443

Test Plan

Open the map and:

before location is updated, click on a stop or on a bus: the map should not zoom on the user position any more
pause the app, do something else
reopen the app and check that there are no explosions or weird stuff

Diff Detail

Repository

R4 Libre BusTO

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 931
Build 1375: BusTO Build Plan
Build 1374: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Mon, May 25, 13:09

Restricted Application added a project: Libre BusTO. · View Herald TranscriptMon, May 25, 13:09

Restricted Application added a reviewer: Libre BusTO hackers. · View Herald Transcript

Restricted Application added a subscriber: valerio.bozzolan. · View Herald Transcript

fabio.mazza edited the summary of this revision. (Show Details)Mon, May 25, 13:10

fabio.mazza added a task: T1443: Fix crash caused by Lateinit property not initialized on version 2.6.0.

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D248-arm64-v8a-signed.apk
sha256: 0a629ed2c8b2098f5ff4ee8e3bd2d61c7645fa835d9331b2c24e6a52a9381c0e

APK for armeabi-v7a: D248-armeabi-v7a-signed.apk
sha256: 32d30e5aa6497fbfe942c77806225d67dedbeda874983bbce4d9993ca03f5c3c

APK for universal: D248-universal-signed.apk
sha256: a6f65f0dcf9510e171456a1d1d9cf57b8e6121db19461c85992a1538aafe38d2

APK for x86: D248-x86-signed.apk
sha256: 98f9ce291142ace7c5d49bbec642eb528dae11850e4a243736e89af0dcb39922

APK for x86_64: D248-x86_64-signed.apk
sha256: 262671b78f6d8043b04452364e0e79a9fddcb1eef19c73c5e29a157b72eba77f

Harbormaster completed remote builds in B929: Diff 793.Mon, May 25, 13:15

fabio.mazza requested review of this revision.Mon, May 25, 13:15

Update icons on resume

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D248-arm64-v8a-signed.apk
sha256: c314cf0bceb083e314c44c663bd3fc9e24844633b44d340982c6430889418f48

APK for armeabi-v7a: D248-armeabi-v7a-signed.apk
sha256: f6c59452db353233533793f7551dda3d587c26fd01216c4fa30f77abf39f5c49

APK for universal: D248-universal-signed.apk
sha256: 0130e75e205d6d1e53ef0cd6a21fe5740583e4deafb38940f28937f73f0446cc

APK for x86: D248-x86-signed.apk
sha256: da0063dfa36c955599393c5fd6fb7f2a55a96de7f0f6c62090b13b7bb2a16d3e

APK for x86_64: D248-x86_64-signed.apk
sha256: c9da6fe719aef84f087d5b07ae8fd0e200f0435e768394e66043b53659c5cdf9

Harbormaster completed remote builds in B930: Diff 794.Mon, May 25, 13:21

Do not zoom on position if the bottom sheet is open

fabio.mazza edited the summary of this revision. (Show Details)Mon, May 25, 13:38

fabio.mazza edited the test plan for this revision. (Show Details)

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D248-arm64-v8a-signed.apk
sha256: 375d3fe19043ab7ddbab41cf2c5bbbe893b7f0ae99b855d5b207920fed4c51dc

APK for armeabi-v7a: D248-armeabi-v7a-signed.apk
sha256: 651edff998457ee0669b5c653148e87a1d9a4350c343d9e59631174722c7a022

APK for universal: D248-universal-signed.apk
sha256: 13a755d7902479ab92848c4406a34205d8f2f6302278099c47d90dfebb558cfb

APK for x86: D248-x86-signed.apk
sha256: 8e52d48cfb88436d5c400762a0beae5da6450bf4b29061ac2188f674bcc83fd6

APK for x86_64: D248-x86_64-signed.apk
sha256: ae8e6c1a8c0598369906498d15b23ce991ba5efeaba85702a8f96ab866873051

Harbormaster completed remote builds in B931: Diff 795.Mon, May 25, 13:40

Revision Contents
Changeset List

Path

Size

app/

src/

main/

java/

it/

reyboz/

bustorino/

backend/

VehicleUtils.kt

lines

data/

MatoTripsDownloadWorker.kt

lines

fragments/

GeneralMapLibreFragment.kt

lines

LinesDetailFragment.kt

lines

MapLibreFragment.kt

lines

viewmodels/

LivePositionsViewModel.kt

lines

Diff 795

View Options

app/src/main/java/it/reyboz/bustorino/backend/VehicleUtils.kt

View Options

app/src/main/java/it/reyboz/bustorino/data/MatoTripsDownloadWorker.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/LivePositionsViewModel.kt

Fix bugs, improve mapNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 795

app/src/main/java/it/reyboz/bustorino/backend/VehicleUtils.kt

app/src/main/java/it/reyboz/bustorino/data/MatoTripsDownloadWorker.kt

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/LivePositionsViewModel.kt

Fix bugs, improve map
Needs ReviewPublic
Actions

Revision Contents
Changeset List