Page MenuHomeGitPull.it

Misc improvements, fixes, new activities
AbandonedPublic

Authored by fabio.mazza on Sat, Apr 17, 16:09.

Details

Summary

Show different name for the debug build

Use ACRA only on not debug build

Play around with the adapter to try new stuff

Reuse old mechanism for arrivals nearby

Move classes to more apt package Also fix some minor errors

Use the support Toolbar instead of the normal ActionBar

Remove layout v11 since we support v14 up

Make substitute of main activity with sandwich menu

Make drawer close on back press

Add missing resource file

Add icons to the nav bar

Play around with FragmentHelper

Add new unuseful fragment

Try fixing small error in displaying/querying the arrivals source

Move more code from MainActivity to Main fragment

Cleanup code for build

Update GTT JSON Fetcher with HTTPS so that it works again (this is a FIX)

Move code for the star from Activity to ArrivalsFragment

Add some code for the Realtime updates

Cleanup code after moving the star check to the fragment

Test Plan

Build, Run and check nothing is broken

Diff Detail

Repository
R4 Libre BusTO
Branch
arcpatch-D50_1
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 215
Build 281: BusTO Build Plan
Build 280: arc lint + arc unit

Event Timeline

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Apr 17, 16:09
Harbormaster failed remote builds in B212: Diff 173!
Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Apr 17, 19:01
Harbormaster failed remote builds in B213: Diff 174!

Talking with @fabio.mazza we discussed about the "Experiments" menu entry. It could be enabled tapping "Enable experimental stuff" from the Settings page:

image.png (277×363 px, 22 KB)

asd

This revision now requires changes to proceed.Sat, Apr 17, 19:41
  • Make the experiments available with the option in the settings
valerio.bozzolan added inline comments.
src/it/reyboz/bustorino/backend/GTTJSONFetcher.java
49

asd

src/it/reyboz/bustorino/fragments/SettingsFragment.java
31

asd

This revision is now accepted and ready to land.Sun, Apr 18, 10:34

This is really approved and merged but was probably not created with arc diff so it's not marked as merged now.