Page MenuHomeGitPull.it
Differential D92

Get stop by QR Code again!
ClosedPublic
Actions

Authored by fabio.mazza on Sep 25 2022, 00:28.

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
T1078: Scanning QR Code at bus stop doesn't work
Commits
R4:bbd4ff84bbf9: Get stop by QR Code again!
Summary

Enable to get stops from QR Codes, either from external scan via intent, or by scanning from within the app.

Check that most apps give back a good result, as the substituted code doesn't apply the restriction of using only Barcode Scanner

Fixes T1078

(PS) There is also a new Experiments section, not fully working yet!

Diff Detail

Repository
R4 Libre BusTO
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Sep 25 2022, 00:28
Restricted Application added a project: Libre BusTO . · View Herald TranscriptSep 25 2022, 00:28
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
fabio.mazza edited the summary of this revision. (Show Details)Sep 25 2022, 00:30
gitpull.android.builder added a comment.Sep 25 2022, 00:31

Be bop be bop. I'm a bot. Builded:

→ D92-libre-busto-unsigned.apk

Harbormaster completed remote builds in B343: Diff 316.Sep 25 2022, 00:31
fabio.mazza requested review of this revision.Sep 25 2022, 00:31
fabio.mazza edited the summary of this revision. (Show Details)Sep 25 2022, 10:12
fabio.mazza added a task: T1078: Scanning QR Code at bus stop doesn't work.
valerio.bozzolan accepted this revision.Sep 26 2022, 09:13

I tested both the Barcode Scanner "installer" and the scan itself and both work very well. Thank you so much Fabione. +1

sgtm

This revision is now accepted and ready to land.Sep 26 2022, 09:13
Closed by commit R4:bbd4ff84bbf9: Get stop by QR Code again!. · Explain WhySep 26 2022, 16:05
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:bbd4ff84bbf9: Get stop by QR Code again!.

Revision Contents
Changeset List

PathSize
5 lines
res/
layout/
35 lines
10 lines
83 lines
values-it/
6 lines
values/
7 lines
src/
com/
google/
zxing/
integration/
android/
1 line
it/
reyboz/
bustorino/
131 lines
51 lines
backend/
gtfs/
2 lines
fragments/
154 lines
1 line
5 lines
93 lines
5 lines
middleware/
33 lines
172 lines
62 lines
17 lines

Diff 317

View Options

build.gradle

Loading...
View Options

res/layout/activity_experiments.xml

Loading...
View Options

res/layout/activity_map.xml

Loading...
View Options

res/layout/fragment_lines_detail.xml

Loading...
View Options

res/values-it/strings.xml

Loading...
View Options

res/values/strings.xml

Loading...
View Options

src/com/google/zxing/integration/android/IntentIntegrator.java

Loading...
View Options

src/it/reyboz/bustorino/ActivityExperiments.java

Loading...
View Options

src/it/reyboz/bustorino/ActivityPrincipal.java

Loading...
View Options

src/it/reyboz/bustorino/backend/gtfs/PolylineParser.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

Loading...
View Options

src/it/reyboz/bustorino/fragments/LinesFragment.kt

Loading...
View Options

src/it/reyboz/bustorino/fragments/LinesViewModel.kt

Loading...
View Options

src/it/reyboz/bustorino/fragments/MainScreenFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/MapFragment.java

Loading...
View Options

src/it/reyboz/bustorino/middleware/BarcodeScanContract.java

Loading...
View Options

src/it/reyboz/bustorino/middleware/BarcodeScanOptions.java

Loading...
View Options

src/it/reyboz/bustorino/middleware/BarcodeScanUtils.java

Loading...
View Options

src/it/reyboz/bustorino/middleware/GeneralActivity.java

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register