Page MenuHomeGitPull.it
Differential D93

Avoid showing nulls in location string and add Telegram button
ClosedPublic
Actions

Authored by fabio.mazza on Sep 27 2022, 00:19.
Tags
Referenced Files
F2107152: D93.id318.diff
Thu, Apr 25, 14:11
F2106897: D93.id319.diff
Thu, Apr 25, 10:55
Unknown Object (File)
Mon, Apr 22, 04:09
Unknown Object (File)
Sat, Apr 20, 03:01
Unknown Object (File)
Thu, Apr 18, 13:18
Unknown Object (File)
Thu, Apr 18, 13:18
Unknown Object (File)
Thu, Apr 18, 13:18
Unknown Object (File)
Thu, Apr 18, 13:18
View All Files
Subscribers
valerio.bozzolan
Libre BusTO

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
T1087: Avoid showing "null" location strings
Commits
R4:bddd139f9856: Avoid showing nulls in location string and add Telegram button
Summary

Fix problem showed by Marco

Fixes T1087

Solves T1082

Diff Detail

Repository
R4 Libre BusTO
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Sep 27 2022, 00:19
Restricted Application added a project: Libre BusTO . · View Herald TranscriptSep 27 2022, 00:19
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.Sep 27 2022, 00:22

Be bop be bop. I'm a bot. Builded:

→ D93-libre-busto-unsigned.apk

Harbormaster completed remote builds in B345: Diff 318.Sep 27 2022, 00:22
fabio.mazza requested review of this revision.Sep 27 2022, 00:22
fabio.mazza updated this revision to Diff 319.Sep 27 2022, 01:16
  • Add button to telegram channel
fabio.mazza retitled this revision from Avoid showing nulls in location string to Avoid showing nulls in location string and add Telegram button.Sep 27 2022, 01:17
fabio.mazza edited the summary of this revision. (Show Details)
gitpull.android.builder added a comment.Sep 27 2022, 01:18

Be bop be bop. I'm a bot. Builded:

→ D93-libre-busto-unsigned.apk

Harbormaster completed remote builds in B346: Diff 319.Sep 27 2022, 01:18
valerio.bozzolan accepted this revision.Sep 27 2022, 08:01

Tested successfully. The "null" thing is fixed and the Telegram icon is awesome, thank you big Fabione

sgtm

This revision is now accepted and ready to land.Sep 27 2022, 08:01
Closed by commit R4:bddd139f9856: Avoid showing nulls in location string and add Telegram button. · Explain WhySep 27 2022, 12:18
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:bddd139f9856: Avoid showing nulls in location string and add Telegram button.

Revision Contents
Changeset List

PathSize
res/
drawable/
30 lines
28 lines
layout/
15 lines
5 lines
values-it/
4 lines
values/
5 lines
4 lines
src/
it/
reyboz/
bustorino/
23 lines
adapters/
3 lines

Diff 320

View Options

res/drawable/telegram_logo.xml

Loading...
View Options

res/drawable/telegram_logo_50.xml

Loading...
View Options

res/layout/activity_about.xml

Loading...
View Options

res/layout/stop_line_element.xml

Loading...
View Options

res/values-it/strings.xml

Loading...
View Options

res/values/strings.xml

Loading...
View Options

res/values/styles.xml

Loading...
View Options

src/it/reyboz/bustorino/ActivityAbout.java

Loading...
View Options

src/it/reyboz/bustorino/adapters/StopRecyclerAdapter.java

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register