Page MenuHomeGitPull.it
Differential D99

Show lines stopping in the map, bugfixing
ClosedPublic
Actions

Authored by fabio.mazza on Feb 4 2023, 19:37.
Tags
Referenced Files
Unknown Object (File)
Mon, Apr 22, 04:09
Unknown Object (File)
Thu, Apr 18, 13:21
Unknown Object (File)
Thu, Apr 18, 13:21
Unknown Object (File)
Thu, Apr 18, 13:20
Unknown Object (File)
Thu, Apr 18, 13:20
Unknown Object (File)
Sun, Apr 14, 06:35
Unknown Object (File)
Sun, Apr 14, 05:45
Unknown Object (File)
Sat, Apr 13, 05:22
View All Files
Subscribers
valerio.bozzolan
Libre BusTO

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
T1140: Feature request - Bus list in maps pop-up
T1146: Fix crash caused by NullPointerException on org.osmdroid.views.MapView.getMapCenter() (MapFragment.java:290) on version 1.18.3
T1142: Fix crash caused by NullPointerException in MapFragment.java:134 on version 1.18.2
Commits
R4:9f75b4ebbe70: Show lines stopping in the map, bugfixing
Summary

Download GTFS realtime position updates

Fix NullPointerException, T1142

Fix NullPointerException of the map, T1146

First solution for T1140: showing the lines on the map

Show lines stopping in the bus stop on the map

Diff Detail

Repository
R4 Libre BusTO
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Feb 4 2023, 19:37
Restricted Application added a project: Libre BusTO . · View Herald TranscriptFeb 4 2023, 19:37
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.Feb 4 2023, 19:41

Be bop be bop. I'm a bot. Builded:

→ D99-libre-busto-unsigned.apk

Harbormaster completed remote builds in B366: Diff 336.Feb 4 2023, 19:41
fabio.mazza requested review of this revision.Feb 4 2023, 19:41
fabio.mazza updated this revision to Diff 337.Feb 4 2023, 21:59
  • Show lines stopping in the bus stop on the map
fabio.mazza edited the summary of this revision. (Show Details)Feb 4 2023, 22:01
fabio.mazza edited the summary of this revision. (Show Details)
gitpull.android.builder added a comment.Feb 4 2023, 22:01

Be bop be bop. I'm a bot. Builded:

→ D99-libre-busto-unsigned.apk

Harbormaster completed remote builds in B367: Diff 337.Feb 4 2023, 22:01
fabio.mazza retitled this revision from Bugfixing to Show lines stopping in the map, bugfixing.Feb 4 2023, 22:02
valerio.bozzolan accepted this revision.Feb 4 2023, 22:32

sgtm

At the moment I'm not geolocalized in Torino so sorry if I can just test on an empty map, but it works.

Thank you big Fabio, ready to land

This revision is now accepted and ready to land.Feb 4 2023, 22:32
fabio.mazza mentioned this in T1140: Feature request - Bus list in maps pop-up.Feb 5 2023, 13:37
Closed by commit R4:9f75b4ebbe70: Show lines stopping in the map, bugfixing. · Explain WhyFeb 5 2023, 15:11
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:9f75b4ebbe70: Show lines stopping in the map, bugfixing.
valerio.bozzolan added tasks: T1142: Fix crash caused by NullPointerException in MapFragment.java:134 on version 1.18.2, T1146: Fix crash caused by NullPointerException on org.osmdroid.views.MapView.getMapCenter() (MapFragment.java:290) on version 1.18.3, T1140: Feature request - Bus list in maps pop-up.Feb 5 2023, 22:24
valerio.bozzolan mentioned this in R4:ff78fa53446d: Release F-Droid version 1.18.4.Feb 6 2023, 22:24

Revision Contents
Changeset List

PathSize
res/
layout/
10 lines
27 lines
23 lines
values/
10 lines
src/
it/
reyboz/
bustorino/
13 lines
backend/
gtfs/
43 lines
fragments/
28 lines
60 lines
90 lines
map/
21 lines

Diff 338

View Options

res/layout/activity_experiments.xml

Loading...
View Options

res/layout/fragment_test_realtime_gtfs.xml

Loading...
View Options

res/layout/map_popup.xml

Loading...
View Options

res/values/strings.xml

Loading...
View Options

src/it/reyboz/bustorino/ActivityExperiments.java

Loading...
View Options

src/it/reyboz/bustorino/backend/gtfs/GtfsRealtimeRequest.kt

Loading...
View Options

src/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

Loading...
View Options

src/it/reyboz/bustorino/fragments/MapFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/TestRealtimeGtfsFragment.kt

Loading...
View Options

src/it/reyboz/bustorino/map/CustomInfoWindow.java

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register