Paths

Table of Contentst

Diffusion Libre BusTO ab06076a77c5

Fix many bugs in map, favorites and snackbar, revise and modernize DB
Auditedab06076a77c5
Actions

Project Tags

None

Referenced Files

None

Subscribers

None

Description

Fix many bugs in map, favorites and snackbar, revise and modernize DB

Summary:

Fix location handle not released

Fix snackbar text color

Rewrite many parts of the database to produce LiveData directly

Close the app after back press

Fix T1439

Fix T1434

Fix T1437

Reviewers: Libre BusTO hackers, valerio.bozzolan

Reviewed By: Libre BusTO hackers, valerio.bozzolan

Subscribers: rosto, valerio.bozzolan

Project Tags: Libre BusTO

Maniphest Tasks: T1439, T1434, T1437

Differential Revision: https://gitpull.it/D239

Details

Auditors

gitpull.android.builder

Provenance

fabio.mazza	Authored on Thu, May 14, 12:18
fabio.mazza	Pushed on Thu, May 14, 12:35

Reviewer

Libre BusTO hackers

Differential Revision

D239: Fix many bugs in map, favorites and snackbar, revise and modernize DB

Parents

R4:35366a951e01: Use new location engine on Nearby, consider case when GPS is disabled on device

Branches

Unknown

Tags

Unknown

Tasks

T1439: Fix backup not working
T1434: Fix illegible SnackBar on the MainScreenFragment
T1437: Fix no favorites when DB is updating

Build Status

Buildable 881
Build 1290: BusTO Build Plan

Event Timeline

fabio.mazza committed R4:ab06076a77c5: Fix many bugs in map, favorites and snackbar, revise and modernize DB (authored by fabio.mazza).Thu, May 14, 12:35

fabio.mazza added tasks: T1437: Fix no favorites when DB is updating, T1434: Fix illegible SnackBar on the MainScreenFragment, T1439: Fix backup not working.

fabio.mazza added a revision: D239: Fix many bugs in map, favorites and snackbar, revise and modernize DB.

Bip bop I'm a bot. Here fresh Android builds:

APK for arm64-v8a: ab06076-arm64-v8a-signed.apk
sha256: 87e25026d2356ed3cc4c9f4b9c66cd8ef7d7253427fd1c3bac263ecc5c56771e

APK for armeabi-v7a: ab06076-armeabi-v7a-signed.apk
sha256: 28c724f2647689622c1e0e00bc58441a1e999b149dc8da8dbc2aa149222c6a92

APK for universal: ab06076-universal-signed.apk
sha256: 0d707de0159b108f6c4085853c52711a50bfe6d353584eb3cd1c4eb48c82ea18

APK for x86: ab06076-x86-signed.apk
sha256: ca87597ad9a226b61bb8da2526b2fb52338d3a1574e216f4bfca44c7aecc0db0

APK for x86_64: ab06076-x86_64-signed.apk
sha256: ce0f5894c83392fe80b7a4dd46e940064ec19c8271fea0b32b75c7209c6fd165

All concerns with this commit have now been addressed.Thu, May 14, 12:41

Harbormaster completed building B881: R4:ab06076a77c5: Fix many bugs in map, favorites and snackbar, revise and modernize DB.Thu, May 14, 12:41

Changes (34)

Path

Size

app/

src/

main/

java/

it/

reyboz/

bustorino/

ActivityPrincipal.java

backend/

data/

FavoritesLiveData.java

FavoritesViewModel.java

InvalidationTracker.kt

fragments/

BackupImportFragment.kt

FavoritesFragment.java

GeneralMapLibreFragment.kt

LinesDetailFragment.kt

MainScreenFragment.java

MapLibreFragment.kt

NearbyStopsFragment.java

ResultListFragment.java

ScreenBaseFragment.java

middleware/

AppLocationManager.kt

AsyncArrivalsSearcher.java

AsyncStopFavoriteAction.java

CoroutineFavoriteAction.kt

viewmodels/

ArrivalsViewModel.kt

FavoritesViewModel.kt

LinesViewModel.kt

StopsMapViewModel.kt

res/

layout/

fragment_main_screen.xml

fragment_nearby_stops.xml

values/

strings.xml

R4:ab06076a77c5

View Options

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

View Options

app/src/main/java/it/reyboz/bustorino/backend/Result.java

View Options

app/src/main/java/it/reyboz/bustorino/backend/StopFavoritesData.kt

View Options

app/src/main/java/it/reyboz/bustorino/data/AppDataProvider.java

View Options

app/src/main/java/it/reyboz/bustorino/data/DBUpdateWorker.kt

View Options

app/src/main/java/it/reyboz/bustorino/data/DatabaseUpdate.java

View Options

app/src/main/java/it/reyboz/bustorino/data/FavoritesLiveData.java

View Options

app/src/main/java/it/reyboz/bustorino/data/FavoritesViewModel.java

View Options

app/src/main/java/it/reyboz/bustorino/data/InvalidationTracker.kt

View Options

app/src/main/java/it/reyboz/bustorino/data/NextGenDB.java

View Options

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.kt

View Options

app/src/main/java/it/reyboz/bustorino/data/QueryLiveData.kt

View Options

app/src/main/java/it/reyboz/bustorino/data/UserDB.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/BackupImportFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/FavoritesFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ResultListFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/middleware/AppLocationManager.kt

View Options

app/src/main/java/it/reyboz/bustorino/middleware/AsyncArrivalsSearcher.java

View Options

app/src/main/java/it/reyboz/bustorino/middleware/AsyncStopFavoriteAction.java

View Options

app/src/main/java/it/reyboz/bustorino/middleware/CoroutineFavoriteAction.kt

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/FavoritesViewModel.kt

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/LinesViewModel.kt

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/StopsMapViewModel.kt

View Options

app/src/main/res/layout/fragment_main_screen.xml

View Options

app/src/main/res/layout/fragment_nearby_stops.xml

View Options

app/src/main/res/values/strings.xml

Fix many bugs in map, favorites and snackbar, revise and modernize DBAuditedab06076a77c5Actions

Description

Details

Event Timeline

Changes (34)

R4:ab06076a77c5

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

app/src/main/java/it/reyboz/bustorino/backend/Result.java

app/src/main/java/it/reyboz/bustorino/backend/StopFavoritesData.kt

app/src/main/java/it/reyboz/bustorino/data/AppDataProvider.java

app/src/main/java/it/reyboz/bustorino/data/DBUpdateWorker.kt

app/src/main/java/it/reyboz/bustorino/data/DatabaseUpdate.java

app/src/main/java/it/reyboz/bustorino/data/FavoritesLiveData.java

app/src/main/java/it/reyboz/bustorino/data/FavoritesViewModel.java

app/src/main/java/it/reyboz/bustorino/data/InvalidationTracker.kt

app/src/main/java/it/reyboz/bustorino/data/NextGenDB.java

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.kt

app/src/main/java/it/reyboz/bustorino/data/QueryLiveData.kt

app/src/main/java/it/reyboz/bustorino/data/UserDB.java

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/BackupImportFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/FavoritesFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/ResultListFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

app/src/main/java/it/reyboz/bustorino/middleware/AppLocationManager.kt

app/src/main/java/it/reyboz/bustorino/middleware/AsyncArrivalsSearcher.java

app/src/main/java/it/reyboz/bustorino/middleware/AsyncStopFavoriteAction.java

app/src/main/java/it/reyboz/bustorino/middleware/CoroutineFavoriteAction.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/FavoritesViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/LinesViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/StopsMapViewModel.kt

app/src/main/res/layout/fragment_main_screen.xml

app/src/main/res/layout/fragment_nearby_stops.xml

app/src/main/res/values/strings.xml

Fix many bugs in map, favorites and snackbar, revise and modernize DB
Auditedab06076a77c5
Actions