Page MenuHomeGitPull.it
Create Task
Maniphest T889

Revoking location permission at system setting crashes app on version 1.14
Closed, ResolvedPublic
Actions

Description

Hi, there, I've found an issue in version 1.14, which is downloaded from F-Droid.

Reproduce

  1. enter the app from the home screen and allow the location permission request.
  2. go to system setting and revoke the location permission
  3. go back to the app and it crashes

Here the info:

version code:
31

version name:
1.14

android version:
10

phone:
MIX 2S

brand:
Xiaomi

stack:
java.lang.SecurityException: "gps" location provider requires ACCESS_FINE_LOCATION permission.
	at android.os.Parcel.createException(Parcel.java:2074)
	at android.os.Parcel.readException(Parcel.java:2042)
	at android.os.Parcel.readException(Parcel.java:1990)
	at android.location.ILocationManager$Stub$Proxy.requestLocationUpdates(ILocationManager.java:1151)
	at android.location.LocationManager.requestLocationUpdates(LocationManager.java:1033)
	at android.location.LocationManager.requestLocationUpdates(LocationManager.java:561)
	at it.reyboz.bustorino.ActivityMain$NearbyStopsRequester.run(ActivityMain.java:664)
	at android.os.Handler.handleCallback(Handler.java:883)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:224)
	at android.app.ActivityThread.main(ActivityThread.java:7562)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:539)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:950)

Here is the video about how I found this crash.

Could you help me review this issue? very thanks !!

Revisions and Commits

R4 Libre BusTO
ClosedD56 Add map fragment and fix stuff

Related Objects

Event Timeline

wowhhh created this task.Jul 5 2021, 14:20
valerio.bozzolan subscribed.EditedJul 5 2021, 16:40

Hi @wowhhh can you please share the crash report instead of this video? You can do it pressing "Yes" on our message dialog.

Thank you so much :)

wowhhh added a comment.Jul 6 2021, 04:42

Hello！
I exported the crash report and pasted it below!
Thank you for your reply！

1.14_report.json21 KBDownload

valerio.bozzolan updated the task description. (Show Details)Jul 6 2021, 09:08

Thank you I've edited the description with the info extracted from your JSON using

P15 Libre BusTO Android Crash Analyzer
1<?php
2# Android Crash Dump exporter for Phabricator
3# Copyright (C) 2021-2024 Valerio Bozzolan, crash report contributors
4#
5# This program is free software: you can redistribute it and/or modify
6# it under the terms of the GNU Affero General Public License as published by
7# the Free Software Foundation, either version 3 of the License, or
8# (at your option) any later version.
9#
10# This program is distributed in the hope that it will be useful,
11# but WITHOUT ANY WARRANTY; without even the implied warranty of
12# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13# GNU Affero General Public License for more details.
14#
15# You should have received a copy of the GNU General Public License
16# along with this program. If not, see <http://www.gnu.org/licenses/>
17
18/**
19 * Quick and dirty Android Crash Dump analyzer
20 *
21 * https://gitpull.it/P15
22 */
23
24$logcat_max_lines = 50;
25
26// base of your Phabricator
27define( 'BASE_URI', 'https://gitpull.it/maniphest/task/edit/form/3/?' );
28
29// received data
30$data_raw = $_POST['data'] ?? null;
31
32$data_clean_text = null;
33$task_args = null;
34if( $data_raw ) {
35
36 $data = @json_decode( $data_raw );
37
38 if( $data ) {
39
40 $data_raw = json_encode( $data, JSON_PRETTY_PRINT );
41
42 $app_version_name = $data->APP_VERSION_NAME ?? null;
43
44 // Take only some lines of logcat.
45 $logcat_reduced = null;
46 $logcat = $data->LOGCAT ?? null;
47 if ($logcat) {
48 $lines = explode("\n", $logcat);
49 $last_lines = [];
50 for ($i = 0; $i < 50 && $lines; $i++) {
51 $last_lines[] = array_pop($lines);
52 }
53 $last_lines = array_reverse($last_lines);
54 $logcat_reduced = implode("\n", $last_lines);
55 }
56
57 // some useful informations
58 $data_clean = [
59 'Version code' => $data->APP_VERSION_CODE ?? null,
60 'Version name' => $app_version_name,
61 'Android version' => $data->ANDROID_VERSION ?? null,
62 'Phone' => $data->PHONE_MODEL ?? null,
63 'Brand' => $data->BRAND ?? null,
64 'Stack' => $data->STACK_TRACE ?? null,
65 "logcat (last $logcat_max_lines lines)" => $logcat_reduced,
66 ];
67
68 // build an human phrase
69 $data_clean_parts = [];
70 foreach( $data_clean as $k => $v ) {
71 $data_clean_parts[] = "$k:\n$v";
72 }
73 $data_clean_text = implode( "\n\n", $data_clean_parts );
74 $data_clean_text = trim($data_clean_text);
75
76 // build query string
77 $task_args = [
78 'title' => "Fix crash caused by ... on version $app_version_name",
79 'description' => implode( "\n", [
80 "Dear Developers of the amazing Free/Libre and Open Source app #libre_busto,",
81 "Please triage my crash:",
82 '',
83 '```',
84 $data_clean_text,
85 '```',
86 '',
87 '',
88 "Thank you! :)",
89 '',
90 '',
91 "> Generated with https://lab.reyboz.it/libre-busto/crash-report/ (P15)",
92 ] ),
93 ];
94
95 } else {
96 $data_raw = 'invalid';
97 }
98
99}
100
101?>
102<html>
103<head>
104 <title>Libre BusTO - crash report dump</title>
105</head>
106<body>
107
108 <h1>Libre BusTO - crash report dump</h1>
109
110 <form method="post">
111 <?php if( $data_clean_text ): ?>
112 <h2>Generated Crash report</h2>
113 <?php if( $task_args ): ?>
114 <p>
115 <a href="<?= htmlspecialchars( BASE_URI . http_build_query( $task_args ) )?>" target="_blank">Create New Task in Phorge</a>
116 </p>
117 <?php endif ?>
118 <p>Preview of Task Content:<br />
119 <textarea readonly><?= htmlentities( $data_clean_text ) ?></textarea>
120 </p>
121 <?php endif ?>
122
123 <h2>Generate New Crash Report</h2>
124
125 <p>Paste here your JSON crash report:</p>
126
127 <p><textarea name="data"><?= htmlentities( $data_raw ) ?></textarea></p>
128
129 <p><button type="submit">OK</button></p>
130 </form>
131
132 <hr />
133
134 <p><a href="https://gitpull.it/tag/libre_busto/">Workboard</a></p>
135
136 <hr />
137
138 <p><a href="https://gitpull.it/P15" target="_blank">Source code and license</a></p>
139
140</body>
141</html>
142
.

We will debug soon!

valerio.bozzolan triaged this task as Normal priority.Jul 11 2021, 10:23
valerio.bozzolan renamed this task from Revoking location permission at system setting crashes app to Revoking location permission at system setting crashes app on version 1.14.Jul 20 2021, 10:03
fabio.mazza subscribed.Jul 24 2021, 19:48

This is probably fixed by now. Can you check if the issue is still present with the latest version? @wowhhh

wowhhh added a comment.Jul 27 2021, 08:06

Hello, I test it again on the latest version. This crash has been fixed.
I review the commits and I think this bug has been fixed in 6d35b0c0367e.

Very useful apps. Thanks for your reply!

valerio.bozzolan added a revision: D56: Add map fragment and fix stuff.Jul 27 2021, 09:07
valerio.bozzolan closed this task as Resolved.Jul 27 2021, 09:10
valerio.bozzolan assigned this task to fabio.mazza.

business-dance

Thank you @wowhhh!

Nice shot @fabio.mazza!

valerio.bozzolan moved this task from Arriving 🔥 to asd on the Libre BusTO board.Jan 10 2022, 14:12
valerio.bozzolan moved this task from asd to 1.11 - 1.15 on the Libre BusTO board.Sep 27 2022, 08:45
valerio.bozzolan edited projects, added Libre BusTO (1.11 - 1.15); removed Libre BusTO .
valerio.bozzolan moved this task from Arriving to 1.14 on the Libre BusTO (1.11 - 1.15) board.Sep 27 2022, 09:03
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register