Page MenuHomeGitPull.it
Differential D55

Use LiveData for favorites, add Fragment
ClosedPublic
Actions

Authored by fabio.mazza on May 11 2021, 22:23.
Tags
Referenced Files
F2108792: D55.id187.diff
Fri, Apr 26, 10:38
F2108791: D55.id186.diff
Fri, Apr 26, 10:38
F2108790: D55.id.diff
Fri, Apr 26, 10:38
Unknown Object (File)
Sat, Apr 20, 14:53
Unknown Object (File)
Sat, Apr 20, 02:47
Unknown Object (File)
Fri, Apr 19, 08:41
Unknown Object (File)
Thu, Apr 18, 12:54
Unknown Object (File)
Mon, Apr 15, 06:16
View All Files
Subscribers
valerio.bozzolan
Libre BusTO

Details

Reviewers
valerio.bozzolan
Commits
R4:7783fc75c1e9: Use LiveData for favorites, add Fragment
Summary

Make fragment version of favorites

Fragment hell is now

Fix fragment mayhem

Set queryHandler as final

Test Plan

Build and run

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 225
Build 296: BusTO Build Plan
Build 295: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.May 11 2021, 22:23
Restricted Application added a project: Libre BusTO . · View Herald TranscriptMay 11 2021, 22:23
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.May 11 2021, 22:24

Be bop be bop. I'm a bot. Builded:

→ D55-libre-busto-unsigned.apk

Harbormaster completed remote builds in B225: Diff 186.May 11 2021, 22:24
fabio.mazza requested review of this revision.May 11 2021, 22:24
valerio.bozzolan accepted this revision.May 12 2021, 01:39

The power of these refactors is getting stronger in you.

Tested. No implosions. Thank you dear.

asd

This revision is now accepted and ready to land.May 12 2021, 01:39
Closed by commit R4:7783fc75c1e9: Use LiveData for favorites, add Fragment. · Explain WhyMay 13 2021, 11:37
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:7783fc75c1e9: Use LiveData for favorites, add Fragment.

Revision Contents
Changeset List

Diff 186

View Options

build.gradle

Loading...
View Options

res/layout/fragment_favorites.xml

Loading...
View Options

src/it/reyboz/bustorino/ActivityFavorites.java

Loading...
View Options

src/it/reyboz/bustorino/ActivityMain.java

Loading...
View Options

src/it/reyboz/bustorino/ActivityPrincipal.java

Loading...
View Options

src/it/reyboz/bustorino/backend/Stop.java

Loading...
View Options

src/it/reyboz/bustorino/backend/StopsDBInterface.java

Loading...
View Options

src/it/reyboz/bustorino/data/AppDataProvider.java

Loading...
View Options

src/it/reyboz/bustorino/data/CustomAsyncQueryHandler.java

Loading...
View Options

src/it/reyboz/bustorino/data/FavoritesLiveData.java

Loading...
View Options

src/it/reyboz/bustorino/data/FavoritesViewModel.java

Loading...
View Options

src/it/reyboz/bustorino/data/NextGenDB.java

Loading...
View Options

src/it/reyboz/bustorino/data/StopsDB.java

Loading...
View Options

src/it/reyboz/bustorino/data/UserDB.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/ArrivalsFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/FavoritesFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/FragmentHelper.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/MainScreenFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/ResultListFragment.java

Loading...
View Options

src/it/reyboz/bustorino/middleware/AsyncDataDownload.java

Loading...
View Options

src/it/reyboz/bustorino/middleware/AsyncStopFavoriteAction.java

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register