Page MenuHomeGitPull.it
Differential D97

Try fixing mayhem of location permissions, and fragments viewing
ClosedPublic
Actions

Authored by fabio.mazza on Oct 28 2022, 18:39.

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
Restricted Maniphest Task
T1129: Fix crash caused by "Fragment already added: ArrivalsFragment" in FragmentStore.java:92 on version 1.18.1
Commits
R4:b033b4c95159: Try fixing mayhem of location permissions, and fragments viewing
Summary

Try fixing mayhem of location permission

Fix persistent problem of fragment already added, and restore correctly states of Fragments (especially LinesFragment)

Larger accuracy limit for GPS

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 360
Build 518: BusTO Build Plan
Build 517: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Oct 28 2022, 18:39
Restricted Application added a project: Libre BusTO . · View Herald TranscriptOct 28 2022, 18:39
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.Oct 28 2022, 18:42

Be bop be bop. I'm a bot. Builded:

→ D97-libre-busto-unsigned.apk

Harbormaster completed remote builds in B360: Diff 330.Oct 28 2022, 18:42
fabio.mazza requested review of this revision.Oct 28 2022, 18:42
valerio.bozzolan accepted this revision.Oct 29 2022, 03:33

Tested, ready to land. Thanks Big Fabione.

I've kept the app for lot of time in background and doing lot of things hoping to trigger the fragment shit, and I was not able to reproduce.

sgtm

This revision is now accepted and ready to land.Oct 29 2022, 03:33
Closed by commit R4:b033b4c95159: Try fixing mayhem of location permissions, and fragments viewing. · Explain WhyOct 30 2022, 12:23
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:b033b4c95159: Try fixing mayhem of location permissions, and fragments viewing.
valerio.bozzolan added a task: T1129: Fix crash caused by "Fragment already added: ArrivalsFragment" in FragmentStore.java:92 on version 1.18.1.Oct 30 2022, 18:56
valerio.bozzolan added a task: Restricted Maniphest Task.
valerio.bozzolan mentioned this in D98: Release F-Droid version 1.18.3.Oct 30 2022, 19:44
valerio.bozzolan mentioned this in R4:3a0ce92b6da6: Release F-Droid version 1.18.3.Oct 31 2022, 09:20

Revision Contents
Changeset List

PathSize
src/
it/
reyboz/
bustorino/
41 lines
adapters/
1 line
fragments/
1 line
55 lines
4 lines
208 lines
2 lines

Diff 330

View Options

src/it/reyboz/bustorino/ActivityPrincipal.java

Show First 20 Lines • Show All 394 Lines • ▼ Show 20 Lines public int getMinNumberOfPassages(){
if( routes.size() == 0) min = 0; if( routes.size() == 0) min = 0;
else for (Route r : routes){ else for (Route r : routes){
if(r.numPassaggi()>0) if(r.numPassaggi()>0)
min = Math.min(min,r.numPassaggi()); min = Math.min(min,r.numPassaggi());
} }
if (min == Integer.MAX_VALUE) return 0; if (min == Integer.MAX_VALUE) return 0;
else return min; else return min;
} }
public ArrayList<String> getRoutesNamesWithNoPassages(){
ArrayList<String> mList = new ArrayList<>();
if(routes==null || routes.size() == 0){
return mList;
}
for(Route r: routes){
if(r.numPassaggi()==0)
mList.add(r.getNameForDisplay());
}
return mList;
}
//private void mergeRoute //private void mergeRoute
} }
No newline at end of file No newline at end of file
View Options

src/it/reyboz/bustorino/adapters/PalinaAdapter.java

Show First 20 Lines • Show All 394 Lines • ▼ Show 20 Lines public int getMinNumberOfPassages(){
if( routes.size() == 0) min = 0; if( routes.size() == 0) min = 0;
else for (Route r : routes){ else for (Route r : routes){
if(r.numPassaggi()>0) if(r.numPassaggi()>0)
min = Math.min(min,r.numPassaggi()); min = Math.min(min,r.numPassaggi());
} }
if (min == Integer.MAX_VALUE) return 0; if (min == Integer.MAX_VALUE) return 0;
else return min; else return min;
} }
public ArrayList<String> getRoutesNamesWithNoPassages(){
ArrayList<String> mList = new ArrayList<>();
if(routes==null || routes.size() == 0){
return mList;
}
for(Route r: routes){
if(r.numPassaggi()==0)
mList.add(r.getNameForDisplay());
}
return mList;
}
//private void mergeRoute //private void mergeRoute
} }
No newline at end of file No newline at end of file
View Options

src/it/reyboz/bustorino/fragments/ArrivalsFragment.java

Show First 20 Lines • Show All 394 Lines • ▼ Show 20 Lines public int getMinNumberOfPassages(){
if( routes.size() == 0) min = 0; if( routes.size() == 0) min = 0;
else for (Route r : routes){ else for (Route r : routes){
if(r.numPassaggi()>0) if(r.numPassaggi()>0)
min = Math.min(min,r.numPassaggi()); min = Math.min(min,r.numPassaggi());
} }
if (min == Integer.MAX_VALUE) return 0; if (min == Integer.MAX_VALUE) return 0;
else return min; else return min;
} }
public ArrayList<String> getRoutesNamesWithNoPassages(){
ArrayList<String> mList = new ArrayList<>();
if(routes==null || routes.size() == 0){
return mList;
}
for(Route r: routes){
if(r.numPassaggi()==0)
mList.add(r.getNameForDisplay());
}
return mList;
}
//private void mergeRoute //private void mergeRoute
} }
No newline at end of file No newline at end of file
View Options

src/it/reyboz/bustorino/fragments/LinesFragment.kt

Show First 20 Lines • Show All 394 Lines • ▼ Show 20 Lines public int getMinNumberOfPassages(){
if( routes.size() == 0) min = 0; if( routes.size() == 0) min = 0;
else for (Route r : routes){ else for (Route r : routes){
if(r.numPassaggi()>0) if(r.numPassaggi()>0)
min = Math.min(min,r.numPassaggi()); min = Math.min(min,r.numPassaggi());
} }
if (min == Integer.MAX_VALUE) return 0; if (min == Integer.MAX_VALUE) return 0;
else return min; else return min;
} }
public ArrayList<String> getRoutesNamesWithNoPassages(){
ArrayList<String> mList = new ArrayList<>();
if(routes==null || routes.size() == 0){
return mList;
}
for(Route r: routes){
if(r.numPassaggi()==0)
mList.add(r.getNameForDisplay());
}
return mList;
}
//private void mergeRoute //private void mergeRoute
} }
No newline at end of file No newline at end of file
View Options

src/it/reyboz/bustorino/fragments/LinesViewModel.kt

Loading...
View Options

src/it/reyboz/bustorino/fragments/MainScreenFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register