Differential D118

Bug fixes for Trips downloads and DB update
ClosedPublic
Actions

Authored by fabio.mazza on Jun 6 2023, 11:35.

Details

Reviewers

valerio.bozzolan

Commits

R4:620b5b436023: Bug fixes for Trips downloads and DB update

Summary

Fix bug from downloading gtfs trip info from Mato

Try to fix problem of closed db connection

Test Plan

Check that the map doesn't crashes

Diff Detail

Repository

R4 Libre BusTO

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 408
Build 583: BusTO Build Plan
Build 582: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Jun 6 2023, 11:35

Restricted Application added a project: Libre BusTO . · View Herald TranscriptJun 6 2023, 11:35

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript

Be bop be bop. I'm a bot. Builded:

→ D118-libre-busto-unsigned.apk

sha256 2e12874fb97bb53f04bd133ecf6c67e8aef48494daa111e682e33052759e8b1d  ./app/build/outputs/apk/debug/app-debug.apk

Harbormaster completed remote builds in B407: Diff 381.Jun 6 2023, 11:39

fabio.mazza requested review of this revision.Jun 6 2023, 11:39

Harbormaster failed remote builds in B407: Diff 381!Jun 6 2023, 12:16

Cleanup stacktrace, reestablish test

Harbormaster failed remote builds in B408: Diff 382!Jun 6 2023, 12:34

Be bop be bop. I'm a bot. Builded:

→ D118-libre-busto-unsigned.apk

sha256 6e2deb8937ebbf4258913f5ededeea13e6a55281a85ba10930264ea500a71d2b  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk

Harbormaster completed remote builds in B408: Diff 382.Jun 6 2023, 12:58

Be bop be bop. I'm a bot. Builded:

→ D118-libre-busto.apk

sha256 535b5da63bd490a33faef29751137fa44faeb057a5555044ee27ee5d5d1f6c30  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk

sgtm

This revision is now accepted and ready to land.Jun 6 2023, 13:34

Closed by commit R4:620b5b436023: Bug fixes for Trips downloads and DB update. · Explain WhyJun 6 2023, 13:45

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:620b5b436023: Bug fixes for Trips downloads and DB update.

Revision Contents
Changeset List

Path

Size

app/

src/

main/

java/

it/

reyboz/

bustorino/

ActivityExperiments.java

3 lines

backend/

mato/

MatoQueries.kt

34 lines

ResponseParsing.kt

51 lines

data/

DBUpdateWorker.java

4 lines

DatabaseUpdate.java

32 lines

MatoDownloadTripsWorker.kt

8 lines

MatoRepository.kt

3 lines

fragments/

LinesDetailFragment.kt

37 lines

MapFragment.java

6 lines

Diff 382

View Options

app/src/main/java/it/reyboz/bustorino/ActivityExperiments.java

Show First 20 Lines • Show All 394 Lines • ▼ Show 20 Lines	public int getMinNumberOfPassages(){
if( routes.size() == 0) min = 0;		if( routes.size() == 0) min = 0;
else for (Route r : routes){		else for (Route r : routes){
if(r.numPassaggi()>0)		if(r.numPassaggi()>0)
min = Math.min(min,r.numPassaggi());		min = Math.min(min,r.numPassaggi());
}		}
if (min == Integer.MAX_VALUE) return 0;		if (min == Integer.MAX_VALUE) return 0;
else return min;		else return min;
}		}

		public ArrayList<String> getRoutesNamesWithNoPassages(){
		ArrayList<String> mList = new ArrayList<>();
		if(routes==null \|\| routes.size() == 0){
		return mList;
		}
		for(Route r: routes){
		if(r.numPassaggi()==0)
		mList.add(r.getNameForDisplay());
		}

		return mList;
		}
//private void mergeRoute		//private void mergeRoute
}		}
No newline at end of file		No newline at end of file

View Options

app/src/main/java/it/reyboz/bustorino/backend/mato/MatoQueries.kt

Show First 20 Lines • Show All 394 Lines • ▼ Show 20 Lines	public int getMinNumberOfPassages(){
if( routes.size() == 0) min = 0;		if( routes.size() == 0) min = 0;
else for (Route r : routes){		else for (Route r : routes){
if(r.numPassaggi()>0)		if(r.numPassaggi()>0)
min = Math.min(min,r.numPassaggi());		min = Math.min(min,r.numPassaggi());
}		}
if (min == Integer.MAX_VALUE) return 0;		if (min == Integer.MAX_VALUE) return 0;
else return min;		else return min;
}		}

		public ArrayList<String> getRoutesNamesWithNoPassages(){
		ArrayList<String> mList = new ArrayList<>();
		if(routes==null \|\| routes.size() == 0){
		return mList;
		}
		for(Route r: routes){
		if(r.numPassaggi()==0)
		mList.add(r.getNameForDisplay());
		}

		return mList;
		}
//private void mergeRoute		//private void mergeRoute
}		}
No newline at end of file		No newline at end of file

View Options

app/src/main/java/it/reyboz/bustorino/backend/mato/ResponseParsing.kt

Show First 20 Lines • Show All 394 Lines • ▼ Show 20 Lines	public int getMinNumberOfPassages(){
if( routes.size() == 0) min = 0;		if( routes.size() == 0) min = 0;
else for (Route r : routes){		else for (Route r : routes){
if(r.numPassaggi()>0)		if(r.numPassaggi()>0)
min = Math.min(min,r.numPassaggi());		min = Math.min(min,r.numPassaggi());
}		}
if (min == Integer.MAX_VALUE) return 0;		if (min == Integer.MAX_VALUE) return 0;
else return min;		else return min;
}		}

		public ArrayList<String> getRoutesNamesWithNoPassages(){
		ArrayList<String> mList = new ArrayList<>();
		if(routes==null \|\| routes.size() == 0){
		return mList;
		}
		for(Route r: routes){
		if(r.numPassaggi()==0)
		mList.add(r.getNameForDisplay());
		}

		return mList;
		}
//private void mergeRoute		//private void mergeRoute
}		}
No newline at end of file		No newline at end of file

View Options

app/src/main/java/it/reyboz/bustorino/data/DBUpdateWorker.java

Show First 20 Lines • Show All 394 Lines • ▼ Show 20 Lines	public int getMinNumberOfPassages(){
if( routes.size() == 0) min = 0;		if( routes.size() == 0) min = 0;
else for (Route r : routes){		else for (Route r : routes){
if(r.numPassaggi()>0)		if(r.numPassaggi()>0)
min = Math.min(min,r.numPassaggi());		min = Math.min(min,r.numPassaggi());
}		}
if (min == Integer.MAX_VALUE) return 0;		if (min == Integer.MAX_VALUE) return 0;
else return min;		else return min;
}		}

		public ArrayList<String> getRoutesNamesWithNoPassages(){
		ArrayList<String> mList = new ArrayList<>();
		if(routes==null \|\| routes.size() == 0){
		return mList;
		}
		for(Route r: routes){
		if(r.numPassaggi()==0)
		mList.add(r.getNameForDisplay());
		}

		return mList;
		}
//private void mergeRoute		//private void mergeRoute
}		}
No newline at end of file		No newline at end of file