Differential D128

Fix bugs, use new viewmodel to load stops
ClosedPublic
Actions

Authored by fabio.mazza on Aug 26 2023, 19:45.

Details

Reviewers

valerio.bozzolan

Maniphest Tasks

T1185: Fix crash caused by null pointer in ActivityPrincipal.java:618 on version 1.19.1-gitdev

Commits

R4:869510b7f7e1: Fix bugs, use new viewmodel to load stops

Summary

Fix T1185

Update the NearbyStopsFragment type, cleanup MQTT on disconnect.

Rename .java to .kt

Create ViewModel to load stops that are in the map bounding box.

Test Plan

Do stuff.

Diff Detail

Repository

R4 Libre BusTO

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 439
Build 629: BusTO Build Plan
Build 628: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Aug 26 2023, 19:45

Restricted Application added a project: Libre BusTO . · View Herald TranscriptAug 26 2023, 19:45

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript

Be bop be bop. I'm a bot. Builded successfully ✨

D128-libre-busto.apk

sha256 8adc929b151ec20e83b8f4fd6d5263ef9d889a3ae19636f3ceceff112f2d868d  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk

Harbormaster completed remote builds in B438: Diff 406.Aug 26 2023, 19:47

fabio.mazza requested review of this revision.Aug 26 2023, 19:47

Move readyGUIFor in OnResume

Be bop be bop. I'm a bot. Builded successfully ✨

D128-libre-busto.apk

sha256 6e5bf1eb76beae858b950150e36e8ce14449875fdfbefddd7cc744482547ceff  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk

Harbormaster completed remote builds in B439: Diff 407.Aug 26 2023, 19:53

valerio.bozzolan edited the summary of this revision. (Show Details)Aug 26 2023, 20:42

valerio.bozzolan edited the test plan for this revision. (Show Details)

valerio.bozzolan removed a subscriber: Libre BusTO .

Tested :) Yeah let's be ready for GUI

sgtm

This revision is now accepted and ready to land.Aug 26 2023, 23:54

Closed by commit R4:869510b7f7e1: Fix bugs, use new viewmodel to load stops. · Explain WhyAug 27 2023, 12:55

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:869510b7f7e1: Fix bugs, use new viewmodel to load stops.

Revision Contents
Changeset List

Path

Size

app/

src/

main/

java/

it/

reyboz/

bustorino/

backend/

mato/

MQTTMatoClient.kt

6 lines

data/

OldDataRepository.java

OldDataRepository.kt

69 lines

fragments/

FragmentHelper.java

2 lines

GTFSPositionsViewModel.kt

LinesDetailFragment.kt

5 lines

LinesFragment.kt

2 lines

LinesGridShowingFragment.kt

3 lines

LinesViewModel.kt

MainScreenFragment.java

2 lines

MapFragment.java

81 lines

NearbyStopsFragment.java

55 lines

StopListFragment.java

5 lines

	viewmodels/
	fragments/

GTFSPositionsViewModel.kt

2 lines

LinesViewModel.kt

3 lines

viewmodels/

MQTTPositionsViewModel.kt

1 line

StopsMapViewModel.kt

55 lines

Diff 407

View Options

app/src/main/java/it/reyboz/bustorino/backend/mato/MQTTMatoClient.kt

	apply plugin: 'kotlin-kapt'			apply plugin: 'kotlin-kapt'
	apply plugin: 'kotlin-android'			apply plugin: 'kotlin-android'
	apply plugin: 'com.android.application'			apply plugin: 'com.android.application'


	android {			android {
	compileSdkVersion 33			compileSdkVersion 33
	buildToolsVersion '33.0.2'			buildToolsVersion '33.0.2'
	namespace "it.reyboz.bustorino"			namespace "it.reyboz.bustorino"

	defaultConfig {			defaultConfig {
	applicationId "it.reyboz.bustorino"			applicationId "it.reyboz.bustorino"
	minSdkVersion 21			minSdkVersion 21
	targetSdkVersion 33			targetSdkVersion 33
	versionCode 51			versionCode 52
	versionName "2.1.1"			versionName "2.1.2"
	vectorDrawables.useSupportLibrary = true			vectorDrawables.useSupportLibrary = true
	multiDexEnabled true			multiDexEnabled true
	javaCompileOptions {			javaCompileOptions {
	annotationProcessorOptions {			annotationProcessorOptions {
	arguments = ["room.schemaLocation": "$projectDir/assets/schemas/".toString()]			arguments = ["room.schemaLocation": "$projectDir/assets/schemas/".toString()]
	}			}
	}			}
	testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"			testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
	▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines

View Options

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.java

	apply plugin: 'kotlin-kapt'			apply plugin: 'kotlin-kapt'
	apply plugin: 'kotlin-android'			apply plugin: 'kotlin-android'
	apply plugin: 'com.android.application'			apply plugin: 'com.android.application'


	android {			android {
	compileSdkVersion 33			compileSdkVersion 33
	buildToolsVersion '33.0.2'			buildToolsVersion '33.0.2'
	namespace "it.reyboz.bustorino"			namespace "it.reyboz.bustorino"

	defaultConfig {			defaultConfig {
	applicationId "it.reyboz.bustorino"			applicationId "it.reyboz.bustorino"
	minSdkVersion 21			minSdkVersion 21
	targetSdkVersion 33			targetSdkVersion 33
	versionCode 51			versionCode 52
	versionName "2.1.1"			versionName "2.1.2"
	vectorDrawables.useSupportLibrary = true			vectorDrawables.useSupportLibrary = true
	multiDexEnabled true			multiDexEnabled true
	javaCompileOptions {			javaCompileOptions {
	annotationProcessorOptions {			annotationProcessorOptions {
	arguments = ["room.schemaLocation": "$projectDir/assets/schemas/".toString()]			arguments = ["room.schemaLocation": "$projectDir/assets/schemas/".toString()]
	}			}
	}			}
	testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"			testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
	▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines

View Options

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.kt

	apply plugin: 'kotlin-kapt'			apply plugin: 'kotlin-kapt'
	apply plugin: 'kotlin-android'			apply plugin: 'kotlin-android'
	apply plugin: 'com.android.application'			apply plugin: 'com.android.application'


	android {			android {
	compileSdkVersion 33			compileSdkVersion 33
	buildToolsVersion '33.0.2'			buildToolsVersion '33.0.2'
	namespace "it.reyboz.bustorino"			namespace "it.reyboz.bustorino"

	defaultConfig {			defaultConfig {
	applicationId "it.reyboz.bustorino"			applicationId "it.reyboz.bustorino"
	minSdkVersion 21			minSdkVersion 21
	targetSdkVersion 33			targetSdkVersion 33
	versionCode 51			versionCode 52
	versionName "2.1.1"			versionName "2.1.2"
	vectorDrawables.useSupportLibrary = true			vectorDrawables.useSupportLibrary = true
	multiDexEnabled true			multiDexEnabled true
	javaCompileOptions {			javaCompileOptions {
	annotationProcessorOptions {			annotationProcessorOptions {
	arguments = ["room.schemaLocation": "$projectDir/assets/schemas/".toString()]			arguments = ["room.schemaLocation": "$projectDir/assets/schemas/".toString()]
	}			}
	}			}
	testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"			testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
	▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines

View Options

app/src/main/java/it/reyboz/bustorino/fragments/FragmentHelper.java

	apply plugin: 'kotlin-kapt'			apply plugin: 'kotlin-kapt'
	apply plugin: 'kotlin-android'			apply plugin: 'kotlin-android'
	apply plugin: 'com.android.application'			apply plugin: 'com.android.application'


	android {			android {
	compileSdkVersion 33			compileSdkVersion 33
	buildToolsVersion '33.0.2'			buildToolsVersion '33.0.2'
	namespace "it.reyboz.bustorino"			namespace "it.reyboz.bustorino"

	defaultConfig {			defaultConfig {
	applicationId "it.reyboz.bustorino"			applicationId "it.reyboz.bustorino"
	minSdkVersion 21			minSdkVersion 21
	targetSdkVersion 33			targetSdkVersion 33
	versionCode 51			versionCode 52
	versionName "2.1.1"			versionName "2.1.2"
	vectorDrawables.useSupportLibrary = true			vectorDrawables.useSupportLibrary = true
	multiDexEnabled true			multiDexEnabled true
	javaCompileOptions {			javaCompileOptions {
	annotationProcessorOptions {			annotationProcessorOptions {
	arguments = ["room.schemaLocation": "$projectDir/assets/schemas/".toString()]			arguments = ["room.schemaLocation": "$projectDir/assets/schemas/".toString()]
	}			}
	}			}
	testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"			testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
	▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines