Page MenuHomeGitPull.it
Differential D161

Re-enable foreground service with special notification channel, upgrade ACRA version
ClosedPublic
Actions

Authored by fabio.mazza on Wed, Apr 10, 23:00.
Tags
Referenced Files
F2121334: D161.id503.diff
Mon, May 6, 10:23
Unknown Object (File)
Fri, May 3, 01:57
Unknown Object (File)
Thu, May 2, 22:11
Unknown Object (File)
Tue, Apr 30, 08:59
Unknown Object (File)
Tue, Apr 30, 07:21
Unknown Object (File)
Mon, Apr 29, 22:28
Unknown Object (File)
Mon, Apr 29, 22:27
Unknown Object (File)
Sat, Apr 27, 21:24
View All 24 Files
Subscribers
valerio.bozzolan
Libre BusTO

Details

Reviewers
valerio.bozzolan
Commits
R4:a330488f6982: Re-enable foreground service with special notification channel, upgrade ACRA…
Summary

Insert back the foreground service notification (and permission), complying with Play Store

Also, avoid non-stop request of trip data that simply fails to download, giving rise to less notifications on devices that run Android < 12.

Test Plan

Check nothing is broken

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 533
Build 782: BusTO Build Plan
Build 781: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Wed, Apr 10, 23:00
Restricted Application added a project: Libre BusTO . · View Herald TranscriptWed, Apr 10, 23:00
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.Wed, Apr 10, 23:06

Be bop be bop. I'm a bot. Builded successfully ✨

D161-libre-busto.apk

sha256 6195f6b94e0c89c2d3607f72023e6d3dd524c62b1c87a0439872574175ad2cef
Harbormaster completed remote builds in B533: Diff 503.Wed, Apr 10, 23:06
fabio.mazza requested review of this revision.Wed, Apr 10, 23:06
valerio.bozzolan accepted this revision.Thu, Apr 11, 08:41

Speriamo asd. Tested, using random actions:

  • opened map
  • see realtime stuff
  • click on lines
  • manual db update
  • click 20 times
  • close app / re-open
  • asd

sgtm

This revision is now accepted and ready to land.Thu, Apr 11, 08:41
Closed by commit R4:a330488f6982: Re-enable foreground service with special notification channel, upgrade ACRA…. · Explain WhyThu, Apr 11, 12:38
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:a330488f6982: Re-enable foreground service with special notification channel, upgrade ACRA….

Revision Contents
Changeset List

PathSize
app/
13 lines
src/
main/
5 lines
java/
it/
reyboz/
bustorino/
37 lines
backend/
32 lines
mato/
9 lines
data/
1 line
25 lines
fragments/
2 lines
9 lines
viewmodels/
5 lines
62 lines
res/
values-it/
7 lines
values/
5 lines
6 lines

Diff 503

View Options

app/build.gradle

Loading...
View Options

app/src/main/AndroidManifest.xml

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/BustoApp.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/backend/Notifications.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/backend/mato/MQTTMatoClient.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/data/DBUpdateWorker.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/data/MatoTripsDownloadWorker.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/MapFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/GtfsPositionsViewModel.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/LivePositionsViewModel.kt

Loading...
View Options

app/src/main/res/values-it/strings.xml

Loading...
View Options

app/src/main/res/values/strings.xml

Loading...
View Options

build.gradle

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register