Page MenuHomeGitPull.it
Differential D143

Fix crash on Android 14 with MaTO
ClosedPublic
Actions

Authored by fabio.mazza on Dec 15 2023, 13:45.

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
T1220: Fix crash with MQTT service on Android 14
Commits
R4:79277c18a92b: Fix crash on Android 14 with MaTO
Summary

Add notification permission for Android 14

Bump MQTT service version to fix problem on Android 14

Update notification channel strings

Better error handling

Line width change

Closes T1220

Diff Detail

Repository
R4 Libre BusTO
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Dec 15 2023, 13:45
Restricted Application added a project: Libre BusTO . · View Herald TranscriptDec 15 2023, 13:45
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 15 2023, 13:46
Harbormaster failed remote builds in B487: Diff 455!
fabio.mazza updated this revision to Diff 456.Dec 15 2023, 13:59
  • Wait more time for GTFS positions request
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 15 2023, 13:59
Harbormaster failed remote builds in B488: Diff 456!
gitpull.android.builder added a comment.Dec 21 2023, 07:09

Be bop be bop. I'm a bot. Builded successfully ✨

D143-libre-busto.apk

sha256 60e3b23054c5b3ae5f647e1b2465006049f7918d6fbcfb11603e8b0c09ae31e8  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk
Harbormaster completed remote builds in B488: Diff 456.Dec 21 2023, 07:09
fabio.mazza requested review of this revision.Dec 21 2023, 07:09
valerio.bozzolan accepted this revision.Dec 21 2023, 07:37

sgtm

Tested visiting the Map, and I still see bus navigating around, like silly machines.

Thanks Big Fabione

(Adopted OpenJDK 17, finally building \o/)

This revision is now accepted and ready to land.Dec 21 2023, 07:37
valerio.bozzolan edited the summary of this revision. (Show Details)Dec 21 2023, 07:54
valerio.bozzolan added a task: T1220: Fix crash with MQTT service on Android 14.
Closed by commit R4:79277c18a92b: Fix crash on Android 14 with MaTO. · Explain WhyDec 21 2023, 10:45
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:79277c18a92b: Fix crash on Android 14 with MaTO.

Revision Contents
Changeset List

PathSize
app/
2 lines
src/
main/
1 line
java/
it/
reyboz/
bustorino/
backend/
gtfs/
1 line
mato/
97 lines
data/
6 lines
fragments/
3 lines
viewmodels/
12 lines
res/
values-it/
5 lines
values/
5 lines

Diff 457

View Options

app/build.gradle

Loading...
View Options

app/src/main/AndroidManifest.xml

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/backend/gtfs/GtfsRtPositionsRequest.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/backend/mato/MQTTMatoClient.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/data/MatoTripsDownloadWorker.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/LivePositionsViewModel.kt

Loading...
View Options

app/src/main/res/values-it/strings.xml

Loading...
View Options

app/src/main/res/values/strings.xml

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register