Page MenuHomeGitPull.it
Differential D148

Fix introduction, add new icon to detail map to stop location, bugfixes
ClosedPublic
Actions

Authored by fabio.mazza on Jan 22 2024, 13:21.

Details

Reviewers
valerio.bozzolan
Commits
R4:e5c075dd0760: Fix introduction, add new icon to detail map to stop location, bugfixes
Summary
  • Don't show permission button for location on Android 21
  • Remove markers from the map when they are assigned a different direction
  • Fix new button position
  • Add icon to map in LinesDetailFragment to stop using GPS, fix bug in MQTT

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 499
Build 727: BusTO Build Plan
Build 726: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Jan 22 2024, 13:21
Restricted Application added a project: Libre BusTO . · View Herald TranscriptJan 22 2024, 13:21
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.Jan 22 2024, 13:24

Be bop be bop. I'm a bot. Builded successfully ✨

D148-libre-busto.apk

sha256 ad1158a27d6dc9cd04535ec618b1314603883f848b461a2ce20013eea333466f
Harbormaster completed remote builds in B499: Diff 467.Jan 22 2024, 13:24
fabio.mazza requested review of this revision.Jan 22 2024, 13:24
valerio.bozzolan accepted this revision.Jan 22 2024, 13:28

Tested on an old device: I have not seen that popup, successfully.

Map still working.

sgtm

asd

This revision is now accepted and ready to land.Jan 22 2024, 13:28
fabio.mazza updated this revision to Diff 468.Jan 22 2024, 13:40
  • Set default value in settings for live positions source
This revision now requires review to proceed.Jan 22 2024, 13:40
fabio.mazza edited the summary of this revision. (Show Details)Jan 22 2024, 13:40
gitpull.android.builder added a comment.Jan 22 2024, 13:43

Be bop be bop. I'm a bot. Builded successfully ✨

D148-libre-busto.apk

sha256 90e2cfb6abc235bc690bbf5912396b53d9dc02632eef2fb23fe83e86ef40d0e1
Harbormaster completed remote builds in B500: Diff 468.Jan 22 2024, 13:43
valerio.bozzolan accepted this revision.Jan 22 2024, 13:52
This revision is now accepted and ready to land.Jan 22 2024, 13:52
Closed by commit R4:e5c075dd0760: Fix introduction, add new icon to detail map to stop location, bugfixes. · Explain WhyJan 22 2024, 13:53
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:e5c075dd0760: Fix introduction, add new icon to detail map to stop location, bugfixes.

Revision Contents
Changeset List

PathSize
app/
src/
main/
java/
it/
reyboz/
bustorino/
fragments/
15 lines
42 lines
viewmodels/
2 lines
res/
drawable/
13 lines
13 lines
layout/
6 lines
28 lines
values-it/
3 lines
values/
3 lines

Diff 467

View Options

app/src/main/java/it/reyboz/bustorino/fragments/IntroFragment.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/LivePositionsViewModel.kt

Loading...
View Options

app/src/main/res/drawable/location_circlew_grey.xml

Loading...
View Options

app/src/main/res/drawable/location_circlew_red.xml

Loading...
View Options

app/src/main/res/layout/fragment_intro.xml

Loading...
View Options

app/src/main/res/layout/fragment_lines_detail.xml

Loading...
View Options

app/src/main/res/values-it/strings.xml

Loading...
View Options

app/src/main/res/values/strings.xml

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register