Page MenuHomeGitPull.it
Differential D151

Button behaviour change when location is disabled
ClosedPublic
Actions

Authored by fabio.mazza on Jan 28 2024, 13:00.
Tags
Referenced Files
F2128035: D151.1715663683.diff
Mon, May 13, 07:14
F2128033: D151.1715663677.diff
Mon, May 13, 07:14
F2128031: D151.1715663670.diff
Mon, May 13, 07:14
F2128030: D151.1715663667.diff
Mon, May 13, 07:14
F2126862: D151.1715627728.diff
Sun, May 12, 21:15
F2126673: D151.1715617055.diff
Sun, May 12, 18:17
Subscribers
valerio.bozzolan
Libre BusTO

Details

Reviewers
valerio.bozzolan
Commits
R4:29d872aaf338: Button behaviour change when location is disabled

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 508
Build 741: BusTO Build Plan
Build 740: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Jan 28 2024, 13:00
Restricted Application added a project: Libre BusTO . · View Herald TranscriptJan 28 2024, 13:00
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.Jan 28 2024, 13:03

Be bop be bop. I'm a bot. Builded successfully ✨

D151-libre-busto.apk

sha256 6b2b8182441d27d1d6b69670c2803f8b2867d34558380c1227229435c55bc112
Harbormaster completed remote builds in B507: Diff 476.Jan 28 2024, 13:03
fabio.mazza requested review of this revision.Jan 28 2024, 13:03
fabio.mazza updated this revision to Diff 478.Jan 29 2024, 00:15
  • Deal with the case of no permissions for location
  • Show nearby stops fragment when the permission is given in the mean time
gitpull.android.builder added a comment.Jan 29 2024, 00:18

Be bop be bop. I'm a bot. Builded successfully ✨

D151-libre-busto.apk

sha256 b9fd49947df7c3fcd03fe1bdc6d89bb1893b795ad08840d47208b68b0a2a3d31
Harbormaster completed remote builds in B508: Diff 478.Jan 29 2024, 00:18
valerio.bozzolan accepted this revision.Jan 29 2024, 08:15

I'm tested and I know it

sgtm

This revision is now accepted and ready to land.Jan 29 2024, 08:15
Closed by commit R4:29d872aaf338: Button behaviour change when location is disabled. · Explain WhyJan 29 2024, 11:05
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:29d872aaf338: Button behaviour change when location is disabled.

Revision Contents
Changeset List

PathSize
app/
src/
main/
java/
it/
reyboz/
bustorino/
fragments/
106 lines
63 lines
119 lines
27 lines
middleware/
7 lines
28 lines
util/
2 lines
res/
values-it/
3 lines
values/
7 lines

Diff 478

View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/middleware/AppLocationManager.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/middleware/LocationUtils.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/util/Permissions.java

Loading...
View Options

app/src/main/res/values-it/strings.xml

Loading...
View Options

app/src/main/res/values/strings.xml

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register