Page MenuHomeGitPull.it
Differential D173

Add search of lines functionality in-app
ClosedPublic
Actions

Authored by fabio.mazza on Fri, Nov 15, 01:32.

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
T1199: Bus lines filter
Commits
R4:8c3ff9906a4e: Add search of lines functionality in-app
Summary

Fix bug of mismatching adapters

Filter in lowercase

Resolves T1199

Test Plan

Open the tab Lines, tap a line.

Open the tab Lines, search "47", tap that line.

Open and close the tab Lines quickly, no crashes.

Open the tab Lines, tap the search bar, undo, tap, undo, no crash.

Diff Detail

Repository
R4 Libre BusTO
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Fri, Nov 15, 01:32
Restricted Application added a project: Libre BusTO . · View Herald TranscriptFri, Nov 15, 01:32
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.Fri, Nov 15, 01:35

Be bop be bop. I'm a bot. Builded successfully ✨

D173-libre-busto.apk

sha256 c9ccc1c9d489f800d18f135151623fac2ecf2e8de567da88453af778d2f0e078
Harbormaster completed remote builds in B567: Diff 533.Fri, Nov 15, 01:35
fabio.mazza requested review of this revision.Fri, Nov 15, 01:35
valerio.bozzolan accepted this revision.Fri, Nov 15, 07:14
valerio.bozzolan edited the test plan for this revision. (Show Details)

Figo asd

asd

This revision is now accepted and ready to land.Fri, Nov 15, 07:14
fabio.mazza edited the summary of this revision. (Show Details)Fri, Nov 15, 10:03
fabio.mazza added a task: T1199: Bus lines filter.
Closed by commit R4:8c3ff9906a4e: Add search of lines functionality in-app. · Explain WhyFri, Nov 15, 17:29
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:8c3ff9906a4e: Add search of lines functionality in-app.

Revision Contents
Changeset List

PathSize
app/
src/
main/
java/
it/
reyboz/
bustorino/
adapters/
32 lines
fragments/
92 lines
1 line
viewmodels/
52 lines
res/
drawable/
8 lines
layout/
3 lines
menu/
11 lines
values-it/
3 lines
values/
4 lines

Diff 534

View Options

app/src/main/java/it/reyboz/bustorino/adapters/StringListAdapter.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/LinesGridShowingFragment.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/LinesGridShowingViewModel.kt

Loading...
View Options

app/src/main/res/drawable/magnifying_glass.xml

Loading...
View Options

app/src/main/res/layout/fragment_lines_grid.xml

Loading...
View Options

app/src/main/res/menu/menu_search.xml

Loading...
View Options

app/src/main/res/values-it/strings.xml

Loading...
View Options

app/src/main/res/values/strings.xml

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register