Fix crashes in the map and line fragments
ClosedPublic
Actions

Authored by fabio.mazza on Mon, Nov 24, 10:38.

Details

Reviewers

Maniphest Tasks

T1373: Fix crash in closing map fragment on version 2.4.6-gitdev
T1374: Fix crash caused by OutofBounds on version 2.4.4

Commits

R4:4021896b257b: Fix crashes in the map and line fragments

Summary

Fix T1373 (bug concurrent modification)

Fix T1374 (Avoid crashing when list of points is empty)

Test Plan

Open map. See MQTT realtime positions.

App in background. Open 5 big different apps (e.g. Mindustry). Open app again. Still works.

Diff Detail

Repository

R4 Libre BusTO

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Mon, Nov 24, 10:38

Restricted Application added a project: Libre BusTO . · View Herald TranscriptMon, Nov 24, 10:38

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript

fabio.mazza edited the summary of this revision. (Show Details)Mon, Nov 24, 10:39

fabio.mazza added tasks: T1374: Fix crash caused by OutofBounds on version 2.4.4, T1373: Fix crash in closing map fragment on version 2.4.6-gitdev.

Harbormaster completed remote builds in B779: Diff 650.Mon, Nov 24, 10:39

fabio.mazza requested review of this revision.Mon, Nov 24, 10:39

valerio.bozzolan accepted this revision.Mon, Nov 24, 11:02

This revision is now accepted and ready to land.Mon, Nov 24, 11:02

valerio.bozzolan edited the test plan for this revision. (Show Details)Mon, Nov 24, 11:05

I will re-tag this as 2.4.6 after land

Closed by commit R4:4021896b257b: Fix crashes in the map and line fragments. · Explain WhyMon, Nov 24, 11:16

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:4021896b257b: Fix crashes in the map and line fragments.

Revision Contents
Changeset List

Path

Size

app/

src/

main/

java/

it/

reyboz/

bustorino/

backend/

mato/

MQTTMatoClient.kt

29 lines

map/

MapLibreUtils.kt

5 lines

Diff 651

View Options

app/src/main/java/it/reyboz/bustorino/backend/mato/MQTTMatoClient.kt