Convert Passaggio to Kotlin and finally use the correct class for the arrival time
Fix sorting in the nearby arrivals, write tests
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
Libre BusTO hackers - Commits
- R4:16c36b36d42b: Rewrite Passaggio logic in Kotlin using java time classes, add test
Use both the development build and the stable one.
Check arrival times of the same stop in both app, see that they match in order
Diff Detail
Diff Detail
- Repository
- R4 Libre BusTO
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Be bop be bop. I'm a bot. Builded successfully ✨
sha256 f9a457b959a12c8a71738e78c0fcdd76aad4aa76a2c95a8fd838680f03fdc4d3
Comment Actions
Bip bop I'm a bot. Here fresh Android builds:
APK for arm64-v8a:
Download D229-arm64-v8a-signed.apk
APK sha256: 80b0b7f205251134ad81e0bbbe130410aa087c7f5e9488dac384e2b07f533891
APK for armeabi-v7a:
Download D229-armeabi-v7a-signed.apk
APK sha256: 9f7d97836cd7e943f7b6fb62e5f7e8b7a179bb37c5826c8ce43a6c506f108596
APK for universal:
Download D229-universal-signed.apk
APK sha256: ffcf842c56c1415b21919c0911bcc48e6e676e9061e59df05d6d89e41c7a49d6
APK for x86:
Download D229-x86-signed.apk
APK sha256: d78d35b768f1521ec00add339b050c5aa99048beff78cdd2732b5b22467d81f0
APK for x86_64:
Download D229-x86_64-signed.apk
APK sha256: 416fe0fe0b8bed3bfd01dd8d32d1516dc2c36e56c5d6ca34fc037ebed631020c
Comment Actions
Sharing non-blocking comment
| app/src/main/java/it/reyboz/bustorino/backend/Passaggio.kt | ||
|---|---|---|
| 160–188 | In general I personally suggest to "throw in case of problems" instead of "return null in case of problems". I'm aware of the consequences so feel free to ignore me lol | |
Comment Actions
Yes I know, I was respecting the old logic by @lvps - it was old Java but classic one.