Project Tags

Referenced Files

	F13305791: D237.1778735274.diff
	Wed, May 13, 07:07

	F13304162: D237.1778675217.diff
	Tue, May 12, 14:26

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

Libre BusTO hackers

Maniphest Tasks

T1378: Fix the Map not updating the user position

Commits

R4:0c3ca0d59051: Rewrite Map fragment location code to follow user and enable tracking

Summary

Add GPL notice to files

Fix map location enabled

Show alert when no location is granted

Receive first location correctly

Enable the position initally in the MapFragment only when the distance from the center of Turin is < 90 km

Enable the position initially in the LineDetailsFragment only when the distance from the center of the view is < 20 km

Create new FusedLocationProvider so that it works in Xiaomi phones, too

Create permission singleton to cache the number of times we've asked for the location

Fix T1378

Test Plan

Open the map screen, check that the position is visible and it is updated
Open the line screen:
- Check that disabling and enabling the position works
Check that when the map screens are closed, the app stops using the location
Check that from far away the position is queried once (or no times) and immediately disabled
Check that when setting the location permission on "Ask every time" the app actually asks for the location

Diff Detail

Repository

R4 Libre BusTO

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Fri, May 8, 18:18

Restricted Application added a project: Libre BusTO. · View Herald TranscriptFri, May 8, 18:18

Restricted Application added a reviewer: Libre BusTO hackers. · View Herald Transcript

Restricted Application added a subscriber: valerio.bozzolan. · View Herald Transcript

Delete old convoluted code

Harbormaster failed remote builds in B860: Diff 731!Fri, May 8, 18:22

fabio.mazza edited the summary of this revision. (Show Details)Fri, May 8, 18:24

fabio.mazza added a task: T1378: Fix the Map not updating the user position.

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D237-arm64-v8a-signed.apk
sha256: 947af98a7a7448e2ceea5285cc1901506d967153b76cbbc2cb0afa0e9c1b6664

APK for armeabi-v7a: D237-armeabi-v7a-signed.apk
sha256: 7fd660a5fe82a17d9e2ec2965ed6f45a8fd28704b48f29d7e23f62b1c9deedeb

APK for universal: D237-universal-signed.apk
sha256: 30fa80723895793af1c56081233f98987be6a370319343d3c8a57f7a884357a5

APK for x86: D237-x86-signed.apk
sha256: 7f86ac08817d52d6d1dfb3f96113b1548a8c1802852a941d0faeed7d23d33c97

APK for x86_64: D237-x86_64-signed.apk
sha256: d5fb4b18e9ffa93cfd00302cd4bdb025899da08ac8cfde9724c9cb25a395616d

Harbormaster completed remote builds in B861: Diff 732.Fri, May 8, 18:27

fabio.mazza requested review of this revision.Fri, May 8, 18:27

Move LinesDetailFragment.kt to new code

Still needs some checking:
setting the permissions as "ask every time" actually makes the app think that the location is denied, while it just needs to ask it

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D237-arm64-v8a-signed.apk
sha256: c046481a63d2a3836e817ade89ff1b264f0564c137f40243e35450a594ffff15

APK for armeabi-v7a: D237-armeabi-v7a-signed.apk
sha256: e7cec9e5aecbea161f20156000943c95504adf59ae9a15e6b5923fa3c43d227b

APK for universal: D237-universal-signed.apk
sha256: 524951cea02b5d5dbba120b13631c23a23a9d2ed1e8399d16b8d5ff0e4f4f55f

APK for x86: D237-x86-signed.apk
sha256: 41a1a8630c876dccbb583aca6665dd909f1e9481b59a96810ee6c28e160a6f9c

APK for x86_64: D237-x86_64-signed.apk
sha256: 53ae17585646595e406fd852712d2a2aa98dc8842a2788a60addb4dd56153ef8

Harbormaster completed remote builds in B862: Diff 733.Fri, May 8, 18:56

Create new location engine
Remove last location request, play with concurrency

Less log

Harbormaster failed remote builds in B863: Diff 734!Sat, May 9, 00:49

fabio.mazza edited the summary of this revision. (Show Details)Sat, May 9, 00:52

fabio.mazza edited the summary of this revision. (Show Details)

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D237-arm64-v8a-signed.apk
sha256: 03f444da0a24b489bc37815b51349edb70538edda937c183b0b0498b6aa16906

APK for armeabi-v7a: D237-armeabi-v7a-signed.apk
sha256: d6cefda7843e1795e3d5cd79ea6b881003db79badea18b965d3e08d94a01f6e3

APK for universal: D237-universal-signed.apk
sha256: ea6be2ab0de26c4a1b9ea8fa77c64d1809c8c9604d4c48f9e195d064e9ff8fb2

APK for x86: D237-x86-signed.apk
sha256: 2bdec36374e623393fa0541e9ebca5b0a0b3c2d2525ae7b6f94b4cb21e5bada4

APK for x86_64: D237-x86_64-signed.apk
sha256: f4a4a69913162eaf5fc55a721624ddfce0277fb6decfdfdbe1043d16edf44546

Harbormaster completed remote builds in B864: Diff 735.Sat, May 9, 00:56

I freaking love the new bearing

This revision is now accepted and ready to land.Sat, May 9, 09:26

Put distance limit back in showing the position
Show warning in Lines Fragment too
Fix mistake, show toast only once
enable the location only when I get the first fix

This revision now requires review to proceed.Sat, May 9, 14:18

fabio.mazza edited the summary of this revision. (Show Details)Sat, May 9, 14:20

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D237-arm64-v8a-signed.apk
sha256: c85e0e286b66ba3eb018ed5d4a7f078d4ad97c6dc78946ca7e341fba01c7af0a

APK for armeabi-v7a: D237-armeabi-v7a-signed.apk
sha256: 36734dae1d484ecb21eab4f86d9f887a7eaefcc12a5b92f6bc0ef21133f8eeb5

APK for universal: D237-universal-signed.apk
sha256: 5595f226c92aaac1ab1ea180cf41e39a0b1734086e1fe68e11158391cca9ba51

APK for x86: D237-x86-signed.apk
sha256: e7680aeb9ffb3cde5456346fc7981baf40ff504040d81d790594f3c6c6edaa06

APK for x86_64: D237-x86_64-signed.apk
sha256: 4a7ea9a6edf0b6bb4599d4065b4c9c14e518d48456d8ea8c8b26e19f8f189914

Harbormaster completed remote builds in B865: Diff 736.Sat, May 9, 14:25

Rename .java to .kt
Make request of permission work
Use LiveData
Fix position remaining active from Line fragment
Revert maplibre update

fabio.mazza edited the test plan for this revision. (Show Details)Sat, May 9, 16:58

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D237-arm64-v8a-signed.apk
sha256: 5bc2b31c2eb0fe590d635c75b9ba48303f8001edca7919f713dad77e1ed0db7c

APK for armeabi-v7a: D237-armeabi-v7a-signed.apk
sha256: 2a883d089e57ec87524dfa650ac33e7fbbef5cffba6b3aff7947bfb3715be728

APK for universal: D237-universal-signed.apk
sha256: 4e5153d608c0c90504cc880e75b9afaf312e41fccefa1a536969a7409a820d0a

APK for x86: D237-x86-signed.apk
sha256: e2348f1b45a8b2eadc1822cae1130e02d1bc571f572e885d3a5aa1ed183bcf0e

APK for x86_64: D237-x86_64-signed.apk
sha256: dd4f2ef361adc38b041cdc9968bad0fa42802e75ead9a8366ebbc1ff8e7038e3

Harbormaster completed remote builds in B866: Diff 737.Sat, May 9, 16:58

fabio.mazza edited the test plan for this revision. (Show Details)Sat, May 9, 16:59

fabio.mazza edited the summary of this revision. (Show Details)

fabio.mazza edited the test plan for this revision. (Show Details)

Ask at most 4 times over the whole cycle

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D237-arm64-v8a-signed.apk
sha256: 4825d1015bf149a8ef7361d99c5874e38f6be175343b9549391bf3dd277a6748

APK for armeabi-v7a: D237-armeabi-v7a-signed.apk
sha256: a3934e57074aa5abaf440fa0e6995cb83f0fe72c42610f2cc49efc652f041a69

APK for universal: D237-universal-signed.apk
sha256: f2ef8545473c107b3af969a350750df3000d93096625d82f471b7749444f77c7

APK for x86: D237-x86-signed.apk
sha256: 5ef7f053d14e22a1893ca7f4234f66cd6007a0bb9b8a4e42bf6df925ac332d52

APK for x86_64: D237-x86_64-signed.apk
sha256: fe433f82ec478b8634ed6efc1afb13e3b8e9c10bc4accd5cadd17c8465fd0d45

Harbormaster completed remote builds in B867: Diff 738.Sat, May 9, 17:06

In D237#5054, @valerio.bozzolan wrote:

I freaking love the new bearing

Still true lol

This revision is now accepted and ready to land.Sat, May 9, 17:08

Activate the icon while we are looking for the position

This revision now requires review to proceed.Sat, May 9, 17:14

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D237-arm64-v8a-signed.apk
sha256: d49da2be256135a8470fbbba373bb282030f2b3531feccd20adae21c8b2b8796

APK for armeabi-v7a: D237-armeabi-v7a-signed.apk
sha256: 7459eaed13e7b89cdfb26a2002e2d21c8c90e74f260b067ace37772996262df1

APK for universal: D237-universal-signed.apk
sha256: 1d08ae82e3468a35041537713b7d98fb7240bc6cb80c9f72fc478b8df2f96565

APK for x86: D237-x86-signed.apk
sha256: c477b52b7bc07871d20f411e7bc7242906791f23b0b8cf9cd7bb1f5d60fec3d4

APK for x86_64: D237-x86_64-signed.apk
sha256: 2f3ebf677f3975ae638fba07a14f11f17c45c6c39d6546384a4d23e064803aef

Harbormaster completed remote builds in B868: Diff 739.Sat, May 9, 17:19

In D237#5078, @valerio.bozzolan wrote:

In D237#5054, @valerio.bozzolan wrote:

I freaking love the new bearing

Still true lol

Stiiill true lol

This revision is now accepted and ready to land.Sat, May 9, 21:56

Last final fix

This revision now requires review to proceed.Sat, May 9, 22:34

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D237-arm64-v8a-signed.apk
sha256: c9c6284fa00250dc73ab20c775e2a065ff4767a7b94c5db57c15d0f5e0f9ab30

APK for armeabi-v7a: D237-armeabi-v7a-signed.apk
sha256: 0c55137f8bf366e6b24be14b2d315931c33aa5349c6bfc33e240401d75ed4fb6

APK for universal: D237-universal-signed.apk
sha256: 120bc3665b4d5786dd82671e4d54e5f086f3603cc0c31d0639a8b586604b07a5

APK for x86: D237-x86-signed.apk
sha256: cfc622297598f255ca3265dc324872ad7e968d8112396be2ac4f4c36b647c7de

APK for x86_64: D237-x86_64-signed.apk
sha256: 2dd6b6c9e96d67ba9b4ba0e4f1bb44439f61badedefbf211a124c66317042136

Harbormaster completed remote builds in B869: Diff 740.Sat, May 9, 22:38

Last real final fix

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D237-arm64-v8a-signed.apk
sha256: a197d79fd50a61529f16205305b8d80f9e86174067f85ec8268e913c7b325840

APK for armeabi-v7a: D237-armeabi-v7a-signed.apk
sha256: e5a1858ca5cae562dfc8168df11e4182dbe46559ad6aa469cd5759fd05ca8ffa

APK for universal: D237-universal-signed.apk
sha256: 2ef84ff8b9d14563cd0acbc3a1a9380de72ba692707a57fe9e5578d182f0e25e

APK for x86: D237-x86-signed.apk
sha256: 8a16aa8ebe6f7e146146b1e065dfe7e6b1af9a1effe6e553af5019873aedd209

APK for x86_64: D237-x86_64-signed.apk
sha256: d3a238cb89858484b4ed9d4037c135307f8eae29d05fea7bf5f3cd45c27a344c

Harbormaster completed remote builds in B870: Diff 741.Sat, May 9, 22:56

I can reproduce the "ask every time". But I need to kill the app to really close it and see the OS asking it again.

Works really well. I've found a crash while badly interacting with the map, but again, I expect nobody will press undo 100000 times lol.

This revision is now accepted and ready to land.Sun, May 10, 19:35

Closed by commit R4:0c3ca0d59051: Rewrite Map fragment location code to follow user and enable tracking. · Explain WhySun, May 10, 22:47

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:0c3ca0d59051: Rewrite Map fragment location code to follow user and enable tracking.

Rewrite Map fragment location code to follow user and enable tracking
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 742

app/src/main/java/it/reyboz/bustorino/fragments/AlertsDialogFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/AlertsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/BackupImportFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/IntroFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LivePositionsDialogFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

app/src/main/java/it/reyboz/bustorino/map/MapLibreLocationEngine.kt

app/src/main/java/it/reyboz/bustorino/middleware/AppLocationManager.kt

app/src/main/java/it/reyboz/bustorino/middleware/FusedNativeLocationProvider.kt

app/src/main/java/it/reyboz/bustorino/util/Permissions.java

app/src/main/java/it/reyboz/bustorino/util/Permissions.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/MapStateViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/NearbyStopsViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/ServiceAlertsViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/StopsMapViewModel.kt

app/src/main/res/values/strings.xml

Rewrite Map fragment location code to follow user and enable trackingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 742

app/src/main/java/it/reyboz/bustorino/fragments/AlertsDialogFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/AlertsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/BackupImportFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/GeneralMapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/IntroFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LinesDetailFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/LivePositionsDialogFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/MapLibreFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

app/src/main/java/it/reyboz/bustorino/map/MapLibreLocationEngine.kt

app/src/main/java/it/reyboz/bustorino/middleware/AppLocationManager.kt

app/src/main/java/it/reyboz/bustorino/middleware/FusedNativeLocationProvider.kt

app/src/main/java/it/reyboz/bustorino/util/Permissions.java

app/src/main/java/it/reyboz/bustorino/util/Permissions.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/ArrivalsViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/MapStateViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/NearbyStopsViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/ServiceAlertsViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/StopsMapViewModel.kt

app/src/main/res/values/strings.xml

Rewrite Map fragment location code to follow user and enable tracking
ClosedPublic
Actions

Revision Contents
Changeset List