Paths

Table of Contentst

Add initial home fragment
AcceptedPublic
Actions

Authored by fabio.mazza on Mon, May 18, 20:24.

Project Tags

Referenced Files

	F13339310: Screenshot_20260519-212118_BusTO git.png
	Tue, May 19, 21:21

	F13330972: Screenshot_20260518-225425_BusTO git.png
	Mon, May 18, 22:56

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

Libre BusTO hackers

Summary

Clear unused imports

Simplify logic of FragmentHelper

Overload methods of arrivalsFragment

Complete showing menu activity

Complete transitions, first usable version

Diff Detail

Repository

R4 Libre BusTO

Branch

newwork

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 901
Build 1320: BusTO Build Plan
Build 1319: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Mon, May 18, 20:24

Restricted Application added a project: Libre BusTO. · View Herald TranscriptMon, May 18, 20:24

Restricted Application added a reviewer: Libre BusTO hackers. · View Herald Transcript

Restricted Application added a subscriber: valerio.bozzolan. · View Herald Transcript

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D243-arm64-v8a-signed.apk
sha256: b51698e11cfa7a1e26e7332fd208994c77e7f1f5c1aa52816bb05b3a03ff3edc

APK for armeabi-v7a: D243-armeabi-v7a-signed.apk
sha256: 2cb5c4b153d35a546dcf06dfb2dc3be903fd93253cd513a74fc2f08eee1b7f38

APK for universal: D243-universal-signed.apk
sha256: ac8f7f13918812439eaedba6974246e674d83f275e075786f56fc1d0707455f5

APK for x86: D243-x86-signed.apk
sha256: 364a4ae111cd5f345b3f262418092675f82b535145cb7e279128b5264579b282

APK for x86_64: D243-x86_64-signed.apk
sha256: f5c31ee2405f9a1b92a4c3b118d66f633b6502065a24ff6ad2da7f51c109edc3

Harbormaster completed remote builds in B897: Diff 762.Mon, May 18, 20:30

fabio.mazza requested review of this revision.Mon, May 18, 20:30

Fix style not a descendant of MaterialComponents

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D243-arm64-v8a-signed.apk
sha256: 830f94888b4ca7f4d677996d9caa7f36cb2f18abf4d73e889ad1af746a757eec

APK for armeabi-v7a: D243-armeabi-v7a-signed.apk
sha256: 99c970592ecb3ed01a709313a6a849df31dcc2314ab8b9efb5dea0a8fbcff29f

APK for universal: D243-universal-signed.apk
sha256: ce77bc954c0534772f3accbdfde7bb23eebaac98842c9e78379d4fd1a32815e0

APK for x86: D243-x86-signed.apk
sha256: c7a5ba338956a58017d1e8248eba23718ba2b489efd42ec9fdeb17613c36ce61

APK for x86_64: D243-x86_64-signed.apk
sha256: 59295f65900d6d448e46d60e16a71fdff2f070772545f86a9fbb8fa8b641475b

Harbormaster completed remote builds in B898: Diff 763.Mon, May 18, 21:30

I LOVE THIS!!! still a bit bugged 😻

Screenshot_20260518-225425_BusTO git.png (1,224×2,700 px, 148 KB)

Steps to reproduce:

Tap Favorites
Tap 1 favorite
Tap menu Lines
Tap menu Arrivals again

This revision now requires changes to proceed.Mon, May 18, 22:56

Fix crash - constructor has to be public

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D243-arm64-v8a-signed.apk
sha256: a08f0e2a259333ff5103470a3f17cad37823b17928e48050da22a46c72864943

APK for armeabi-v7a: D243-armeabi-v7a-signed.apk
sha256: 02480e84d07d408336ac824f52766684603486b5f90238efd9f91380813b05b7

APK for universal: D243-universal-signed.apk
sha256: 9c20776fc392a7062a012a3a21b6b06e86ed21fb9dcc406064ba4bccb41a2845

APK for x86: D243-x86-signed.apk
sha256: ddc8036adcc112cb247365498d2f7f7417a90aa4e96660dc2281c6ae11c15c36

APK for x86_64: D243-x86_64-signed.apk
sha256: 6d8ae023e01217ddaff7f0ac410e01d131feee5be173faefb8b4eade55702e41

Harbormaster completed remote builds in B900: Diff 764.Tue, May 19, 18:32

In D243#5270, @valerio.bozzolan wrote:

I LOVE THIS!!! still a bit bugged 😻

Steps to reproduce:

Tap Favorites

Tap 1 favorite

Tap menu Lines

Tap menu Arrivals again

Same bug :3

This revision now requires changes to proceed.Tue, May 19, 18:54

Create new way to init the MainScreenFragment
Cleanup permission request code
Fix QR code scan not working by removing unneeded gating
Add QR Scan button
Replace layout with ConstraintLayout

Bip bop I'm a bot. Here fresh Android builds

APK for arm64-v8a: D243-arm64-v8a-signed.apk
sha256: 35520b1ffcfabd17d6ce9c791c11b6b2c62790db008238d2829d4694e8e1e5d3

APK for armeabi-v7a: D243-armeabi-v7a-signed.apk
sha256: b5e6fbbd2de22175488bba68606ada12c7d53307bff9bd0a9d95ff4e5950a556

APK for universal: D243-universal-signed.apk
sha256: c6d37ac5093f59b13773614641324ffa19e2c16ce48c0f1b1d0a3df11fcb442b

APK for x86: D243-x86-signed.apk
sha256: 1de2ef61fd81d3134a93dc4fea5a1196c4db1bbf9fb13f70061d1454bd640b6f

APK for x86_64: D243-x86_64-signed.apk
sha256: 4dbc893dc7a5cfdf82cc768dfd03e4033e4cec382ce4666f1cd27dcc144a0042

Harbormaster completed remote builds in B901: Diff 765.Tue, May 19, 20:48

valerio.bozzolan added inline comments.Tue, May 19, 21:21

app/src/main/res/values/strings.xml
54	Just "Scan QRCode" (shorter) So the box is smaller :)

valerio.bozzolan attached a referenced file: F13339310: Screenshot_20260519-212118_BusTO git.png. (Show Details)Tue, May 19, 21:21

tested QRcode
tested lines
tested map
tested back button
tested favorites, add, remove

FUCKING LOVE IT LOL

Macro yesyes:

This revision is now accepted and ready to land.Tue, May 19, 21:25

Revision Contents
Changeset List

Path

Size

app/

src/

main/

java/

it/

reyboz/

bustorino/

ActivityExperiments.java

lines

ActivityPrincipal.java

lines

fragments/

ArrivalsFragment.kt

lines

BarcodeFragment.kt

lines

ButtonsFragment.kt

lines

CommonFragmentListener.java

lines

FragmentHelper.java

lines

MainScreenFragment.java

lines

ScreenBaseFragment.java

lines

middleware/

StopSearcher.kt

lines

viewmodels/

FavoritesViewModel.kt

lines

IntroViewModel.kt

lines

LinesViewModel.kt

lines

res/

drawable-hdpi/

drawable-mdpi/

drawable-xhdpi/

drawable-xxhdpi/

drawable-xxxhdpi/

drawable/

lines

lines

ic_star_filled_white.xml

lines

qr_code_scan.xml

lines

layout/

fragment_buttons.xml

lines

fragment_main_screen.xml

lines

item_card_button.xml

lines

values-it/

strings.xml

line

values-v35/

styles.xml

lines

values/

strings.xml

lines

Diff 765

View Options

app/src/main/java/it/reyboz/bustorino/ActivityExperiments.java

View Options

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/BarcodeFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ButtonsFragment.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/CommonFragmentListener.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/FragmentHelper.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/middleware/StopSearcher.kt

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/FavoritesViewModel.kt

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/IntroViewModel.kt

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/LinesViewModel.kt

View Options

app/src/main/res/drawable-hdpi/ic_star.png

View Options

app/src/main/res/drawable-mdpi/ic_star.png

View Options

app/src/main/res/drawable-xhdpi/ic_star.png

View Options

app/src/main/res/drawable-xxhdpi/ic_star.png

View Options

app/src/main/res/drawable-xxxhdpi/ic_star.png

View Options

app/src/main/res/drawable/compass_3_fill.xml

View Options

app/src/main/res/drawable/ic_moving_emph.xml

View Options

app/src/main/res/drawable/ic_star_filled_white.xml

View Options

app/src/main/res/drawable/qr_code_scan.xml

View Options

app/src/main/res/layout/fragment_buttons.xml

View Options

app/src/main/res/layout/fragment_main_screen.xml

View Options

app/src/main/res/layout/item_card_button.xml

View Options

app/src/main/res/values-it/strings.xml

View Options

app/src/main/res/values-v35/styles.xml

View Options

app/src/main/res/values/strings.xml

Add initial home fragmentAcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 765

app/src/main/java/it/reyboz/bustorino/ActivityExperiments.java

app/src/main/java/it/reyboz/bustorino/ActivityPrincipal.java

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/BarcodeFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/ButtonsFragment.kt

app/src/main/java/it/reyboz/bustorino/fragments/CommonFragmentListener.java

app/src/main/java/it/reyboz/bustorino/fragments/FragmentHelper.java

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

app/src/main/java/it/reyboz/bustorino/middleware/StopSearcher.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/FavoritesViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/IntroViewModel.kt

app/src/main/java/it/reyboz/bustorino/viewmodels/LinesViewModel.kt

app/src/main/res/drawable-hdpi/ic_star.png

app/src/main/res/drawable-mdpi/ic_star.png

app/src/main/res/drawable-xhdpi/ic_star.png

app/src/main/res/drawable-xxhdpi/ic_star.png

app/src/main/res/drawable-xxxhdpi/ic_star.png

app/src/main/res/drawable/compass_3_fill.xml

app/src/main/res/drawable/ic_moving_emph.xml

app/src/main/res/drawable/ic_star_filled_white.xml

app/src/main/res/drawable/qr_code_scan.xml

app/src/main/res/layout/fragment_buttons.xml

app/src/main/res/layout/fragment_main_screen.xml

app/src/main/res/layout/item_card_button.xml

app/src/main/res/values-it/strings.xml

app/src/main/res/values-v35/styles.xml

app/src/main/res/values/strings.xml

Add initial home fragment
AcceptedPublic
Actions

Revision Contents
Changeset List