Fix no display bug
ClosedPublic
Actions

Authored by fabio.mazza on Jul 9 2021, 18:04.

Details

Reviewers

Maniphest Tasks

T890: Fix crash caused by IllegalStateException: FragmentManager has been destroyed (AsyncDataDownload.java:212)
T891: Api response parsing error in FiveTAPIFetcher.java:96 on version 1.15.2

Commits

R4:07aba5f76428: Fix no display bug

Summary

Rename Fetcher.Result and fix the no shown arrivals

Fix FiveTAPIFetcher

Parse new type of responses from FiveTAPIFetcher

Add code for printing better output

Test Plan

Check that the bug is gone and you can see the arrivals

Diff Detail

Repository

R4 Libre BusTO

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Jul 9 2021, 18:04

Restricted Application added a project: Libre BusTO . · View Herald TranscriptJul 9 2021, 18:04

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript

Be bop be bop. I'm a bot. Builded:

→ D62-libre-busto-unsigned.apk

Harbormaster completed remote builds in B239: Diff 204.Jul 9 2021, 18:06

fabio.mazza requested review of this revision.Jul 9 2021, 18:06

Check if fragment manager is destroyed before committing

Be bop be bop. I'm a bot. Builded:

→ D62-libre-busto-unsigned.apk

Harbormaster completed remote builds in B240: Diff 205.Jul 9 2021, 18:20

fabio.mazza added a task: T891: Api response parsing error in FiveTAPIFetcher.java:96 on version 1.15.2.Jul 9 2021, 18:20

fabio.mazza added a task: T890: Fix crash caused by IllegalStateException: FragmentManager has been destroyed (AsyncDataDownload.java:212).

sgtm

This revision is now accepted and ready to land.Jul 9 2021, 20:46

Closed by commit R4:07aba5f76428: Fix no display bug. · Explain WhyJul 10 2021, 02:22

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:07aba5f76428: Fix no display bug.

Revision Contents
Changeset List

Path

Size

src/

it/

reyboz/

bustorino/

adapters/

PalinaAdapter.java

1 line

backend/

ArrivalsFetcher.java

6 lines

Fetcher.java

2 lines

FiveTAPIFetcher.java

91 lines

FiveTAPIVolleyRequest.java

6 lines

FiveTScraperFetcher.java

18 lines

FiveTStopsFetcher.java

10 lines

GTTJSONFetcher.java

14 lines

GTTStopsFetcher.java

20 lines

StopsFinderByName.java

2 lines

StopsFinderByRoute.java

2 lines

networkTools.java

18 lines

utils.java

20 lines

data/

DBUpdateWorker.java

12 lines

DatabaseUpdate.java

12 lines

DatabaseUpdateService.java

10 lines

fragments/

ArrivalsFragment.java

6 lines

FragmentHelper.java

5 lines

MainScreenFragment.java

1 line

middleware/

AsyncDataDownload.java

65 lines

Diff 206

View Options

src/it/reyboz/bustorino/adapters/PalinaAdapter.java

View Options

src/it/reyboz/bustorino/backend/ArrivalsFetcher.java

View Options

src/it/reyboz/bustorino/backend/Fetcher.java

View Options

src/it/reyboz/bustorino/backend/FiveTAPIFetcher.java

View Options

src/it/reyboz/bustorino/backend/FiveTAPIVolleyRequest.java

View Options

src/it/reyboz/bustorino/backend/FiveTScraperFetcher.java

View Options

src/it/reyboz/bustorino/backend/FiveTStopsFetcher.java

View Options

src/it/reyboz/bustorino/backend/GTTJSONFetcher.java

View Options

src/it/reyboz/bustorino/backend/GTTStopsFetcher.java

View Options

src/it/reyboz/bustorino/backend/StopsFinderByName.java

View Options

src/it/reyboz/bustorino/backend/StopsFinderByRoute.java

View Options

src/it/reyboz/bustorino/backend/networkTools.java

View Options

src/it/reyboz/bustorino/backend/utils.java

View Options

src/it/reyboz/bustorino/data/DBUpdateWorker.java

View Options

src/it/reyboz/bustorino/data/DatabaseUpdate.java

View Options

src/it/reyboz/bustorino/data/DatabaseUpdateService.java

View Options

src/it/reyboz/bustorino/fragments/ArrivalsFragment.java

View Options

src/it/reyboz/bustorino/fragments/FragmentHelper.java

View Options

src/it/reyboz/bustorino/fragments/MainScreenFragment.java

View Options

src/it/reyboz/bustorino/middleware/AsyncDataDownload.java

Fix no display bugClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 206

src/it/reyboz/bustorino/adapters/PalinaAdapter.java

src/it/reyboz/bustorino/backend/ArrivalsFetcher.java

src/it/reyboz/bustorino/backend/Fetcher.java

src/it/reyboz/bustorino/backend/FiveTAPIFetcher.java

src/it/reyboz/bustorino/backend/FiveTAPIVolleyRequest.java

src/it/reyboz/bustorino/backend/FiveTScraperFetcher.java

src/it/reyboz/bustorino/backend/FiveTStopsFetcher.java

src/it/reyboz/bustorino/backend/GTTJSONFetcher.java

src/it/reyboz/bustorino/backend/GTTStopsFetcher.java

src/it/reyboz/bustorino/backend/StopsFinderByName.java

src/it/reyboz/bustorino/backend/StopsFinderByRoute.java

src/it/reyboz/bustorino/backend/networkTools.java

src/it/reyboz/bustorino/backend/utils.java

src/it/reyboz/bustorino/data/DBUpdateWorker.java

src/it/reyboz/bustorino/data/DatabaseUpdate.java

src/it/reyboz/bustorino/data/DatabaseUpdateService.java

src/it/reyboz/bustorino/fragments/ArrivalsFragment.java

src/it/reyboz/bustorino/fragments/FragmentHelper.java

src/it/reyboz/bustorino/fragments/MainScreenFragment.java

src/it/reyboz/bustorino/middleware/AsyncDataDownload.java

Fix no display bug
ClosedPublic
Actions

Revision Contents
Changeset List