Page MenuHomeGitPull.it
Differential D62

Fix no display bug
ClosedPublic
Actions

Authored by fabio.mazza on Jul 9 2021, 18:04.
Tags
Referenced Files
F2099945: D62.diff
Sat, Apr 20, 07:44
Unknown Object (File)
Thu, Apr 18, 13:00
Unknown Object (File)
Thu, Apr 18, 12:59
Unknown Object (File)
Thu, Apr 18, 12:59
Unknown Object (File)
Thu, Apr 18, 12:59
Unknown Object (File)
Mon, Apr 15, 16:22
Unknown Object (File)
Sun, Apr 14, 10:39
Unknown Object (File)
Sun, Apr 14, 01:21
View All Files
Subscribers
valerio.bozzolan
Libre BusTO

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
T890: Fix crash caused by IllegalStateException: FragmentManager has been destroyed (AsyncDataDownload.java:212)
T891: Api response parsing error in FiveTAPIFetcher.java:96 on version 1.15.2
Commits
R4:07aba5f76428: Fix no display bug
Summary

Rename Fetcher.Result and fix the no shown arrivals

Fix FiveTAPIFetcher

Parse new type of responses from FiveTAPIFetcher

Add code for printing better output

Test Plan

Check that the bug is gone and you can see the arrivals

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 239
Build 318: BusTO Build Plan
Build 317: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Jul 9 2021, 18:04
Restricted Application added a project: Libre BusTO . · View Herald TranscriptJul 9 2021, 18:04
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.Jul 9 2021, 18:06

Be bop be bop. I'm a bot. Builded:

→ D62-libre-busto-unsigned.apk

Harbormaster completed remote builds in B239: Diff 204.Jul 9 2021, 18:06
fabio.mazza requested review of this revision.Jul 9 2021, 18:06
fabio.mazza updated this revision to Diff 205.Jul 9 2021, 18:19
  • Check if fragment manager is destroyed before committing
gitpull.android.builder added a comment.Jul 9 2021, 18:20

Be bop be bop. I'm a bot. Builded:

→ D62-libre-busto-unsigned.apk

Harbormaster completed remote builds in B240: Diff 205.Jul 9 2021, 18:20
fabio.mazza added a task: T891: Api response parsing error in FiveTAPIFetcher.java:96 on version 1.15.2.Jul 9 2021, 18:20
fabio.mazza added a task: T890: Fix crash caused by IllegalStateException: FragmentManager has been destroyed (AsyncDataDownload.java:212).
valerio.bozzolan accepted this revision.EditedJul 9 2021, 20:46

sgtm

asd

This revision is now accepted and ready to land.Jul 9 2021, 20:46
Closed by commit R4:07aba5f76428: Fix no display bug. · Explain WhyJul 10 2021, 02:22
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:07aba5f76428: Fix no display bug.

Revision Contents
Changeset List

Diff 204

View Options

src/it/reyboz/bustorino/adapters/PalinaAdapter.java

Loading...
View Options

src/it/reyboz/bustorino/backend/ArrivalsFetcher.java

Loading...
View Options

src/it/reyboz/bustorino/backend/Fetcher.java

Loading...
View Options

src/it/reyboz/bustorino/backend/FiveTAPIFetcher.java

Loading...
View Options

src/it/reyboz/bustorino/backend/FiveTAPIVolleyRequest.java

Loading...
View Options

src/it/reyboz/bustorino/backend/FiveTScraperFetcher.java

Loading...
View Options

src/it/reyboz/bustorino/backend/FiveTStopsFetcher.java

Loading...
View Options

src/it/reyboz/bustorino/backend/GTTJSONFetcher.java

Loading...
View Options

src/it/reyboz/bustorino/backend/GTTStopsFetcher.java

Loading...
View Options

src/it/reyboz/bustorino/backend/StopsFinderByName.java

Loading...
View Options

src/it/reyboz/bustorino/backend/StopsFinderByRoute.java

Loading...
View Options

src/it/reyboz/bustorino/backend/networkTools.java

Loading...
View Options

src/it/reyboz/bustorino/backend/utils.java

Loading...
View Options

src/it/reyboz/bustorino/data/DBUpdateWorker.java

Loading...
View Options

src/it/reyboz/bustorino/data/DatabaseUpdate.java

Loading...
View Options

src/it/reyboz/bustorino/data/DatabaseUpdateService.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/ArrivalsFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/FragmentHelper.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/MainScreenFragment.java

Loading...
View Options

src/it/reyboz/bustorino/middleware/AsyncDataDownload.java

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register