Page MenuHomeGitPull.it
Differential D77

UI improvements
ClosedPublic
Actions

Authored by fabio.mazza on Jan 5 2022, 18:23.
Tags
Referenced Files
F2099582: D77.id271.diff
Sat, Apr 20, 01:08
F2098631: D77.diff
Fri, Apr 19, 10:31
Unknown Object (File)
Thu, Apr 18, 13:10
Unknown Object (File)
Thu, Apr 18, 13:09
Unknown Object (File)
Thu, Apr 18, 13:09
Unknown Object (File)
Thu, Apr 18, 13:09
Unknown Object (File)
Sun, Apr 14, 04:04
Unknown Object (File)
Sat, Apr 13, 03:23
View All Files
Subscribers
valerio.bozzolan
Libre BusTO

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
T899: [Error] Missing toast after invalid search
Commits
R4:212b5a3dffb3: UI improvements
Summary
  • Don't show fragment on empty stop search result
  • Use coordinator layout to avoid overlapping between Snackbar and buttons

Fix T899

Mitigation for T933

Test Plan

check it builds

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 300
Build 424: BusTO Build Plan
Build 423: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Jan 5 2022, 18:23
Restricted Application added a project: Libre BusTO . · View Herald TranscriptJan 5 2022, 18:23
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
fabio.mazza edited the summary of this revision. (Show Details)Jan 5 2022, 18:25
fabio.mazza added a task: T899: [Error] Missing toast after invalid search.
gitpull.android.builder added a comment.Jan 5 2022, 18:25

Be bop be bop. I'm a bot. Builded:

→ D77-libre-busto-unsigned.apk

Harbormaster completed remote builds in B299: Diff 271.Jan 5 2022, 18:25
fabio.mazza requested review of this revision.Jan 5 2022, 18:25
fabio.mazza updated this revision to Diff 272.Jan 5 2022, 19:38
  • Use coordinator layout to avoid overlapping between Snackbar and buttons
fabio.mazza retitled this revision from Don't show fragment on empty stop search result to UI improvements.Jan 5 2022, 19:40
fabio.mazza edited the summary of this revision. (Show Details)
fabio.mazza edited the summary of this revision. (Show Details)
gitpull.android.builder added a comment.Jan 5 2022, 19:40

Be bop be bop. I'm a bot. Builded:

→ D77-libre-busto-unsigned.apk

Harbormaster completed remote builds in B300: Diff 272.Jan 5 2022, 19:40
fabio.mazza edited the summary of this revision. (Show Details)Jan 5 2022, 19:41
valerio.bozzolan accepted this revision.Jan 9 2022, 16:52

sgtm

asd

This revision is now accepted and ready to land.Jan 9 2022, 16:52
Closed by commit R4:212b5a3dffb3: UI improvements. · Explain WhyJan 9 2022, 17:01
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:212b5a3dffb3: UI improvements.

Revision Contents
Changeset List

PathSize
1 line
res/
layout/
67 lines
src/
it/
reyboz/
bustorino/
21 lines
backend/
mato/
4 lines
fragments/
79 lines
18 lines
44 lines
ScreenBaseFragment.java
BaseFragment.java
12 lines
middleware/
2 lines

Diff 272

View Options

build.gradle

Loading...
View Options

res/layout/fragment_main_screen.xml

Loading...
View Options

src/it/reyboz/bustorino/ActivityPrincipal.java

Loading...
View Options

src/it/reyboz/bustorino/backend/mato/MatoAPIFetcher.kt

Loading...
View Options

src/it/reyboz/bustorino/fragments/BaseFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/FavoritesFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/MainScreenFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/MapFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

Loading...
View Options

src/it/reyboz/bustorino/middleware/AsyncStopsSearcher.java

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register