Page MenuHomeGitPull.it
Differential D83

Make new fragment for lines, use new MaTO API
ClosedPublic
Actions

Authored by fabio.mazza on Apr 19 2022, 19:20.

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
T12: Search by line number
Commits
R4:86d1f35a0336: Make new fragment for lines, use new MaTO API
Summary

Use new Mato API for nearby stops

Change a bit the nearby stops logic

Work on getting feeds

Download agencies on update

Download routes from MaTO

Stop trying to download old lines

Make table for patterns, start with downloading polylines and stops

Use low priority channel for the database notifications

Add code for patterns

Save patterns with stops in the DB

Add Migration and tests

Set limits for updates

Add database schemas

Test Plan

check it builds, download on the phone and look at the logcat to see that there aren't any errors

Diff Detail

Repository
R4 Libre BusTO
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fabio.mazza created this revision.Apr 19 2022, 19:20
Restricted Application added a project: Libre BusTO . · View Herald TranscriptApr 19 2022, 19:20
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.Apr 19 2022, 19:23

Be bop be bop. I'm a bot. Builded:

→ D83-libre-busto-unsigned.apk

Harbormaster completed remote builds in B313: Diff 287.Apr 19 2022, 19:23
fabio.mazza requested review of this revision.Apr 19 2022, 19:23
fabio.mazza updated this revision to Diff 288.Apr 29 2022, 20:16
  • Disable old test
  • Make new fragment
  • Experiment with LiveData and coroutines
  • Use LiveData
  • Show the lines nicely
  • Make stop with default gtfsID in constructor
  • Fix error and show finally the stops for the lines
  • Better parsing of Capitalized string into noncapitalized one
  • Use different layout for line shown
  • Reuse adapter, fix strings
  • Go back to the same fragment, finish up with strings
fabio.mazza updated this revision to Diff 289.Apr 29 2022, 20:17
  • Remove stupid file
gitpull.android.builder added a comment.Apr 29 2022, 20:20

Be bop be bop. I'm a bot. Builded:

→ D83-libre-busto-unsigned.apk

Harbormaster completed remote builds in B314: Diff 288.Apr 29 2022, 20:20
gitpull.android.builder added a comment.Apr 29 2022, 20:20

Be bop be bop. I'm a bot. Builded:

→ D83-libre-busto-unsigned.apk

Harbormaster completed remote builds in B315: Diff 289.Apr 29 2022, 20:20
fabio.mazza retitled this revision from Database overhaul, using Room and MaTO for the data source to Make new fragment for lines, use new MaTO API.Apr 29 2022, 20:22
valerio.bozzolan accepted this revision.Apr 30 2022, 01:29

That's awesome!

And it works.

asd

sgtm

Land.

This revision is now accepted and ready to land.Apr 30 2022, 01:29
Closed by commit R4:86d1f35a0336: Make new fragment for lines, use new MaTO API. · Explain WhyApr 30 2022, 08:23
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:86d1f35a0336: Make new fragment for lines, use new MaTO API.
valerio.bozzolan added a task: T12: Search by line number.Feb 7 2023, 23:15

Revision Contents
Changeset List

PathSize
assets/
schemas/
it.reyboz.bustorino.data.gtfs.GtfsDatabase/
464 lines
648 lines
38 lines
res/
drawable/
9 lines
9 lines
layout/
27 lines
96 lines
113 lines
103 lines
menu/
4 lines
9 lines
values-it/
22 lines
values/
1 line
17 lines
xml/
8 lines
src/
androidTest/
java/
it/
reyboz/
bustorino/
data/
gtfs/
53 lines
it/
reyboz/
bustorino/
57 lines
34 lines
adapters/
28 lines
44 lines
2 lines
StopAdapterListener.java
AdapterListener.java
4 lines
98 lines
backend/
3 lines
1 line
6 lines
38 lines
5 lines
gtfs/
48 lines
mato/
5 lines
4 lines
186 lines
76 lines
48 lines
120 lines
4 lines
53 lines
data/
4 lines
48 lines
305 lines
36 lines
103 lines
58 lines
gtfs/
27 lines
55 lines
GtfsDBDao.kt
StaticGtfsDao.kt
46 lines
42 lines
50 lines
19 lines
38 lines
140 lines
fragments/
18 lines
3 lines
3 lines
289 lines
77 lines
2 lines
239 lines
22 lines
middleware/
2 lines
util/
76 lines

Diff 290

View Options

assets/schemas/it.reyboz.bustorino.data.gtfs.GtfsDatabase/1.json

Loading...
View Options

assets/schemas/it.reyboz.bustorino.data.gtfs.GtfsDatabase/2.json

Loading...
View Options

build.gradle

Loading...
View Options

res/drawable/ic_moving.xml

Loading...
View Options

res/drawable/ic_moving_emph.xml

Loading...
View Options

res/layout/arrivals_nearby_card.xml

Loading...
View Options

res/layout/bus_stop_line_elmt.xml

Loading...
View Options

res/layout/entry_bus_stop.xml

Loading...
View Options

res/layout/fragment_lines.xml

Loading...
View Options

res/menu/drawer_main.xml

Loading...
View Options

res/menu/menu_line_item.xml

Loading...
View Options

res/values-it/strings.xml

Loading...
View Options

res/values/keys.xml

Loading...
View Options

res/values/strings.xml

Loading...
View Options

res/xml/preferences.xml

Loading...
View Options

src/androidTest/java/it/reyboz/bustorino/data/gtfs/GtfsDBMigrationsTest.java

Loading...
View Options

src/it/reyboz/bustorino/ActivityExperiments.java

Loading...
View Options

src/it/reyboz/bustorino/ActivityPrincipal.java

Loading...
View Options

src/it/reyboz/bustorino/adapters/AdapterListener.java

Loading...
View Options

src/it/reyboz/bustorino/adapters/ArrivalsStopAdapter.java

Loading...
View Options

src/it/reyboz/bustorino/adapters/NameCapitalize.java

Loading...
View Options

src/it/reyboz/bustorino/adapters/StopAdapter.java

Loading...
View Options

src/it/reyboz/bustorino/adapters/StopAdapterListener.java

Loading...
View Options

src/it/reyboz/bustorino/adapters/StopRecyclerAdapter.java

Loading...
View Options

src/it/reyboz/bustorino/backend/FiveTAPIFetcher.java

Loading...
View Options

src/it/reyboz/bustorino/backend/Notifications.java

Loading...
View Options

src/it/reyboz/bustorino/backend/Palina.java

Loading...
View Options

src/it/reyboz/bustorino/backend/Result.java

Loading...
View Options

src/it/reyboz/bustorino/backend/Stop.java

Loading...
View Options

src/it/reyboz/bustorino/backend/gtfs/PolylineParser.java

Loading...
View Options

src/it/reyboz/bustorino/backend/mato/MapiArrivalRequest.java

Loading...
View Options

src/it/reyboz/bustorino/backend/mato/MapiVolleyRequest.java

Loading...
View Options

src/it/reyboz/bustorino/backend/mato/MatoAPIFetcher.kt

Loading...
View Options

src/it/reyboz/bustorino/backend/mato/MatoQueries.kt

Loading...
View Options

src/it/reyboz/bustorino/backend/mato/MatoVolleyJSONRequest.kt

Loading...
View Options

src/it/reyboz/bustorino/backend/mato/ResponseParsing.kt

Loading...
View Options

src/it/reyboz/bustorino/backend/mato/VolleyAllStopsRequest.kt

Loading...
View Options

src/it/reyboz/bustorino/backend/utils.java

Loading...
View Options

src/it/reyboz/bustorino/data/AppDataProvider.java

Loading...
View Options

src/it/reyboz/bustorino/data/AppRepository.java

Loading...
View Options

src/it/reyboz/bustorino/data/DBUpdateWorker.java

Loading...
View Options

src/it/reyboz/bustorino/data/DatabaseUpdate.java

Loading...
View Options

src/it/reyboz/bustorino/data/GtfsRepository.kt

Loading...
View Options

src/it/reyboz/bustorino/data/NextGenDB.java

Loading...
View Options

src/it/reyboz/bustorino/data/OldDataRepository.java

Loading...
View Options

src/it/reyboz/bustorino/data/gtfs/CsvTableInserter.kt

Loading...
View Options

src/it/reyboz/bustorino/data/gtfs/GtfsAgency.kt

Loading...
View Options

src/it/reyboz/bustorino/data/gtfs/GtfsDBDao.kt

Loading...
View Options

src/it/reyboz/bustorino/data/gtfs/GtfsDatabase.kt

Loading...
View Options

src/it/reyboz/bustorino/data/gtfs/GtfsFeed.kt

Loading...
View Options

src/it/reyboz/bustorino/data/gtfs/GtfsMode.kt

Loading...
View Options

src/it/reyboz/bustorino/data/gtfs/GtfsRoute.kt

Loading...
View Options

src/it/reyboz/bustorino/data/gtfs/MatoPattern.kt

Loading...
View Options

src/it/reyboz/bustorino/data/gtfs/StaticGtfsDao.kt

Loading...
View Options

src/it/reyboz/bustorino/fragments/FavoritesFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/FragmentKind.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/FragmentListenerMain.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/LinesFragment.kt

Loading...
View Options

src/it/reyboz/bustorino/fragments/LinesViewModel.kt

Loading...
View Options

src/it/reyboz/bustorino/fragments/MapFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

Loading...
View Options

src/it/reyboz/bustorino/fragments/SettingsFragment.java

Loading...
View Options

src/it/reyboz/bustorino/middleware/AsyncArrivalsSearcher.java

Loading...
View Options

src/it/reyboz/bustorino/util/LinesNameSorter.java

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register