Differential D83

Make new fragment for lines, use new MaTO API
ClosedPublic
Actions

Authored by fabio.mazza on Apr 19 2022, 19:20.

Details

Reviewers

valerio.bozzolan

Maniphest Tasks

T12: Search by line number

Commits

R4:86d1f35a0336: Make new fragment for lines, use new MaTO API

Summary

Use new Mato API for nearby stops

Change a bit the nearby stops logic

Work on getting feeds

Download agencies on update

Download routes from MaTO

Stop trying to download old lines

Make table for patterns, start with downloading polylines and stops

Use low priority channel for the database notifications

Add code for patterns

Save patterns with stops in the DB

Add Migration and tests

Set limits for updates

Add database schemas

Test Plan

check it builds, download on the phone and look at the logcat to see that there aren't any errors

Diff Detail

Repository

R4 Libre BusTO

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 315
Build 448: BusTO Build Plan
Build 447: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Apr 19 2022, 19:20

Restricted Application added a project: Libre BusTO . · View Herald TranscriptApr 19 2022, 19:20

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript

Be bop be bop. I'm a bot. Builded:

→ D83-libre-busto-unsigned.apk

Harbormaster completed remote builds in B313: Diff 287.Apr 19 2022, 19:23

fabio.mazza requested review of this revision.Apr 19 2022, 19:23

Disable old test
Make new fragment
Experiment with LiveData and coroutines
Use LiveData
Show the lines nicely
Make stop with default gtfsID in constructor
Fix error and show finally the stops for the lines
Better parsing of Capitalized string into noncapitalized one
Use different layout for line shown
Reuse adapter, fix strings
Go back to the same fragment, finish up with strings

Remove stupid file

Be bop be bop. I'm a bot. Builded:

→ D83-libre-busto-unsigned.apk

Harbormaster completed remote builds in B314: Diff 288.Apr 29 2022, 20:20

Be bop be bop. I'm a bot. Builded:

→ D83-libre-busto-unsigned.apk

Harbormaster completed remote builds in B315: Diff 289.Apr 29 2022, 20:20

fabio.mazza retitled this revision from Database overhaul, using Room and MaTO for the data source to Make new fragment for lines, use new MaTO API.Apr 29 2022, 20:22

That's awesome!

And it works.

sgtm

Land.

This revision is now accepted and ready to land.Apr 30 2022, 01:29

Closed by commit R4:86d1f35a0336: Make new fragment for lines, use new MaTO API. · Explain WhyApr 30 2022, 08:23

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:86d1f35a0336: Make new fragment for lines, use new MaTO API.

valerio.bozzolan added a task: T12: Search by line number.Feb 7 2023, 23:15

Revision Contents
Changeset List

Path

Size

assets/

schemas/

it.reyboz.bustorino.data.gtfs.GtfsDatabase/

1.json

464 lines

2.json

648 lines

build.gradle

38 lines

res/

drawable/

ic_moving.xml

9 lines

ic_moving_emph.xml

9 lines

layout/

arrivals_nearby_card.xml

27 lines

bus_stop_line_elmt.xml

96 lines

entry_bus_stop.xml

113 lines

fragment_lines.xml

103 lines

menu/

drawer_main.xml

4 lines

menu_line_item.xml

9 lines

values-it/

strings.xml

22 lines

values/

keys.xml

1 line

strings.xml

17 lines

xml/

preferences.xml

8 lines

src/

androidTest/

java/

it/

reyboz/

bustorino/

data/

gtfs/

GtfsDBMigrationsTest.java

53 lines

it/

reyboz/

bustorino/

ActivityExperiments.java

57 lines

ActivityPrincipal.java

34 lines

adapters/

AdapterListener.java

ArrivalsStopAdapter.java

28 lines

NameCapitalize.java

44 lines

StopAdapter.java

2 lines

	StopAdapterListener.java
	AdapterListener.java

4 lines

StopRecyclerAdapter.java

98 lines

backend/

3 lines

1 line

6 lines

38 lines

5 lines

gtfs/

PolylineParser.java

48 lines

mato/

MapiArrivalRequest.java

5 lines

MapiVolleyRequest.java

4 lines

MatoAPIFetcher.kt

186 lines

MatoQueries.kt

76 lines

MatoVolleyJSONRequest.kt

48 lines

ResponseParsing.kt

120 lines

VolleyAllStopsRequest.kt

4 lines

utils.java

53 lines

data/

4 lines

48 lines

305 lines

36 lines

103 lines

OldDataRepository.java

58 lines

gtfs/

CsvTableInserter.kt

27 lines

GtfsAgency.kt

55 lines

	GtfsDBDao.kt
	StaticGtfsDao.kt

46 lines

42 lines

50 lines

19 lines

38 lines

140 lines

fragments/

FavoritesFragment.java

18 lines

FragmentKind.java

3 lines

FragmentListenerMain.java

3 lines

LinesFragment.kt

289 lines

LinesViewModel.kt

77 lines

MapFragment.java

2 lines

NearbyStopsFragment.java

239 lines

SettingsFragment.java

22 lines

middleware/

AsyncArrivalsSearcher.java

2 lines

util/

LinesNameSorter.java

76 lines

Commit	Tree	Parents	Author	Summary	Date
88cd05800f1b	4e98a565f782	9cb3ab99c6c6	Fabio Mazza	Remove stupid file	Apr 29 2022, 20:17
9cb3ab99c6c6	76beb4fd3d63	f2c61b7a9835	Fabio Mazza	Go back to the same fragment, finish up with strings	Apr 29 2022, 20:14
f2c61b7a9835	81a2d4ea73cd	a1987758ad7f	Fabio Mazza	Reuse adapter, fix strings	Apr 29 2022, 19:53
a1987758ad7f	dcaa31f7d72f	1fbe2a2502c4	Fabio Mazza	Use different layout for line shown	Apr 29 2022, 01:03
1fbe2a2502c4	dbf260676c50	60c8c9604991	Fabio Mazza	Better parsing of Capitalized string into noncapitalized one	Apr 28 2022, 00:56
60c8c9604991	2a42d73b4d49	1a7a4d2df18f	Fabio Mazza	Fix error and show finally the stops for the lines Use Singleton for DB Instance	Apr 28 2022, 00:55
1a7a4d2df18f	0a2cc0f7fd32	18bac54c4f8b	Fabio Mazza	Make stop with default gtfsID in constructor Get stops with certain IDs from DB… (Show More…)	Apr 27 2022, 01:00
18bac54c4f8b	ed504be46294	61ea90e0f458	Fabio Mazza	Show the lines nicely Add a button to force the database update Try to rewrite… (Show More…)	Apr 25 2022, 20:00
61ea90e0f458	693c8017b0c8	f32da8598e3a	Fabio Mazza	Use LiveData	Apr 22 2022, 16:53
f32da8598e3a	ecd702e7a643	cafc8c2117b1	Fabio Mazza	Experiment with LiveData and coroutines	Apr 21 2022, 01:20
cafc8c2117b1	c7be15bbdd96	5cb97060670b	Fabio Mazza	Make new fragment	Apr 20 2022, 10:29
5cb97060670b	677487c9d384	765c97ad8ab4	Fabio Mazza	Disable old test	Apr 19 2022, 19:26
765c97ad8ab4	6fd9cccb4661	c45ef8cf5bb7	Fabio Mazza	Database overhaul, using Room and MaTO for the data source (Show More…)	Apr 19 2022, 19:18
c45ef8cf5bb7	8eea2cadb51e	7de85595bff9	Fabio Mazza	Set limits for updates	Apr 19 2022, 14:58
7de85595bff9	0a844be7aeed	0b21bc611b76	Fabio Mazza	Add Migration and tests	Apr 19 2022, 14:38
0b21bc611b76	c44004b49231	dc8128d4e323	Fabio Mazza	Save patterns with stops in the DB	Apr 19 2022, 11:30
dc8128d4e323	5d0cddb0baeb	121bf63debda	Fabio Mazza	Add code for patterns	Apr 18 2022, 00:28
121bf63debda	00b9096227d4	5812330bc605	Fabio Mazza	Use low priority channel for the database notifications	Apr 17 2022, 12:22
5812330bc605	1aebf50dba9f	31166e01625d	Fabio Mazza	Make table for patterns, start with downloading polylines and stops	Apr 17 2022, 00:30
31166e01625d	5903b28f2845	ec2de84e924d	Fabio Mazza	Stop trying to download old lines	Apr 15 2022, 18:54
ec2de84e924d	6f1a1e682db3	b1c9bda7b78e	Fabio Mazza	Download routes from MaTO	Apr 15 2022, 00:31
b1c9bda7b78e	f67552b16e9c	b158d8dcf973	Fabio Mazza	Download agencies on update	Apr 12 2022, 00:39
b158d8dcf973	416f9f9ff348	706467c98ae0	Fabio Mazza	Work on getting feeds	Apr 11 2022, 17:04
706467c98ae0	ab0b89b162f7	47eb9a06cf84	Fabio Mazza	Change a bit the nearby stops logic	Apr 8 2022, 00:55
47eb9a06cf84	5b0c9cda14d0	5bd574240e23	Fabio Mazza	Use new Mato API for nearby stops	Feb 19 2022, 19:52