Page MenuHomeGitPull.it
Differential D28

Add angry bus image to favorites activity and improve the tip
ClosedPublic
Actions

Authored by andrea.ugo on Apr 24 2020, 20:20.
Tags
Referenced Files
F2108886: D28.id108.diff
Fri, Apr 26, 10:47
F2108885: D28.id105.diff
Fri, Apr 26, 10:47
F2108884: D28.id104.diff
Fri, Apr 26, 10:47
F2108883: D28.id.diff
Fri, Apr 26, 10:47
Unknown Object (File)
Thu, Apr 25, 14:07
Unknown Object (File)
Thu, Apr 25, 14:03
Unknown Object (File)
Thu, Apr 25, 05:54
Unknown Object (File)
Sat, Apr 20, 11:24
View All Files
Subscribers
virginiatuck

Details

Reviewers
valerio.bozzolan
Group Reviewers
Libre BusTO
Maniphest Tasks
T296: Make the Favorites activity more attractive on a fresh install
Commits
R4:38eb9b69080b: Add angry bus image to favorites activity and improve the tip
Summary

Make the Favorites activity more attractive on a fresh install

Merge branch 'master' of ssh://gitpull.it/source/libre-busto

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 82
Build 113: BusTO Build Plan
Build 112: arc lint + arc unit

Event Timeline

andrea.ugo created this revision.Apr 24 2020, 20:20
gitpull.android.builder added a comment.Apr 24 2020, 20:21

Be bop be bop. I'm a bot. Builded:

→ D28-libre-busto-unsigned.apk

Harbormaster completed remote builds in B81: Diff 104.Apr 24 2020, 20:21
andrea.ugo requested review of this revision.Apr 24 2020, 20:21
andrea.ugo added a task: T296: Make the Favorites activity more attractive on a fresh install.Apr 24 2020, 20:25
valerio.bozzolan requested changes to this revision.Apr 25 2020, 00:19

You may be able to keep this revision separate from D24: Add in-app map!, just updating this revision with your unrelated files rollbacked.

This revision now requires changes to proceed.Apr 25 2020, 00:19
valerio.bozzolan mentioned this in T296: Make the Favorites activity more attractive on a fresh install.Apr 25 2020, 00:24
andrea.ugo updated this revision to Diff 105.Apr 25 2020, 17:36

Fix wrong diff

gitpull.android.builder added a comment.Apr 25 2020, 17:38

Be bop be bop. I'm a bot. Builded:

→ D28-libre-busto-unsigned.apk

Harbormaster completed remote builds in B82: Diff 105.Apr 25 2020, 17:38
valerio.bozzolan accepted this revision as: valerio.bozzolan.Apr 25 2020, 18:42
valerio.bozzolan added a subscriber: virginiatuck.

surprisedpika

This is amazing. Accepted immediately.

Good job @andrea.ugo and @virginiatuck.

valerio.bozzolan accepted this revision.Apr 25 2020, 18:54
This revision is now accepted and ready to land.Apr 25 2020, 18:54
Closed by commit R4:38eb9b69080b: Add angry bus image to favorites activity and improve the tip. · Explain WhyApr 25 2020, 21:44
This revision was automatically updated to reflect the committed changes.
andrea.ugo added a commit: R4:38eb9b69080b: Add angry bus image to favorites activity and improve the tip.

Revision Contents
Changeset List

PathSize
res/
drawable/
171 lines
layout/
10 lines
values-it/
2 lines
values/
2 lines
src/
it/
reyboz/
bustorino/
2 lines

Diff 105

View Options

res/drawable/ic_angery_bus.xml

Loading...
View Options

res/layout/activity_favorites.xml

Loading...
View Options

res/values-it/strings.xml

Loading...
View Options

res/values/strings.xml

Loading...
View Options

src/it/reyboz/bustorino/ActivityFavorites.java

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register