Page MenuHomeGitPull.it

Add in-app map!
Needs ReviewPublic

Authored by andrea.ugo on Apr 13 2020, 23:49.

Details

Summary

Add in-app map accessible from the button on the top menu. Change function to view a fovourite stop on the map.

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 80
Build 109: BusTO Build Plan
Build 108: arc lint + arc unit

Event Timeline

andrea.ugo created this revision.Apr 13 2020, 23:49
Restricted Application added a project: Libre BusTO . · View Herald TranscriptApr 13 2020, 23:49
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Be bop be bop. I'm a bot. Builded:

D24-libre-busto-unsigned.apk

Harbormaster completed remote builds in B63: Diff 88.Apr 13 2020, 23:51
andrea.ugo requested review of this revision.Apr 13 2020, 23:51
andrea.ugo updated this revision to Diff 89.Apr 20 2020, 09:02

Add markers and simple markers' functions to the in-app map - Merge branch 'master' of ssh://gitpull.it/source/libre-busto

Be bop be bop. I'm a bot. Builded:

D24-libre-busto-unsigned.apk

Harbormaster completed remote builds in B68: Diff 89.Apr 20 2020, 09:04
andrea.ugo added a comment.EditedApr 20 2020, 11:39

I added some markers to the map, the map loads only the markers wich are in the screen.
On the first tap the markers show the info window popup, on the second, they take you to a wonderful trip to the stop's tab.

As you can see the info windows is still ugly. I'll work on it.

fabio.mazza requested changes to this revision.Apr 20 2020, 21:59
fabio.mazza added a subscriber: fabio.mazza.

The app should ask for the STORAGE permission, otherwise osmdroid won't use the cache to save the tiles.
Giving the permission manually gives a strong boost to the tiles loading.

This revision now requires changes to proceed.Apr 20 2020, 21:59

Also, I think that touching the "bubble" that comes out of a stop should make it show the arrivals at the stop

andrea.ugo updated this revision to Diff 91.Apr 21 2020, 15:16

Add a personalized popup info window and some graphic improvments - Merge branch 'master' of ssh://gitpull.it/source/libre-busto

Be bop be bop. I'm a bot. Builded:

D24-libre-busto-unsigned.apk

Harbormaster completed remote builds in B70: Diff 91.Apr 21 2020, 15:18

Also, I think that touching the "bubble" that comes out of a stop should make it show the arrivals at the stop

With this last Diff I did also that: I added a custom info window class that extends default info window class.
So, now the popup is clickable and it's also personalizable. I will work on its design.

This is the actual feel:

I sincerely see that you are going in the right direction. Now we only need some user interface sugar.

I opened T305: Design a suitable bus stop POI icon to further improve the design of this part. I'm inclined to accept this revision at this state because is stable enough.

andrea.ugo updated this revision to Diff 101.Apr 24 2020, 18:00

Add angry bus image to favorites activity and improve the tip - Merge branch 'master' of ssh://gitpull.it/source/libre-busto

Be bop be bop. I'm a bot. Builded:

D24-libre-busto-unsigned.apk

Harbormaster completed remote builds in B78: Diff 101.Apr 24 2020, 18:02
andrea.ugo updated this revision to Diff 102.Apr 24 2020, 18:37

Fix wrong diff - Merge branch 'master' of ssh://gitpull.it/source/libre-busto

Be bop be bop. I'm a bot. Builded:

D24-libre-busto-unsigned.apk

Harbormaster completed remote builds in B79: Diff 102.Apr 24 2020, 18:39
andrea.ugo updated this revision to Diff 103.Apr 24 2020, 18:39

Fix wrong diff - Merge branch 'master' of ssh://gitpull.it/source/libre-busto

Be bop be bop. I'm a bot. Builded:

D24-libre-busto-unsigned.apk

Harbormaster completed remote builds in B80: Diff 103.Apr 24 2020, 18:40