Details

Reviewers

valerio.bozzolan
fabio.mazza

Group Reviewers

Libre BusTO

Maniphest Tasks

T15: Show in-app map

Commits

R4:b2b6e0403f74: Add in-app map!
R4:b1e806d2c69c: Add a way to query all the Bus Stops in a Map view

Summary

Add in-app map accessible from the button on the top menu. Change function to view a fovourite stop on the map.

Diff Detail

Repository

R4 Libre BusTO

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrea.ugo created this revision.Apr 13 2020, 23:49

Restricted Application added a project: Libre BusTO . · View Herald TranscriptApr 13 2020, 23:49

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Be bop be bop. I'm a bot. Builded:

→ D24-libre-busto-unsigned.apk

Harbormaster completed remote builds in B63: Diff 88.Apr 13 2020, 23:51

andrea.ugo requested review of this revision.Apr 13 2020, 23:51

You can pull the latest changes from master to take advantage of this (maybe) useful method:

R4:b1e806d2c69c: Add a way to query all the Bus Stops in a Map view

valerio.bozzolan removed a commit: R4:b1e806d2c69c: Add a way to query all the Bus Stops in a Map view.Apr 17 2020, 19:33

valerio.bozzolan added a commit: R4:b1e806d2c69c: Add a way to query all the Bus Stops in a Map view.

Add markers and simple markers' functions to the in-app map - Merge branch 'master' of ssh://gitpull.it/source/libre-busto

Be bop be bop. I'm a bot. Builded:

→ D24-libre-busto-unsigned.apk

Harbormaster completed remote builds in B68: Diff 89.Apr 20 2020, 09:04

I added some markers to the map, the map loads only the markers wich are in the screen.
On the first tap the markers show the info window popup, on the second, they take you to a wonderful trip to the stop's tab.

Screenshot_1587374144.png (2×1 px, 1 MB)

As you can see the info windows is still ugly. I'll work on it.

The app should ask for the STORAGE permission, otherwise osmdroid won't use the cache to save the tiles.
Giving the permission manually gives a strong boost to the tiles loading.

This revision now requires changes to proceed.Apr 20 2020, 21:59

Also, I think that touching the "bubble" that comes out of a stop should make it show the arrivals at the stop

Add a personalized popup info window and some graphic improvments - Merge branch 'master' of ssh://gitpull.it/source/libre-busto

Be bop be bop. I'm a bot. Builded:

→ D24-libre-busto-unsigned.apk

Harbormaster completed remote builds in B70: Diff 91.Apr 21 2020, 15:18

In D24#476, @fabio.mazza wrote:

Also, I think that touching the "bubble" that comes out of a stop should make it show the arrivals at the stop

With this last Diff I did also that: I added a custom info window class that extends default info window class.
So, now the popup is clickable and it's also personalizable. I will work on its design.

This is the actual feel:

Screenshot_1587621878.png (1×768 px, 606 KB)

I sincerely see that you are going in the right direction. Now we only need some user interface sugar.

valerio.bozzolan added a task: T15: Show in-app map.Apr 23 2020, 08:24

I opened T305: Design a suitable bus stop POI icon for the in-app map to further improve the design of this part. I'm inclined to accept this revision at this state because is stable enough.

valerio.bozzolan subscribed.Apr 23 2020, 08:34

valerio.bozzolan mentioned this in T305: Design a suitable bus stop POI icon for the in-app map.Apr 23 2020, 08:40

Add angry bus image to favorites activity and improve the tip - Merge branch 'master' of ssh://gitpull.it/source/libre-busto

Be bop be bop. I'm a bot. Builded:

→ D24-libre-busto-unsigned.apk

Harbormaster completed remote builds in B78: Diff 101.Apr 24 2020, 18:02

andrea.ugo removed a commit: R4:b1e806d2c69c: Add a way to query all the Bus Stops in a Map view.Apr 24 2020, 18:05

andrea.ugo added a commit: R4:b1e806d2c69c: Add a way to query all the Bus Stops in a Map view.Apr 24 2020, 18:15

Fix wrong diff - Merge branch 'master' of ssh://gitpull.it/source/libre-busto

Be bop be bop. I'm a bot. Builded:

→ D24-libre-busto-unsigned.apk

Harbormaster completed remote builds in B79: Diff 102.Apr 24 2020, 18:39