Page MenuHomeGitPull.it
Differential D122

Download missing patterns when downloading trips
ClosedPublic
Actions

Authored by fabio.mazza on Jun 26 2023, 01:26.

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
T1170: Fix crash caused by Can't access ViewModels from detached fragment on version 1.18.4 (Fragment.java:400)
Commits
R4:f4dc0a60f750: Download missing patterns when downloading trips
Summary

Download patterns when they are null in the DB

Delete old patterns on update

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 423
Build 605: BusTO Build Plan
Build 604: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Jun 26 2023, 01:26
Restricted Application added a project: Libre BusTO . · View Herald TranscriptJun 26 2023, 01:26
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.Jun 26 2023, 01:28

Be bop be bop. I'm a bot. Builded successfully ✨

D122-libre-busto.apk

sha256 606abbf7c86ccc6f884193f35e66240773ec88c26c655a53ff3521b06471ecec  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk
Harbormaster completed remote builds in B422: Diff 392.Jun 26 2023, 01:28
fabio.mazza requested review of this revision.Jun 26 2023, 01:28
fabio.mazza updated this revision to Diff 393.Jun 26 2023, 01:28
  • Remove commented code
gitpull.android.builder added a comment.Jun 26 2023, 01:31

Be bop be bop. I'm a bot. Builded successfully ✨

D122-libre-busto.apk

sha256 8ced1b69a365fee3f4460192f4ecc91f2efd9d5594e49dd53b468f71864783ea  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk
Harbormaster completed remote builds in B423: Diff 393.Jun 26 2023, 01:31
valerio.bozzolan accepted this revision.Jun 26 2023, 07:43
_______________ / Thanks \ | Tested | \ No implosions / --------------- \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || ||

lgtm

This revision is now accepted and ready to land.Jun 26 2023, 07:43
Closed by commit R4:f4dc0a60f750: Download missing patterns when downloading trips. · Explain WhyJun 28 2023, 11:10
This revision was automatically updated to reflect the committed changes.
fabio.mazza added a commit: R4:f4dc0a60f750: Download missing patterns when downloading trips.
fabio.mazza mentioned this in T1170: Fix crash caused by Can't access ViewModels from detached fragment on version 1.18.4 (Fragment.java:400).Jun 28 2023, 11:11
valerio.bozzolan added a task: T1170: Fix crash caused by Can't access ViewModels from detached fragment on version 1.18.4 (Fragment.java:400).Jun 28 2023, 11:17

Revision Contents
Changeset List

PathSize
app/
src/
main/
java/
it/
reyboz/
bustorino/
backend/
33 lines
mato/
15 lines
2 lines
data/
41 lines
101 lines
MatoTripsDownloadWorker.kt
MatoDownloadTripsWorker.kt
79 lines
gtfs/
12 lines
2 lines
fragments/
11 lines
100 lines
2 lines

Diff 393

View Options

app/src/main/java/it/reyboz/bustorino/backend/Notifications.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/backend/mato/MatoAPIFetcher.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/backend/mato/MatoQueries.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/data/DatabaseUpdate.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/data/MatoDownloadTripsWorker.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/data/MatoPatternsDownloadWorker.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/data/MatoTripsDownloadWorker.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsDBDao.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/data/gtfs/GtfsTrip.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/MapFragment.java

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/MapViewModel.kt

Loading...
View Options

app/src/main/java/it/reyboz/bustorino/fragments/SettingsFragment.java

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register