Make new lines fragment showing each line on the map, use MQTT positions
ClosedPublic
Actions

Authored by fabio.mazza on Aug 25 2023, 01:11.

Project Tags

Referenced Files

	F11420584: D126.1773471420.diff
	Fri, Mar 13, 07:57

	F11419182: D126.1773459914.diff
	Fri, Mar 13, 04:45

Subscribers

valerio.bozzolan

Libre BusTO

Details

Reviewers

valerio.bozzolan

Maniphest Tasks

T1184: Increase API level from Kitkat to Lollipop, since Kitkat is damn insecure
T1183: Map: add a small black border to Bus icons (for better accessibility)
T1182: Map: do not consider current geolocation if you are too distant from Torino (e.g. if you are on vacation in Timbuktu)

Commits

R4:59a3c670e91d: Make new lines fragment showing each line on the map, use MQTT positions

Summary

Raise min sdk version to lollipop and update dependencies

Use single class for live position updates, use new viewmodel

Tweak map visuals

Simplify code

Update dependencies, upgrade kotlin, change library for MQTT. Also, try to fix animation.

Show buses in the line detail fragment

Change color of bus marker, draw border of marker in black

Reach perfect layout for BusInfoWindow, with and without close icon

Fix bugs

Sanitize directions (attempt)

Switch between list of stops and map

Diff Detail

Repository

R4 Libre BusTO

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 435
Build 622: BusTO Build Plan
Build 621: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Aug 25 2023, 01:11

Restricted Application added a project: Libre BusTO . · View Herald TranscriptAug 25 2023, 01:11

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript

Be bop be bop. I'm a bot. Builded successfully ✨

D126-libre-busto.apk

sha256 a8aa5667084703f7e824a6328503fb07f7f1e4bfc943b306725ec6a2e459bee8  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk

Harbormaster completed remote builds in B435: Diff 403.Aug 25 2023, 01:14

fabio.mazza requested review of this revision.Aug 25 2023, 01:14

AWESOME - TESTED - IT WORKS ASD TAANK YOU \o/

sgtm

This revision is now accepted and ready to land.Aug 25 2023, 07:03

Closed by commit R4:59a3c670e91d: Make new lines fragment showing each line on the map, use MQTT positions. · Explain WhyAug 25 2023, 20:26

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:59a3c670e91d: Make new lines fragment showing each line on the map, use MQTT positions.

valerio.bozzolan added a task: T1182: Map: do not consider current geolocation if you are too distant from Torino (e.g. if you are on vacation in Timbuktu).Aug 26 2023, 09:47

valerio.bozzolan added a task: T1183: Map: add a small black border to Bus icons (for better accessibility).Aug 26 2023, 09:57

valerio.bozzolan added a task: T1184: Increase API level from Kitkat to Lollipop, since Kitkat is damn insecure.Aug 26 2023, 10:04

Revision Contents
Changeset List

Path

Size

app/

build.gradle

lines

src/

androidTest/

java/

it/

reyboz/

bustorino/

data/

gtfs/

GtfsDBMigrationsTest.java

lines

main/

java/

it/

reyboz/

bustorino/

ActivityExperiments.java

lines

ActivityPrincipal.java

lines

adapters/

RouteAdapter.kt

lines

SquareStopAdapter.java

lines

backend/

gtfs/

GtfsPositionUpdate.kt

GtfsRtPositionsRequest.kt

lines

	LivePositionUpdate.kt
	GtfsPositionUpdate.kt

lines

mato/

lines

lines

lines

lines

data/

GtfsRepository.kt

lines

fragments/

CommonFragmentListener.java

lines

	GTFSPositionsViewModel.kt
	MapViewModel.kt

lines

LinesDetailFragment.kt

lines

LinesFragment.kt

lines

LinesGridShowingFragment.kt

lines

LinesViewModel.kt

lines

MainScreenFragment.java

lines

MapFragment.java

lines

MapViewModel.kt

NearbyStopsFragment.java

lines

TestRealtimeGtfsFragment.kt

lines

map/

BusInfoWindow.kt

lines

BusPositionUtils.kt

lines

CustomInfoWindow.java

lines

MapViewModel.kt

lines

MarkerAnimation.java

MarkerUtils.java

lines

middleware/

AutoFitGridLayoutManager.kt

lines

util/

ViewUtils.kt

lines

viewmodels/

LinesGridShowingViewModel.kt

lines

MQTTPositionsViewModel.kt

lines

res/

drawable/

ball.xml

lines

baseline_chevron_right_24.xml

lines

baseline_close_16.xml

lines

ic_list_30.xml

lines

ic_map_white_30.xml

lines

map_bus_position_icon.xml

lines

point_heading_icon.xml

layout/

bus_info_window.xml

lines

fragment_lines_detail.xml

lines

fragment_lines_grid.xml

lines

fragment_test_realtime_gtfs.xml

lines

line_title_header.xml

lines

linedetail_stop_infowindow.xml

lines

values-it/

strings.xml

lines

values/

colors.xml

lines

dimens.xml

line

strings.xml

lines

test/

java/

it/

reyboz/

bustorino/

util/

DistanceTest.java

lines

build.gradle

lines

Commit	Tree	Parents	Author	Summary	Date
56c9cfaaee29	4753fbc2cf57	e7f6b4886674	Fabio Mazza	Fix not showing same line when going back	Aug 24 2023, 00:30
e7f6b4886674	a3264aad6f9f	95bfe8c9ce33	Fabio Mazza	Try with constraintlayout	Aug 23 2023, 18:29
95bfe8c9ce33	a57fd1c30eb2	6ab33c93c9d6	Fabio Mazza	Use new fragment for lines	Aug 23 2023, 17:33
6ab33c93c9d6	661ea853a0f3	dd07f680a093	Fabio Mazza	Try reconnecting (without resubscribing)	Aug 23 2023, 17:19
dd07f680a093	ecc59b2a5434	4a04f0646c4b	Fabio Mazza	Switch between list of stops and map	Aug 23 2023, 17:12
4a04f0646c4b	c54622b52f33	8d6c3b9d8ad3	Fabio Mazza	Beautify first fragment of lines. Include list of stop in fragment lines detail	Aug 23 2023, 16:20
8d6c3b9d8ad3	da1a07d6e7e7	c3e4e4732398	Fabio Mazza	Sanitize directions (attempt)	Aug 23 2023, 01:09
c3e4e4732398	c14ae5ed343e	d1f4d0ff7c2b	Fabio Mazza	Beautify lines screen	Aug 23 2023, 00:40
d1f4d0ff7c2b	6d25d5745017	ce5b7c0c6be6	Fabio Mazza	Make it work	Aug 22 2023, 22:19
ce5b7c0c6be6	4574a11bab2d	9cff9cc22065	Fabio Mazza	Tweak fragment	Aug 21 2023, 19:21
9cff9cc22065	4021e3938fbe	9208228d1a31	Fabio Mazza	Disable reconnect	Aug 21 2023, 18:59
9208228d1a31	39f5356ee1f0	57e06fd9ae71	Fabio Mazza	Fix bugs	Aug 21 2023, 18:57
57e06fd9ae71	229c52110bfc	d3a614293445	Fabio Mazza	Reach perfect layout for BusInfoWindow, with and without close icon	Aug 21 2023, 18:21
d3a614293445	f57491e68b91	b88629789c1d	Fabio Mazza	Change color of bus marker, draw border of marker in black	Aug 21 2023, 15:41
b88629789c1d	b9c5941c53e5	79c8081cb8cd	Fabio Mazza	Add Initial comments	Aug 21 2023, 15:13
79c8081cb8cd	246983875e61	3a372625f3df	Fabio Mazza	Show buses in the line detail fragment	Aug 21 2023, 15:11
3a372625f3df	8d143cd92f7a	f6ce6af27ba0	Fabio Mazza	Update dependencies, upgrade kotlin, change library for MQTT. Also, try to fix… (Show More…)	Aug 21 2023, 00:22
f6ce6af27ba0	321aab79c14c	a069518f2477	Fabio Mazza	Simplify code	Aug 19 2023, 23:58
a069518f2477	8c155a790dcd	31a18f5f0ee0	Fabio Mazza	Tweak map visuals	Aug 19 2023, 23:55
31a18f5f0ee0	a04a1bca1201	4fa52036fed2	Fabio Mazza	Make it work	Aug 19 2023, 23:27
4fa52036fed2	124751d08e31	ec8c0bd4efcf	Fabio Mazza	Use single class for live position updates, use new viewmodel	Aug 19 2023, 22:42
ec8c0bd4efcf	b82f0c5c908a	6485dfc3a34e	Fabio Mazza	Fix regression bug	Aug 19 2023, 20:40
6485dfc3a34e	316117a6e597	00229d595610	Fabio Mazza	Start creating MQTT positions viewmodel	Aug 18 2023, 19:08
00229d595610	7e4a9e9c6465	382217d0127f	Fabio Mazza	Finish the MQTTMatoClient	Aug 17 2023, 13:33
382217d0127f	74bb3e8f7fbf	ab1de9593797	Fabio Mazza	Parse message into response object	Aug 14 2023, 21:29
ab1de9593797	3e4bdadbce2c	48b557b80c1e	Fabio Mazza	Start making client for MQTT service	Aug 14 2023, 01:10
48b557b80c1e	0bb0d0ae6a3f	e0a9312571ac	Fabio Mazza	Show stops in new line fragment, add closing icon, generalize closing window	Aug 10 2023, 22:28
e0a9312571ac	f9f4f5298917	cedec086ee2a	Fabio Mazza	Show stops in the LinesDetailFragment	Aug 8 2023, 22:56
cedec086ee2a	381e923381a8	b83a20f3ae46	Fabio Mazza	Fix map not showing in LinesDetailFragment	Aug 8 2023, 21:36
b83a20f3ae46	b09a3e9a3c66	00777132cc31	Fabio Mazza	Raise min sdk version to lollipop and update dependencies	Aug 8 2023, 21:09