Differential D131

Use ViewModels in nearby stops fragment, move help text to arrivals fragment
ClosedPublic
Actions

Authored by fabio.mazza on Aug 29 2023, 12:58.

Details

Reviewers

valerio.bozzolan

Commits

R4:2d32930b74e1: Use ViewModels in nearby stops fragment, move help text to arrivals fragment

Summary

Make space for theme change

Diff Detail

Repository

R4 Libre BusTO

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 446
Build 640: BusTO Build Plan
Build 639: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.Aug 29 2023, 12:58

Restricted Application added a project: Libre BusTO . · View Herald TranscriptAug 29 2023, 12:58

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript

Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript

Be bop be bop. I'm a bot. Builded successfully ✨

D131-libre-busto.apk

sha256 3e26d0b330a8ee8a60b55ce6191cd5782bfd61c226859a529f6f7fa19714bb5e  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk

Harbormaster completed remote builds in B445: Diff 413.Aug 29 2023, 13:01

fabio.mazza requested review of this revision.Aug 29 2023, 13:01

No nuclear implosions

This revision is now accepted and ready to land.Aug 29 2023, 15:02

Use ViewModel for the NearbyStopsFragment instead of Loaders

This revision now requires review to proceed.Aug 30 2023, 00:19

fabio.mazza retitled this revision from Move explanation text view to ArrivalsFragment to Use ViewModels in nearby stops fragment, move help text to arrivals fragment.Aug 30 2023, 00:21

Be bop be bop. I'm a bot. Builded successfully ✨

D131-libre-busto.apk

sha256 6f5967db4cdf9134d8217a12a14cdc27c2069b3d0bdb2bcf7404d9eabbcd0cd1  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk

Harbormaster completed remote builds in B446: Diff 414.Aug 30 2023, 00:21

sgtm

(Just reported an unrelated thing in the group)

This revision is now accepted and ready to land.Aug 30 2023, 09:00

Closed by commit R4:2d32930b74e1: Use ViewModels in nearby stops fragment, move help text to arrivals fragment. · Explain WhyAug 30 2023, 12:05

This revision was automatically updated to reflect the committed changes.

fabio.mazza added a commit: R4:2d32930b74e1: Use ViewModels in nearby stops fragment, move help text to arrivals fragment.

Revision Contents
Changeset List

Path

Size

app/

build.gradle

1 line

src/

main/

AndroidManifest.xml

21 lines

java/

it/

reyboz/

bustorino/

adapters/

ArrivalsStopAdapter.java

12 lines

SquareStopAdapter.java

7 lines

backend/

GPSPoint.java

34 lines

Stop.java

11 lines

utils.java

31 lines

data/

AppDataProvider.java

17 lines

OldDataRepository.kt

19 lines

fragments/

ArrivalsFragment.java

32 lines

MainScreenFragment.java

27 lines

NearbyStopsFragment.java

147 lines

ScreenBaseFragment.java

16 lines

util/

RoutePositionSorter.java

15 lines

StopSorterByDistance.java

12 lines

viewmodels/

NearbyStopsViewModel.kt

75 lines

res/

drawable/

top_bottom_border_radius.xml

9 lines

top_bottom_border_radius_with_border.xml

12 lines

layout/

fragment_arrivals.xml

39 lines

fragment_lines_detail.xml

2 lines

fragment_main_screen.xml

33 lines

values/

colors.xml

10 lines

styles.xml

20 lines

Diff 414

View Options

app/build.gradle

View Options

app/src/main/AndroidManifest.xml

View Options

app/src/main/java/it/reyboz/bustorino/adapters/ArrivalsStopAdapter.java

View Options

app/src/main/java/it/reyboz/bustorino/adapters/SquareStopAdapter.java

View Options

app/src/main/java/it/reyboz/bustorino/backend/GPSPoint.java

View Options

app/src/main/java/it/reyboz/bustorino/backend/Stop.java

View Options

app/src/main/java/it/reyboz/bustorino/backend/utils.java

View Options

app/src/main/java/it/reyboz/bustorino/data/AppDataProvider.java

View Options

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.kt

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

View Options

app/src/main/java/it/reyboz/bustorino/util/RoutePositionSorter.java

View Options

app/src/main/java/it/reyboz/bustorino/util/StopSorterByDistance.java

View Options

app/src/main/java/it/reyboz/bustorino/viewmodels/NearbyStopsViewModel.kt

View Options

app/src/main/res/drawable/top_bottom_border_radius.xml

View Options

app/src/main/res/drawable/top_bottom_border_radius_with_border.xml

View Options

app/src/main/res/layout/fragment_arrivals.xml

View Options

app/src/main/res/layout/fragment_lines_detail.xml

View Options

app/src/main/res/layout/fragment_main_screen.xml

View Options

app/src/main/res/values/colors.xml

View Options

app/src/main/res/values/styles.xml

Use ViewModels in nearby stops fragment, move help text to arrivals fragmentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 414

app/build.gradle

app/src/main/AndroidManifest.xml

app/src/main/java/it/reyboz/bustorino/adapters/ArrivalsStopAdapter.java

app/src/main/java/it/reyboz/bustorino/adapters/SquareStopAdapter.java

app/src/main/java/it/reyboz/bustorino/backend/GPSPoint.java

app/src/main/java/it/reyboz/bustorino/backend/Stop.java

app/src/main/java/it/reyboz/bustorino/backend/utils.java

app/src/main/java/it/reyboz/bustorino/data/AppDataProvider.java

app/src/main/java/it/reyboz/bustorino/data/OldDataRepository.kt

app/src/main/java/it/reyboz/bustorino/fragments/ArrivalsFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/MainScreenFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/NearbyStopsFragment.java

app/src/main/java/it/reyboz/bustorino/fragments/ScreenBaseFragment.java

app/src/main/java/it/reyboz/bustorino/util/RoutePositionSorter.java

app/src/main/java/it/reyboz/bustorino/util/StopSorterByDistance.java

app/src/main/java/it/reyboz/bustorino/viewmodels/NearbyStopsViewModel.kt

app/src/main/res/drawable/top_bottom_border_radius.xml

app/src/main/res/drawable/top_bottom_border_radius_with_border.xml

app/src/main/res/layout/fragment_arrivals.xml

app/src/main/res/layout/fragment_lines_detail.xml

app/src/main/res/layout/fragment_main_screen.xml

app/src/main/res/values/colors.xml

app/src/main/res/values/styles.xml

Use ViewModels in nearby stops fragment, move help text to arrivals fragment
ClosedPublic
Actions

Revision Contents
Changeset List