Page MenuHomeGitPull.it
Differential D112

Change colors of the side navigation menu
ClosedPublic
Actions

Authored by fabio.mazza on May 28 2023, 20:43.
Tags
Referenced Files
Unknown Object (File)
Mon, Apr 22, 05:01
Unknown Object (File)
Sat, Apr 20, 14:44
Unknown Object (File)
Thu, Apr 18, 12:45
Unknown Object (File)
Thu, Apr 18, 12:45
Unknown Object (File)
Thu, Apr 18, 12:45
Unknown Object (File)
Sun, Apr 14, 21:44
Unknown Object (File)
Sun, Apr 14, 14:47
Unknown Object (File)
Sun, Apr 14, 09:57
View All Files
Subscribers
valerio.bozzolan
Libre BusTO

Details

Reviewers
valerio.bozzolan
Maniphest Tasks
T1164: Change colors of the left navigation panel
Commits
R4:ef2704998a5c: Change colors of the side navigation menu
Summary

Change the colors of the side navigation panel.

BeforeAfter
Libre BusTO menu before.png (2×1 px, 70 KB)
Libre BusTO menu after.png (2×1 px, 71 KB)

Closes T1164

Test Plan

Swipe from left to right and look at the beautiful colors.

Diff Detail

Repository
R4 Libre BusTO
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 391
Build 560: BusTO Build Plan
Build 559: arc lint + arc unit

Event Timeline

fabio.mazza created this revision.May 28 2023, 20:43
Restricted Application added a project: Libre BusTO . · View Herald TranscriptMay 28 2023, 20:43
Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
gitpull.android.builder added a comment.May 28 2023, 20:49

Be bop be bop. I'm a bot. Builded:

→ D112-libre-busto-unsigned.apk

Harbormaster completed remote builds in B391: Diff 364.May 28 2023, 20:49
fabio.mazza requested review of this revision.May 28 2023, 20:49
Harbormaster failed remote builds in B391: Diff 364!May 29 2023, 08:21
Harbormaster completed remote builds in B391: Diff 364.May 29 2023, 08:49
valerio.bozzolan mentioned this in R65:adc93f42c9e5: clean already-used artifacts to avoid future re-use.May 29 2023, 08:58
valerio.bozzolan accepted this revision.May 29 2023, 09:00

Tested. This works. THIS IS SO BEAUTIFUL.

SUPER APPROVED asd

sgtm

This revision is now accepted and ready to land.May 29 2023, 09:00
valerio.bozzolan edited the summary of this revision. (Show Details)May 29 2023, 09:01
valerio.bozzolan edited the test plan for this revision. (Show Details)
valerio.bozzolan edited the summary of this revision. (Show Details)May 29 2023, 09:06
valerio.bozzolan added a task: T1164: Change colors of the left navigation panel.
valerio.bozzolan added a comment.Jun 3 2023, 09:38

Should we wait, or Land?

Closed by commit R4:ef2704998a5c: Change colors of the side navigation menu. · Explain WhyJun 3 2023, 12:46
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: R4:ef2704998a5c: Change colors of the side navigation menu.
fabio.mazza mentioned this in T735: Design navigation drawer.Jun 4 2023, 20:14

Revision Contents
Changeset List

PathSize
app/
res/
layout/
9 lines
6 lines
values/
4 lines

Diff 364

View Options

app/res/layout/activity_principal.xml

Loading...
View Options

app/res/layout/nav_header.xml

Loading...
View Options

app/res/values/colors.xml

Loading...
Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) or GNU Free Documentation License (at your option) unless otherwise noted. · Contact / Register