Page MenuHomeGitPull.it

Show lines without any arrival times separately
ClosedPublic

Authored by fabio.mazza on Jun 15 2023, 01:48.
Referenced Files
F2200268: D119.1721450530.diff
Fri, Jul 19, 06:42
Unknown Object (File)
Tue, Jul 16, 23:09
Unknown Object (File)
Tue, Jul 16, 17:06
Unknown Object (File)
Tue, Jul 16, 15:28
Unknown Object (File)
Mon, Jul 15, 21:14
Unknown Object (File)
Mon, Jul 15, 21:13
Unknown Object (File)
Mon, Jul 15, 17:54
Unknown Object (File)
Mon, Jul 15, 00:29

Details

Summary

Show the lines for which no arrivals are found at the bottom, with only the line name in a bubble. This is useful especially in the night to avoid taking up unnecessary space on the screen.

On the technical side:

  • Stop using listfragment as base for arrivals fragment
  • Use recyclerview for the arrival times

Diff Detail

Repository
R4 Libre BusTO
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Restricted Application added a reviewer: valerio.bozzolan. · View Herald Transcript
Restricted Application added subscribers: Libre BusTO , valerio.bozzolan. · View Herald Transcript
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 15 2023, 01:50
Harbormaster failed remote builds in B410: Diff 384!

Be bop be bop. I'm a bot. Builded:

D119-libre-busto.apk

sha256 62d746c6ecd93fb53e3caabbb3d12a7b745a3754465d7c3a4a5022c804ae2a76  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk
  • Try fixing stuff
  • Last try with constraint layout
  • Reuse trick of double linear layout
  • Sort lines for no arrivals, remove unneeded separator

Be bop be bop. I'm a bot. Builded:

D119-libre-busto.apk

sha256 6ce2a49a728481181b3c63a420f14e583e290480c9f43a6615d3989e3ed2e08f  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk

Be bop be bop. I'm a bot. Builded:

D119-libre-busto.apk

sha256 4d09fac8742d579dfae8eaa9e10a81c0fe7ff9a05807719f9ea3641a4168ab17  ./app/build/outputs/apk/gitpull/app-gitpull-signed.apk
This revision is now accepted and ready to land.Jun 15 2023, 17:26